From: Vignesh R <vigneshr@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tony Lindgren <tony@atomide.com>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Roger Quadros <rogerq@ti.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Frodo Lai <frodo.lai@gmail.com>, Jingoo Han <jg1.han@samsung.com>,
linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt
Date: Wed, 22 Jul 2015 10:54:25 +0530 [thread overview]
Message-ID: <55AF2909.5090609@ti.com> (raw)
In-Reply-To: <20150720062407.GA13092@dtor-ws>
Hi Dmitry,
On 07/20/2015 11:54 AM, Dmitry Torokhov wrote:
> On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [150719 21:53]:
>>> @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev)
>>> dev_dbg(dev, "%s: x %d, y %d, gpio %d\n", __func__,
>>> pdata->x_max + 1, pdata->y_max + 1, pdata->gpio_attb);
>>>
>>> + pdata->wakeirq = of_irq_get_byname(dev->of_node, "wakeupirq");
>>> +
>>> return pdata;
>>
>> What about handling -EPROVE_DEFER here? At least pinctrl-single can be
>> be a loadable module for the dedicated wakeirqs.
>
> Right. I think we should only allow -ENODATA to continue and return
> error in all other cases.
-EINVAL will be returned if "interrupt-names" is not specified. I will
make execption for -ENODATA & -EINVAL, and return error in all other cases?
>
> Also, I think "irq" suffix on name is redundant.
Ok, will drop "irq" suffix:
+ interrupt-names = "tsc", "wakeup";
>
> Thanks.
>
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: vigneshr@ti.com (Vignesh R)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt
Date: Wed, 22 Jul 2015 10:54:25 +0530 [thread overview]
Message-ID: <55AF2909.5090609@ti.com> (raw)
In-Reply-To: <20150720062407.GA13092@dtor-ws>
Hi Dmitry,
On 07/20/2015 11:54 AM, Dmitry Torokhov wrote:
> On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [150719 21:53]:
>>> @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev)
>>> dev_dbg(dev, "%s: x %d, y %d, gpio %d\n", __func__,
>>> pdata->x_max + 1, pdata->y_max + 1, pdata->gpio_attb);
>>>
>>> + pdata->wakeirq = of_irq_get_byname(dev->of_node, "wakeupirq");
>>> +
>>> return pdata;
>>
>> What about handling -EPROVE_DEFER here? At least pinctrl-single can be
>> be a loadable module for the dedicated wakeirqs.
>
> Right. I think we should only allow -ENODATA to continue and return
> error in all other cases.
-EINVAL will be returned if "interrupt-names" is not specified. I will
make execption for -ENODATA & -EINVAL, and return error in all other cases?
>
> Also, I think "irq" suffix on name is redundant.
Ok, will drop "irq" suffix:
+ interrupt-names = "tsc", "wakeup";
>
> Thanks.
>
--
Regards
Vignesh
WARNING: multiple messages have this Message-ID (diff)
From: Vignesh R <vigneshr@ti.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Tony Lindgren <tony@atomide.com>
Cc: Benoit Cousson <bcousson@baylibre.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Roger Quadros <rogerq@ti.com>,
Henrik Rydberg <rydberg@bitmath.org>,
Frodo Lai <frodo.lai@gmail.com>, Jingoo Han <jg1.han@samsung.com>,
<linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <linux-input@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt
Date: Wed, 22 Jul 2015 10:54:25 +0530 [thread overview]
Message-ID: <55AF2909.5090609@ti.com> (raw)
In-Reply-To: <20150720062407.GA13092@dtor-ws>
Hi Dmitry,
On 07/20/2015 11:54 AM, Dmitry Torokhov wrote:
> On Sun, Jul 19, 2015 at 11:09:30PM -0700, Tony Lindgren wrote:
>> * Vignesh R <vigneshr@ti.com> [150719 21:53]:
>>> @@ -445,6 +443,8 @@ static struct pixcir_ts_platform_data *pixcir_parse_dt(struct device *dev)
>>> dev_dbg(dev, "%s: x %d, y %d, gpio %d\n", __func__,
>>> pdata->x_max + 1, pdata->y_max + 1, pdata->gpio_attb);
>>>
>>> + pdata->wakeirq = of_irq_get_byname(dev->of_node, "wakeupirq");
>>> +
>>> return pdata;
>>
>> What about handling -EPROVE_DEFER here? At least pinctrl-single can be
>> be a loadable module for the dedicated wakeirqs.
>
> Right. I think we should only allow -ENODATA to continue and return
> error in all other cases.
-EINVAL will be returned if "interrupt-names" is not specified. I will
make execption for -ENODATA & -EINVAL, and return error in all other cases?
>
> Also, I think "irq" suffix on name is redundant.
Ok, will drop "irq" suffix:
+ interrupt-names = "tsc", "wakeup";
>
> Thanks.
>
--
Regards
Vignesh
next prev parent reply other threads:[~2015-07-22 5:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 4:50 [PATCH v2 0/2] pixcir_i2c_ts: Add optional wakeup irq support Vignesh R
2015-07-20 4:50 ` Vignesh R
2015-07-20 4:50 ` Vignesh R
2015-07-20 4:50 ` [PATCH v2 1/2] input: touchscreen: pixcir_i2c_ts: Add support for optional wakeup interrupt Vignesh R
2015-07-20 4:50 ` Vignesh R
2015-07-20 4:50 ` Vignesh R
[not found] ` <1437367814-27785-2-git-send-email-vigneshr-l0cyMroinI0@public.gmane.org>
2015-07-20 6:09 ` Tony Lindgren
2015-07-20 6:09 ` Tony Lindgren
2015-07-20 6:09 ` Tony Lindgren
2015-07-20 6:24 ` Dmitry Torokhov
2015-07-20 6:24 ` Dmitry Torokhov
2015-07-22 5:24 ` Vignesh R [this message]
2015-07-22 5:24 ` Vignesh R
2015-07-22 5:24 ` Vignesh R
2015-07-20 6:25 ` Dmitry Torokhov
2015-07-20 6:25 ` Dmitry Torokhov
2015-07-20 4:50 ` [PATCH v2 2/2] ARM: dts: AM437x-gp-evm: Add wakeup interrupt source for pixcir_i2c_tsc Vignesh R
2015-07-20 4:50 ` Vignesh R
2015-07-20 4:50 ` Vignesh R
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AF2909.5090609@ti.com \
--to=vigneshr@ti.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=frodo.lai@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jg1.han@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=rogerq@ti.com \
--cc=rydberg@bitmath.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.