* [review-request] adamian/bug_fixes @ 2015-07-24 17:10 Damian, Alexandru 2015-07-27 10:44 ` Barros Pena, Belen 2015-07-27 11:08 ` Barros Pena, Belen 0 siblings, 2 replies; 11+ messages in thread From: Damian, Alexandru @ 2015-07-24 17:10 UTC (permalink / raw) To: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 329 bytes --] Hi, This is a review request for adamian/bug_fixes <https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/bug_fixes> It contains a previously submitted patchset, and a fix for #7995 Please review and submit when possible. Cheers, Alex -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 1256 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-24 17:10 [review-request] adamian/bug_fixes Damian, Alexandru @ 2015-07-27 10:44 ` Barros Pena, Belen 2015-07-27 10:49 ` Damian, Alexandru 2015-07-27 11:08 ` Barros Pena, Belen 1 sibling, 1 reply; 11+ messages in thread From: Barros Pena, Belen @ 2015-07-27 10:44 UTC (permalink / raw) To: Damian, Alexandru, toaster@yoctoproject.org On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of alexandru.damian@intel.com> wrote: > > >Hi, > > >This is a review request for adamian/bug_fixes ><https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/bu >g_fixes> Hi Alex, I would like to have a look at the fix for 7995 and the issue with displaying builds in progress in the all builds table, but the branch you posted in based on BitBake, not poky, which makes it hard for me to test. Any chance you could post a branch based on poky? Thanks! Belén > > >It contains a previously submitted patchset, and a fix for #7995 > > >Please review and submit when possible. > > >Cheers, >Alex > > > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-27 10:44 ` Barros Pena, Belen @ 2015-07-27 10:49 ` Damian, Alexandru 0 siblings, 0 replies; 11+ messages in thread From: Damian, Alexandru @ 2015-07-27 10:49 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 1188 bytes --] Done, the branch is: adamian/20150727_bug_fixes_review Thank you, Alex On Mon, Jul 27, 2015 at 11:44 AM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of > Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of > alexandru.damian@intel.com> wrote: > > > > > > >Hi, > > > > > >This is a review request for adamian/bug_fixes > >< > https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/bu > >g_fixes> > > Hi Alex, > > I would like to have a look at the fix for 7995 and the issue with > displaying builds in progress in the all builds table, but the branch you > posted in based on BitBake, not poky, which makes it hard for me to test. > Any chance you could post a branch based on poky? > > Thanks! > > Belén > > > > > > >It contains a previously submitted patchset, and a fix for #7995 > > > > > >Please review and submit when possible. > > > > > >Cheers, > >Alex > > > > > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 2562 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-24 17:10 [review-request] adamian/bug_fixes Damian, Alexandru 2015-07-27 10:44 ` Barros Pena, Belen @ 2015-07-27 11:08 ` Barros Pena, Belen 2015-07-27 11:45 ` Damian, Alexandru 1 sibling, 1 reply; 11+ messages in thread From: Barros Pena, Belen @ 2015-07-27 11:08 UTC (permalink / raw) To: Damian, Alexandru, toaster@yoctoproject.org Thanks for the poky-based branch Alex! A couple of comments below. On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of alexandru.damian@intel.com> wrote: > > >Hi, > > >This is a review request for adamian/bug_fixes ><https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/bu >g_fixes> > > >It contains a previously submitted patchset, and a fix for #7995 bc4ea83f93657d876b43b751549735b683c33040 The builds in progress no longer show in the all builds page, but they still show in the project builds page. On the bright side, I know that because I can now reach the project builds page :) so the patch for 7995 works for me. Thanks! Belén > > >Please review and submit when possible. > > >Cheers, >Alex > > > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-27 11:08 ` Barros Pena, Belen @ 2015-07-27 11:45 ` Damian, Alexandru 2015-07-27 12:08 ` Barros Pena, Belen 0 siblings, 1 reply; 11+ messages in thread From: Damian, Alexandru @ 2015-07-27 11:45 UTC (permalink / raw) To: Barros Pena, Belen; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 1275 bytes --] Re-pushed the same branch with IN PROGRESS fixed applied to both build pages. Cheers, Alex On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen < belen.barros.pena@intel.com> wrote: > Thanks for the poky-based branch Alex! A couple of comments below. > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of > Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of > alexandru.damian@intel.com> wrote: > > > > > > >Hi, > > > > > >This is a review request for adamian/bug_fixes > >< > https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/bu > >g_fixes> > > > > > >It contains a previously submitted patchset, and a fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all builds page, but they > still show in the project builds page. > > On the bright side, I know that because I can now reach the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > > > > >Please review and submit when possible. > > > > > >Cheers, > >Alex > > > > > > > > > >-- > >Alex Damian > >Yocto Project > > > >SSG / OTC > > > > > > > > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 2547 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-27 11:45 ` Damian, Alexandru @ 2015-07-27 12:08 ` Barros Pena, Belen 2015-07-29 11:37 ` Michael Wood 0 siblings, 1 reply; 11+ messages in thread From: Barros Pena, Belen @ 2015-07-27 12:08 UTC (permalink / raw) To: Damian, Alexandru; +Cc: toaster@yoctoproject.org On 27/07/2015 12:45, "Damian, Alexandru" <alexandru.damian@intel.com> wrote: >Re-pushed the same branch with IN PROGRESS fixed applied to both build >pages. Now it seems to be working in both places. Thanks! Belén > > >Cheers, >Alex > > >On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen ><belen.barros.pena@intel.com> wrote: > >Thanks for the poky-based branch Alex! A couple of comments below. > >On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of >Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of >alexandru.damian@intel.com> wrote: > >> >> >>Hi, >> >> >>This is a review request for adamian/bug_fixes >><https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b >>u >>g_fixes> >> >> >>It contains a previously submitted patchset, and a fix for #7995 > > >bc4ea83f93657d876b43b751549735b683c33040 > >The builds in progress no longer show in the all builds page, but they >still show in the project builds page. > >On the bright side, I know that because I can now reach the project builds >page :) so the patch for 7995 works for me. > >Thanks! > >Belén > >> >> >>Please review and submit when possible. >> >> >>Cheers, >>Alex >> >> >> >> >>-- >>Alex Damian >>Yocto Project >> >>SSG / OTC >> >> >> > > > > > > > > > > >-- >Alex Damian >Yocto Project > >SSG / OTC > > > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-27 12:08 ` Barros Pena, Belen @ 2015-07-29 11:37 ` Michael Wood 2015-08-13 16:36 ` Damian, Alexandru 0 siblings, 1 reply; 11+ messages in thread From: Michael Wood @ 2015-07-29 11:37 UTC (permalink / raw) To: toaster On 27/07/15 13:08, Barros Pena, Belen wrote: > > On 27/07/2015 12:45, "Damian, Alexandru" <alexandru.damian@intel.com> > wrote: > >> Re-pushed the same branch with IN PROGRESS fixed applied to both build >> pages. > Now it seems to be working in both places. > > Thanks! > > Belén > >> >> Cheers, >> Alex >> >> >> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >> <belen.barros.pena@intel.com> wrote: >> >> Thanks for the poky-based branch Alex! A couple of comments below. >> >> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of >> Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of >> alexandru.damian@intel.com> wrote: >> >>> >>> Hi, >>> >>> >>> This is a review request for adamian/bug_fixes >>> <https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b >>> u >>> g_fixes> >>> >>> >>> It contains a previously submitted patchset, and a fix for #7995 >> >> bc4ea83f93657d876b43b751549735b683c33040 >> >> The builds in progress no longer show in the all builds page, but they >> still show in the project builds page. >> >> On the bright side, I know that because I can now reach the project builds >> page :) so the patch for 7995 works for me. >> >> Thanks! >> >> Belén >> >>> >>> Please review and submit when possible. >>> >>> >>> Cheers, >>> Alex >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> >>> SSG / OTC >>> >>> >>> >> >> >> >> >> >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 and 9cce8032cbb70f0047f5819127c0c220963f2ce2 a125f3ab34a82eb684c46d5f01ee3544535ab5f4 diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py b/lib/toaster/bldcontrol/management/commands/checksettings.py index 3858b9e..b2631c4 100644 --- a/lib/toaster/bldcontrol/management/commands/checksettings.py +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py @@ -99,10 +99,11 @@ class Command(NoArgsCommand): # find configuration files config_files = [] + selected_dirs = [] for dirname in self._recursive_list_directories(be.sourcedir,2): if os.path.exists(os.path.join(dirname, ".templateconf")): import subprocess - proc = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+r'; echo \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) + proc = subprocess.Popen('bash -c ". '+os.path.join(dirname, ".templateconf")+r'; echo \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) conffilepath, stderroroutput = proc.communicate() proc.wait() if proc.returncode != 0: @@ -114,6 +115,15 @@ class Command(NoArgsCommand): continue if os.path.exists(candidatefilepath): config_files.append(candidatefilepath) + selected_dirs.append(dirname) + + for dirname in self._recursive_list_directories(be.sourcedir,2): This for loop seems to be duplicated from the one above it checksettings.py (line 103 and 120) can they not be combined? However do we actually need to do all this searching? To simplify this couldn't we find "meta-yocto/conf/toasterconf.json" in the poky dir, if that doesn't exist then try the openembedded one, if that doesn't exist, ask? if people want to specify their own config we could have a -config option to bin/toaster. Thanks, Michael ^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-07-29 11:37 ` Michael Wood @ 2015-08-13 16:36 ` Damian, Alexandru 2015-08-14 16:01 ` Michael Wood 0 siblings, 1 reply; 11+ messages in thread From: Damian, Alexandru @ 2015-08-13 16:36 UTC (permalink / raw) To: Michael Wood; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 4326 bytes --] I pushed new version with the requested changes, rebased on the latest master. The branch is the same: adamian/bug_fixes Cheers, Alex On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood <michael.g.wood@intel.com> wrote: > On 27/07/15 13:08, Barros Pena, Belen wrote: > >> >> On 27/07/2015 12:45, "Damian, Alexandru" <alexandru.damian@intel.com> >> wrote: >> >> Re-pushed the same branch with IN PROGRESS fixed applied to both build >>> pages. >>> >> Now it seems to be working in both places. >> >> Thanks! >> >> Belén >> >> >>> Cheers, >>> Alex >>> >>> >>> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >>> <belen.barros.pena@intel.com> wrote: >>> >>> Thanks for the poky-based branch Alex! A couple of comments below. >>> >>> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org on behalf of >>> Damian, Alexandru" <toaster-bounces@yoctoproject.org on behalf of >>> alexandru.damian@intel.com> wrote: >>> >>> >>>> Hi, >>>> >>>> >>>> This is a review request for adamian/bug_fixes >>>> < >>>> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b >>>> u >>>> g_fixes> >>>> >>>> >>>> It contains a previously submitted patchset, and a fix for #7995 >>>> >>> >>> bc4ea83f93657d876b43b751549735b683c33040 >>> >>> The builds in progress no longer show in the all builds page, but they >>> still show in the project builds page. >>> >>> On the bright side, I know that because I can now reach the project >>> builds >>> page :) so the patch for 7995 works for me. >>> >>> Thanks! >>> >>> Belén >>> >>> >>>> Please review and submit when possible. >>>> >>>> >>>> Cheers, >>>> Alex >>>> >>>> >>>> >>>> >>>> -- >>>> Alex Damian >>>> Yocto Project >>>> >>>> SSG / OTC >>>> >>>> >>>> >>>> >>> >>> >>> >>> >>> >>> >>> >>> >>> -- >>> Alex Damian >>> Yocto Project >>> >>> SSG / OTC >>> >>> >>> >>> > > Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 and > 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo \"$TEMPLATECONF\""', > shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo \"\$TEMPLATECONF\""', > shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To simplify this > couldn't we find "meta-yocto/conf/toasterconf.json" in the poky dir, if > that doesn't exist then try the openembedded one, if that doesn't exist, > ask? if people want to specify their own config we could have a -config > option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org > https://lists.yoctoproject.org/listinfo/toaster > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 6713 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-08-13 16:36 ` Damian, Alexandru @ 2015-08-14 16:01 ` Michael Wood 2015-08-17 11:19 ` Damian, Alexandru 0 siblings, 1 reply; 11+ messages in thread From: Michael Wood @ 2015-08-14 16:01 UTC (permalink / raw) To: Damian, Alexandru; +Cc: toaster@yoctoproject.org The branch fails the unit tests because you've removed a used import in d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 Could future branches be based on poky please as it's easier for me to do testing. Thanks, Michael On 13/08/15 17:36, Damian, Alexandru wrote: > I pushed new version with the requested changes, rebased on the latest > master. > > The branch is the same: > > adamian/bug_fixes > > Cheers, > Alex > > > On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com>> wrote: > > On 27/07/15 13:08, Barros Pena, Belen wrote: > > > On 27/07/2015 12:45, "Damian, Alexandru" > <alexandru.damian@intel.com <mailto:alexandru.damian@intel.com>> > wrote: > > Re-pushed the same branch with IN PROGRESS fixed applied > to both build > pages. > > Now it seems to be working in both places. > > Thanks! > > Belén > > > Cheers, > Alex > > > On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen > <belen.barros.pena@intel.com > <mailto:belen.barros.pena@intel.com>> wrote: > > Thanks for the poky-based branch Alex! A couple of > comments below. > > On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org> on behalf of > Damian, Alexandru" <toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org> on behalf of > alexandru.damian@intel.com > <mailto:alexandru.damian@intel.com>> wrote: > > > Hi, > > > This is a review request for adamian/bug_fixes > <https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b > u > g_fixes> > > > It contains a previously submitted patchset, and a > fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all builds > page, but they > still show in the project builds page. > > On the bright side, I know that because I can now reach > the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > Please review and submit when possible. > > > Cheers, > Alex > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 > and 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git > a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in > self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, > ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in > self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To simplify > this couldn't we find "meta-yocto/conf/toasterconf.json" in the > poky dir, if that doesn't exist then try the openembedded one, if > that doesn't exist, ask? if people want to specify their own > config we could have a -config option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- > _______________________________________________ > toaster mailing list > toaster@yoctoproject.org <mailto:toaster@yoctoproject.org> > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-08-14 16:01 ` Michael Wood @ 2015-08-17 11:19 ` Damian, Alexandru 2015-08-18 16:39 ` Michael Wood 0 siblings, 1 reply; 11+ messages in thread From: Damian, Alexandru @ 2015-08-17 11:19 UTC (permalink / raw) To: Michael Wood; +Cc: toaster@yoctoproject.org [-- Attachment #1: Type: text/plain, Size: 7089 bytes --] Hi, Yep, I made a merge mistake. I fixed the issue and rebased everything on top of poky. adamian/20150817_bug_fixes_poky Can you please review and merge ? Cheers, Alex On Fri, Aug 14, 2015 at 5:01 PM, Michael Wood <michael.g.wood@intel.com> wrote: > The branch fails the unit tests because you've removed a used import in > d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 > > Could future branches be based on poky please as it's easier for me to do > testing. > > Thanks, > > Michael > > On 13/08/15 17:36, Damian, Alexandru wrote: > >> I pushed new version with the requested changes, rebased on the latest >> master. >> >> The branch is the same: >> >> adamian/bug_fixes >> >> Cheers, >> Alex >> >> >> On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood <michael.g.wood@intel.com >> <mailto:michael.g.wood@intel.com>> wrote: >> >> On 27/07/15 13:08, Barros Pena, Belen wrote: >> >> >> On 27/07/2015 12:45, "Damian, Alexandru" >> <alexandru.damian@intel.com <mailto:alexandru.damian@intel.com>> >> wrote: >> >> Re-pushed the same branch with IN PROGRESS fixed applied >> to both build >> pages. >> >> Now it seems to be working in both places. >> >> Thanks! >> >> Belén >> >> >> Cheers, >> Alex >> >> >> On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen >> <belen.barros.pena@intel.com >> <mailto:belen.barros.pena@intel.com>> wrote: >> >> Thanks for the poky-based branch Alex! A couple of >> comments below. >> >> On 24/07/2015 18:10, "toaster-bounces@yoctoproject.org >> <mailto:toaster-bounces@yoctoproject.org> on behalf of >> Damian, Alexandru" <toaster-bounces@yoctoproject.org >> <mailto:toaster-bounces@yoctoproject.org> on behalf of >> alexandru.damian@intel.com >> >> <mailto:alexandru.damian@intel.com>> wrote: >> >> >> Hi, >> >> >> This is a review request for adamian/bug_fixes >> < >> https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b >> u >> g_fixes> >> >> >> It contains a previously submitted patchset, and a >> fix for #7995 >> >> >> bc4ea83f93657d876b43b751549735b683c33040 >> >> The builds in progress no longer show in the all builds >> page, but they >> still show in the project builds page. >> >> On the bright side, I know that because I can now reach >> the project builds >> page :) so the patch for 7995 works for me. >> >> Thanks! >> >> Belén >> >> >> Please review and submit when possible. >> >> >> Cheers, >> Alex >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> >> >> >> >> >> >> >> >> >> >> -- Alex Damian >> Yocto Project >> >> SSG / OTC >> >> >> >> >> >> Can you squash these two: ba72e1666796987bdec1bbf34d31a41ecf605936 >> and 9cce8032cbb70f0047f5819127c0c220963f2ce2 >> >> >> >> a125f3ab34a82eb684c46d5f01ee3544535ab5f4 >> >> >> >> diff --git >> a/lib/toaster/bldcontrol/management/commands/checksettings.py >> b/lib/toaster/bldcontrol/management/commands/checksettings.py >> index 3858b9e..b2631c4 100644 >> --- a/lib/toaster/bldcontrol/management/commands/checksettings.py >> +++ b/lib/toaster/bldcontrol/management/commands/checksettings.py >> @@ -99,10 +99,11 @@ class Command(NoArgsCommand): >> # find configuration files >> config_files = [] >> + selected_dirs = [] >> for dirname in >> self._recursive_list_directories(be.sourcedir,2): >> if os.path.exists(os.path.join(dirname, >> ".templateconf")): >> import subprocess >> - proc = subprocess.Popen('bash -c ". >> '+os.path.join(dirname, ".templateconf")+r'; echo >> \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) >> + proc = subprocess.Popen('bash -c ". >> '+os.path.join(dirname, ".templateconf")+r'; echo >> \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) >> conffilepath, stderroroutput = proc.communicate() >> proc.wait() >> if proc.returncode != 0: >> @@ -114,6 +115,15 @@ class Command(NoArgsCommand): >> continue >> if os.path.exists(candidatefilepath): >> config_files.append(candidatefilepath) >> + selected_dirs.append(dirname) >> + >> + for dirname in >> self._recursive_list_directories(be.sourcedir,2): >> >> >> This for loop seems to be duplicated from the one above it >> checksettings.py (line 103 and 120) can they not be combined? >> However do we actually need to do all this searching? To simplify >> this couldn't we find "meta-yocto/conf/toasterconf.json" in the >> poky dir, if that doesn't exist then try the openembedded one, if >> that doesn't exist, ask? if people want to specify their own >> config we could have a -config option to bin/toaster. >> >> Thanks, >> >> Michael >> >> >> >> >> >> >> >> -- _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org <mailto:toaster@yoctoproject.org> >> https://lists.yoctoproject.org/listinfo/toaster >> >> >> >> >> -- >> Alex Damian >> Yocto Project >> SSG / OTC >> >> --------------------------------------------------------------------- >> Intel Corporation (UK) Limited >> Registered No. 1134945 (England) >> Registered Office: Pipers Way, Swindon SN3 1RJ >> VAT No: 860 2173 47 >> >> This e-mail and any attachments may contain confidential material for >> the sole use of the intended recipient(s). Any review or distribution >> by others is strictly prohibited. If you are not the intended >> recipient, please contact the sender and delete all copies. >> >> > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > -- Alex Damian Yocto Project SSG / OTC [-- Attachment #2: Type: text/html, Size: 10393 bytes --] ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [review-request] adamian/bug_fixes 2015-08-17 11:19 ` Damian, Alexandru @ 2015-08-18 16:39 ` Michael Wood 0 siblings, 0 replies; 11+ messages in thread From: Michael Wood @ 2015-08-18 16:39 UTC (permalink / raw) To: Damian, Alexandru; +Cc: toaster@yoctoproject.org Submitted upstream With the exception of ad0470144bcfb19065fa90512bd533754bd26a28 toaster: refactor checksettings.pyThat patch caused the toasterconf.json not to be found and had conflicts when rebased on master so was omitted. Thanks, Michael On 17/08/15 12:19, Damian, Alexandru wrote: > Hi, > > Yep, I made a merge mistake. I fixed the issue and rebased everything > on top of poky. > > adamian/20150817_bug_fixes_poky > > Can you please review and merge ? > > Cheers, > Alex > > On Fri, Aug 14, 2015 at 5:01 PM, Michael Wood > <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com>> wrote: > > The branch fails the unit tests because you've removed a used > import in d73cc179f3e12a3d3b33a6b0c3884bcea9be84a3 > > Could future branches be based on poky please as it's easier for > me to do testing. > > Thanks, > > Michael > > On 13/08/15 17:36, Damian, Alexandru wrote: > > I pushed new version with the requested changes, rebased on > the latest master. > > The branch is the same: > > adamian/bug_fixes > > Cheers, > Alex > > > On Wed, Jul 29, 2015 at 12:37 PM, Michael Wood > <michael.g.wood@intel.com <mailto:michael.g.wood@intel.com> > <mailto:michael.g.wood@intel.com > <mailto:michael.g.wood@intel.com>>> wrote: > > On 27/07/15 13:08, Barros Pena, Belen wrote: > > > On 27/07/2015 12:45, "Damian, Alexandru" > <alexandru.damian@intel.com > <mailto:alexandru.damian@intel.com> > <mailto:alexandru.damian@intel.com > <mailto:alexandru.damian@intel.com>>> > wrote: > > Re-pushed the same branch with IN PROGRESS fixed > applied > to both build > pages. > > Now it seems to be working in both places. > > Thanks! > > Belén > > > Cheers, > Alex > > > On Mon, Jul 27, 2015 at 12:08 PM, Barros Pena, Belen > <belen.barros.pena@intel.com > <mailto:belen.barros.pena@intel.com> > <mailto:belen.barros.pena@intel.com > <mailto:belen.barros.pena@intel.com>>> wrote: > > Thanks for the poky-based branch Alex! A couple of > comments below. > > On 24/07/2015 18:10, > "toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org> > <mailto:toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org>> on behalf of > Damian, Alexandru" > <toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org> > <mailto:toaster-bounces@yoctoproject.org > <mailto:toaster-bounces@yoctoproject.org>> on behalf of > alexandru.damian@intel.com <mailto:alexandru.damian@intel.com> > > <mailto:alexandru.damian@intel.com > <mailto:alexandru.damian@intel.com>>> wrote: > > > Hi, > > > This is a review request for adamian/bug_fixes > > <https://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=adamian/b > u > g_fixes> > > > It contains a previously submitted patchset, > and a > fix for #7995 > > > bc4ea83f93657d876b43b751549735b683c33040 > > The builds in progress no longer show in the all > builds > page, but they > still show in the project builds page. > > On the bright side, I know that because I can now > reach > the project builds > page :) so the patch for 7995 works for me. > > Thanks! > > Belén > > > Please review and submit when possible. > > > Cheers, > Alex > > > > > -- > Alex Damian > Yocto Project > > SSG / OTC > > > > > > > > > > > > > -- Alex Damian > Yocto Project > > SSG / OTC > > > > > > Can you squash these two: > ba72e1666796987bdec1bbf34d31a41ecf605936 > and 9cce8032cbb70f0047f5819127c0c220963f2ce2 > > > > a125f3ab34a82eb684c46d5f01ee3544535ab5f4 > > > > diff --git > a/lib/toaster/bldcontrol/management/commands/checksettings.py > b/lib/toaster/bldcontrol/management/commands/checksettings.py > index 3858b9e..b2631c4 100644 > --- > a/lib/toaster/bldcontrol/management/commands/checksettings.py > +++ > b/lib/toaster/bldcontrol/management/commands/checksettings.py > @@ -99,10 +99,11 @@ class Command(NoArgsCommand): > # find configuration files > config_files = [] > + selected_dirs = [] > for dirname in > self._recursive_list_directories(be.sourcedir,2): > if os.path.exists(os.path.join(dirname, > ".templateconf")): > import subprocess > - proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > + proc = subprocess.Popen('bash -c ". > '+os.path.join(dirname, ".templateconf")+r'; echo > \"\$TEMPLATECONF\""', shell=True, stdout=subprocess.PIPE) > conffilepath, stderroroutput = > proc.communicate() > proc.wait() > if proc.returncode != 0: > @@ -114,6 +115,15 @@ class Command(NoArgsCommand): > continue > if os.path.exists(candidatefilepath): > config_files.append(candidatefilepath) > + selected_dirs.append(dirname) > + > + for dirname in > self._recursive_list_directories(be.sourcedir,2): > > > This for loop seems to be duplicated from the one above it > checksettings.py (line 103 and 120) can they not be combined? > However do we actually need to do all this searching? To > simplify > this couldn't we find "meta-yocto/conf/toasterconf.json" > in the > poky dir, if that doesn't exist then try the openembedded > one, if > that doesn't exist, ask? if people want to specify their own > config we could have a -config option to bin/toaster. > > Thanks, > > Michael > > > > > > > > -- _______________________________________________ > toaster mailing list > toaster@yoctoproject.org <mailto:toaster@yoctoproject.org> > <mailto:toaster@yoctoproject.org > <mailto:toaster@yoctoproject.org>> > https://lists.yoctoproject.org/listinfo/toaster > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential > material for > the sole use of the intended recipient(s). Any review or > distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > > > > > -- > Alex Damian > Yocto Project > SSG / OTC > > --------------------------------------------------------------------- > Intel Corporation (UK) Limited > Registered No. 1134945 (England) > Registered Office: Pipers Way, Swindon SN3 1RJ > VAT No: 860 2173 47 > > This e-mail and any attachments may contain confidential material for > the sole use of the intended recipient(s). Any review or distribution > by others is strictly prohibited. If you are not the intended > recipient, please contact the sender and delete all copies. > ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2015-08-18 16:40 UTC | newest] Thread overview: 11+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-24 17:10 [review-request] adamian/bug_fixes Damian, Alexandru 2015-07-27 10:44 ` Barros Pena, Belen 2015-07-27 10:49 ` Damian, Alexandru 2015-07-27 11:08 ` Barros Pena, Belen 2015-07-27 11:45 ` Damian, Alexandru 2015-07-27 12:08 ` Barros Pena, Belen 2015-07-29 11:37 ` Michael Wood 2015-08-13 16:36 ` Damian, Alexandru 2015-08-14 16:01 ` Michael Wood 2015-08-17 11:19 ` Damian, Alexandru 2015-08-18 16:39 ` Michael Wood
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.