From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>, "Kalle Valo" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: [PATCH] b43: fix extpa_gain check for 2GHz
Date: Thu, 30 Jul 2015 19:34:28 +0200 [thread overview]
Message-ID: <55BA6024.4000307@hauke-m.de> (raw)
In-Reply-To: <CACna6rySwFsFhSjRgyw_oVk3BX9sSHu81rPTusmGujOveehbiA@mail.gmail.com>
On 07/30/2015 08:54 AM, Rafa? Mi?ecki wrote:
> On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>> the 5GHz band was checked. this patch makes it check the property from
>>> the correct band.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>
>> Is this a regression? If yes, please add a Fixes line.
>>
>> Should this go to 4.2?
>
> Not a regression. It's like this for a loooong time.
>
> AFAIK PCI(e) cards don't have external power amplifier, so this code
> is most likely used for some fancy SoCs only. There are 3 known SoCs
> with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
>
> So we may consider taking it for 4.2 without any "Fixes: " line but I
> wouldn't care too much about Cc-ing stable.
>
> Hauke: do you agree?
>
Yes, I do not have a device I know of which is affected by this error, I
just saw this while looking at code close by. Just put this into the
next Linux version and not to stable.
Hauke
WARNING: multiple messages have this Message-ID (diff)
From: Hauke Mehrtens <hauke@hauke-m.de>
To: "Rafał Miłecki" <zajec5@gmail.com>, "Kalle Valo" <kvalo@codeaurora.org>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
b43-dev <b43-dev@lists.infradead.org>
Subject: Re: [PATCH] b43: fix extpa_gain check for 2GHz
Date: Thu, 30 Jul 2015 19:34:28 +0200 [thread overview]
Message-ID: <55BA6024.4000307@hauke-m.de> (raw)
In-Reply-To: <CACna6rySwFsFhSjRgyw_oVk3BX9sSHu81rPTusmGujOveehbiA@mail.gmail.com>
On 07/30/2015 08:54 AM, Rafał Miłecki wrote:
> On 30 July 2015 at 07:40, Kalle Valo <kvalo@codeaurora.org> wrote:
>> Hauke Mehrtens <hauke@hauke-m.de> writes:
>>
>>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from
>>> the 5GHz band was checked. this patch makes it check the property from
>>> the correct band.
>>>
>>> Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
>>
>> Is this a regression? If yes, please add a Fixes line.
>>
>> Should this go to 4.2?
>
> Not a regression. It's like this for a loooong time.
>
> AFAIK PCI(e) cards don't have external power amplifier, so this code
> is most likely used for some fancy SoCs only. There are 3 known SoCs
> with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0.
>
> So we may consider taking it for 4.2 without any "Fixes: " line but I
> wouldn't care too much about Cc-ing stable.
>
> Hauke: do you agree?
>
Yes, I do not have a device I know of which is affected by this error, I
just saw this while looking at code close by. Just put this into the
next Linux version and not to stable.
Hauke
next prev parent reply other threads:[~2015-07-30 17:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 21:36 [PATCH] b43: fix extpa_gain check for 2GHz Hauke Mehrtens
2015-07-30 1:13 ` Rafał Miłecki
2015-07-30 1:13 ` Rafał Miłecki
2015-07-30 5:40 ` Kalle Valo
2015-07-30 5:40 ` Kalle Valo
2015-07-30 6:54 ` Rafał Miłecki
2015-07-30 6:54 ` Rafał Miłecki
2015-07-30 17:34 ` Hauke Mehrtens [this message]
2015-07-30 17:34 ` Hauke Mehrtens
2015-07-31 6:10 ` Kalle Valo
2015-07-31 6:10 ` Kalle Valo
2015-07-31 6:24 ` Kalle Valo
2015-07-31 6:24 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA6024.4000307@hauke-m.de \
--to=hauke@hauke-m.de \
--cc=b43-dev@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.