* [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-01-15 12:33 ` Bart Tanghe 0 siblings, 0 replies; 7+ messages in thread From: Bart Tanghe @ 2015-01-15 12:33 UTC (permalink / raw) To: linux-arm-kernel To probe the bcm2835-pwm driver properly, this dts bindings has to be added to the bcm2835 dtsi file. In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. --- Changes in v4: - node added by reg value Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> Acked-by: Stephen Warren <swarren@wwwdotorg.org> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi index 3342cb1..e8a0f13 100644 --- a/arch/arm/boot/dts/bcm2835.dtsi +++ b/arch/arm/boot/dts/bcm2835.dtsi @@ -122,6 +123,14 @@ status = "disabled"; }; + pwm: pwm at 7e20c000 { + compatible = "brcm,bcm2835-pwm"; + reg = <0x7e20c000 0x28>; + clocks = <&clk_pwm>; + #pwm-cells = <2>; + status = "disabled"; + }; + sdhci: sdhci at 7e300000 { compatible = "brcm,bcm2835-sdhci"; reg = <0x7e300000 0x100>; @@ -179,5 +188,13 @@ clock-output-names = "spi"; clock-frequency = <250000000>; }; + + clk_pwm: clock at 3 { + compatible = "fixed-clock"; + reg = <3>; + #clock-cells = <0>; + clock-output-names = "pwm"; + clock-frequency = <9200000>; + }; }; }; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-01-15 12:33 ` Bart Tanghe 0 siblings, 0 replies; 7+ messages in thread From: Bart Tanghe @ 2015-01-15 12:33 UTC (permalink / raw) To: swarren, lee Cc: thierry.reding, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, devicetree, linux-arm-kernel, linux-rpi-kernel, linux-kernel, Bart Tanghe To probe the bcm2835-pwm driver properly, this dts bindings has to be added to the bcm2835 dtsi file. In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. --- Changes in v4: - node added by reg value Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> Acked-by: Stephen Warren <swarren@wwwdotorg.org> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi index 3342cb1..e8a0f13 100644 --- a/arch/arm/boot/dts/bcm2835.dtsi +++ b/arch/arm/boot/dts/bcm2835.dtsi @@ -122,6 +123,14 @@ status = "disabled"; }; + pwm: pwm@7e20c000 { + compatible = "brcm,bcm2835-pwm"; + reg = <0x7e20c000 0x28>; + clocks = <&clk_pwm>; + #pwm-cells = <2>; + status = "disabled"; + }; + sdhci: sdhci@7e300000 { compatible = "brcm,bcm2835-sdhci"; reg = <0x7e300000 0x100>; @@ -179,5 +188,13 @@ clock-output-names = "spi"; clock-frequency = <250000000>; }; + + clk_pwm: clock@3 { + compatible = "fixed-clock"; + reg = <3>; + #clock-cells = <0>; + clock-output-names = "pwm"; + clock-frequency = <9200000>; + }; }; }; ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-01-15 12:33 ` Bart Tanghe 0 siblings, 0 replies; 7+ messages in thread From: Bart Tanghe @ 2015-01-15 12:33 UTC (permalink / raw) To: swarren-3lzwWm7+Weoh9ZMKESR00Q, lee-DgEjT+Ai2ygdnm+yROfE0A Cc: thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA, Bart Tanghe To probe the bcm2835-pwm driver properly, this dts bindings has to be added to the bcm2835 dtsi file. In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. --- Changes in v4: - node added by reg value Signed-off-by: Bart Tanghe <bart.tanghe-2dq7lIxLGp5qkBXjtECzWg@public.gmane.org> Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi index 3342cb1..e8a0f13 100644 --- a/arch/arm/boot/dts/bcm2835.dtsi +++ b/arch/arm/boot/dts/bcm2835.dtsi @@ -122,6 +123,14 @@ status = "disabled"; }; + pwm: pwm@7e20c000 { + compatible = "brcm,bcm2835-pwm"; + reg = <0x7e20c000 0x28>; + clocks = <&clk_pwm>; + #pwm-cells = <2>; + status = "disabled"; + }; + sdhci: sdhci@7e300000 { compatible = "brcm,bcm2835-sdhci"; reg = <0x7e300000 0x100>; @@ -179,5 +188,13 @@ clock-output-names = "spi"; clock-frequency = <250000000>; }; + + clk_pwm: clock@3 { + compatible = "fixed-clock"; + reg = <3>; + #clock-cells = <0>; + clock-output-names = "pwm"; + clock-frequency = <9200000>; + }; }; }; -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-02-25 14:50 ` Lee Jones 0 siblings, 0 replies; 7+ messages in thread From: Lee Jones @ 2015-02-25 14:50 UTC (permalink / raw) To: linux-arm-kernel On Thu, 15 Jan 2015, Bart Tanghe wrote: > To probe the bcm2835-pwm driver properly, this dts bindings has to be added > to the bcm2835 dtsi file. > In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. > --- > Changes in v4: > - node added by reg value > > Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> Applied, thanks. > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > index 3342cb1..e8a0f13 100644 > --- a/arch/arm/boot/dts/bcm2835.dtsi > +++ b/arch/arm/boot/dts/bcm2835.dtsi > @@ -122,6 +123,14 @@ > status = "disabled"; > }; > > + pwm: pwm at 7e20c000 { > + compatible = "brcm,bcm2835-pwm"; > + reg = <0x7e20c000 0x28>; > + clocks = <&clk_pwm>; > + #pwm-cells = <2>; > + status = "disabled"; > + }; > + > sdhci: sdhci at 7e300000 { > compatible = "brcm,bcm2835-sdhci"; > reg = <0x7e300000 0x100>; > @@ -179,5 +188,13 @@ > clock-output-names = "spi"; > clock-frequency = <250000000>; > }; > + > + clk_pwm: clock at 3 { > + compatible = "fixed-clock"; > + reg = <3>; > + #clock-cells = <0>; > + clock-output-names = "pwm"; > + clock-frequency = <9200000>; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-02-25 14:50 ` Lee Jones 0 siblings, 0 replies; 7+ messages in thread From: Lee Jones @ 2015-02-25 14:50 UTC (permalink / raw) To: Bart Tanghe Cc: swarren, lee, thierry.reding, robh+dt, pawel.moll, mark.rutland, ijc+devicetree, galak, linux, devicetree, linux-arm-kernel, linux-rpi-kernel, linux-kernel On Thu, 15 Jan 2015, Bart Tanghe wrote: > To probe the bcm2835-pwm driver properly, this dts bindings has to be added > to the bcm2835 dtsi file. > In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. > --- > Changes in v4: > - node added by reg value > > Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> > Acked-by: Stephen Warren <swarren@wwwdotorg.org> Applied, thanks. > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > index 3342cb1..e8a0f13 100644 > --- a/arch/arm/boot/dts/bcm2835.dtsi > +++ b/arch/arm/boot/dts/bcm2835.dtsi > @@ -122,6 +123,14 @@ > status = "disabled"; > }; > > + pwm: pwm@7e20c000 { > + compatible = "brcm,bcm2835-pwm"; > + reg = <0x7e20c000 0x28>; > + clocks = <&clk_pwm>; > + #pwm-cells = <2>; > + status = "disabled"; > + }; > + > sdhci: sdhci@7e300000 { > compatible = "brcm,bcm2835-sdhci"; > reg = <0x7e300000 0x100>; > @@ -179,5 +188,13 @@ > clock-output-names = "spi"; > clock-frequency = <250000000>; > }; > + > + clk_pwm: clock@3 { > + compatible = "fixed-clock"; > + reg = <3>; > + #clock-cells = <0>; > + clock-output-names = "pwm"; > + clock-frequency = <9200000>; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v4] ARM: dts: add bcm2835-pwm bindings @ 2015-02-25 14:50 ` Lee Jones 0 siblings, 0 replies; 7+ messages in thread From: Lee Jones @ 2015-02-25 14:50 UTC (permalink / raw) To: Bart Tanghe Cc: swarren-3lzwWm7+Weoh9ZMKESR00Q, lee-DgEjT+Ai2ygdnm+yROfE0A, thierry.reding-Re5JQEeQqe8AvxtiuMwx3w, robh+dt-DgEjT+Ai2ygdnm+yROfE0A, pawel.moll-5wv7dgnIgG8, mark.rutland-5wv7dgnIgG8, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg, galak-sgV2jX0FEOL9JmXXK+q4OQ, linux-lFZ/pmaqli7XmaaqVzeoHQ, devicetree-u79uwXL29TY76Z2rM5mHXA, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-kernel-u79uwXL29TY76Z2rM5mHXA On Thu, 15 Jan 2015, Bart Tanghe wrote: > To probe the bcm2835-pwm driver properly, this dts bindings has to be added > to the bcm2835 dtsi file. > In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. > --- > Changes in v4: > - node added by reg value > > Signed-off-by: Bart Tanghe <bart.tanghe-2dq7lIxLGp5qkBXjtECzWg@public.gmane.org> > Acked-by: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org> Applied, thanks. > diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi > index 3342cb1..e8a0f13 100644 > --- a/arch/arm/boot/dts/bcm2835.dtsi > +++ b/arch/arm/boot/dts/bcm2835.dtsi > @@ -122,6 +123,14 @@ > status = "disabled"; > }; > > + pwm: pwm@7e20c000 { > + compatible = "brcm,bcm2835-pwm"; > + reg = <0x7e20c000 0x28>; > + clocks = <&clk_pwm>; > + #pwm-cells = <2>; > + status = "disabled"; > + }; > + > sdhci: sdhci@7e300000 { > compatible = "brcm,bcm2835-sdhci"; > reg = <0x7e300000 0x100>; > @@ -179,5 +188,13 @@ > clock-output-names = "spi"; > clock-frequency = <250000000>; > }; > + > + clk_pwm: clock@3 { > + compatible = "fixed-clock"; > + reg = <3>; > + #clock-cells = <0>; > + clock-output-names = "pwm"; > + clock-frequency = <9200000>; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v4] ARM: dts: add bcm2835-pwm bindings 2015-02-25 14:50 ` Lee Jones (?) (?) @ 2015-07-31 15:12 ` mishal -1 siblings, 0 replies; 7+ messages in thread From: mishal @ 2015-07-31 15:12 UTC (permalink / raw) To: linux-arm-kernel Tried with latest rpi kernel from github, branch rpi-4.0.y on RaspberryPi A+ on pins 18 and 19 pwm_pins: pwm { brcm,pins = <18 19>; brcm,function = <2 2>; /* alt5*/ }; and pins 12, 13 pwm_pins: pwm { brcm,pins = <12 13>; brcm,function = <4 4>; /* alt0*/ }; different combinations for period/duty_cycle without any output. (WiringPi library works on pins 18 and 12.) Did something changed in recent kernels? Thank you. On 25.02.15 16:50, Lee Jones wrote: > On Thu, 15 Jan 2015, Bart Tanghe wrote: > >> To probe the bcm2835-pwm driver properly, this dts bindings has to be added >> to the bcm2835 dtsi file. >> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding. >> --- >> Changes in v4: >> - node added by reg value >> >> Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be> >> Acked-by: Stephen Warren <swarren@wwwdotorg.org> > Applied, thanks. > >> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi >> index 3342cb1..e8a0f13 100644 >> --- a/arch/arm/boot/dts/bcm2835.dtsi >> +++ b/arch/arm/boot/dts/bcm2835.dtsi >> @@ -122,6 +123,14 @@ >> status = "disabled"; >> }; >> >> + pwm: pwm at 7e20c000 { >> + compatible = "brcm,bcm2835-pwm"; >> + reg = <0x7e20c000 0x28>; >> + clocks = <&clk_pwm>; >> + #pwm-cells = <2>; >> + status = "disabled"; >> + }; >> + >> sdhci: sdhci at 7e300000 { >> compatible = "brcm,bcm2835-sdhci"; >> reg = <0x7e300000 0x100>; >> @@ -179,5 +188,13 @@ >> clock-output-names = "spi"; >> clock-frequency = <250000000>; >> }; >> + >> + clk_pwm: clock at 3 { >> + compatible = "fixed-clock"; >> + reg = <3>; >> + #clock-cells = <0>; >> + clock-output-names = "pwm"; >> + clock-frequency = <9200000>; >> + }; >> }; >> }; ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-07-31 15:12 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-15 12:33 [PATCH v4] ARM: dts: add bcm2835-pwm bindings Bart Tanghe 2015-01-15 12:33 ` Bart Tanghe 2015-01-15 12:33 ` Bart Tanghe 2015-02-25 14:50 ` Lee Jones 2015-02-25 14:50 ` Lee Jones 2015-02-25 14:50 ` Lee Jones 2015-07-31 15:12 ` mishal
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.