All of lore.kernel.org
 help / color / mirror / Atom feed
From: roopa <roopa@cumulusnetworks.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Robert Shearman <rshearma@brocade.com>,
	Tom Herbert <tom@herbertland.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev()
Date: Tue, 04 Aug 2015 13:40:21 +0000	[thread overview]
Message-ID: <55C0C0C5.1040901@cumulusnetworks.com> (raw)
In-Reply-To: <20150804074422.GB10867@mwanda>

On 8/4/15, 12:44 AM, Dan Carpenter wrote:
> We recently changed this code from returning NULL to returning ERR_PTR.
> There are some left over NULL assignments which we can remove.  We can
> preserve the error code from ip_route_output() instead of always
> returning -ENODEV.  Also these functions use a mix of gotos and direct
> returns.  There is no cleanup necessary so I changed the gotos to
> direct returns.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>

WARNING: multiple messages have this Message-ID (diff)
From: roopa <roopa@cumulusnetworks.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Robert Shearman <rshearma@brocade.com>,
	Tom Herbert <tom@herbertland.com>,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev()
Date: Tue, 04 Aug 2015 06:40:21 -0700	[thread overview]
Message-ID: <55C0C0C5.1040901@cumulusnetworks.com> (raw)
In-Reply-To: <20150804074422.GB10867@mwanda>

On 8/4/15, 12:44 AM, Dan Carpenter wrote:
> We recently changed this code from returning NULL to returning ERR_PTR.
> There are some left over NULL assignments which we can remove.  We can
> preserve the error code from ip_route_output() instead of always
> returning -ENODEV.  Also these functions use a mix of gotos and direct
> returns.  There is no cleanup necessary so I changed the gotos to
> direct returns.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Acked-by: Roopa Prabhu <roopa@cumulusnetworks.com>

  reply	other threads:[~2015-08-04 13:40 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04  7:44 [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev() Dan Carpenter
2015-08-04  7:44 ` Dan Carpenter
2015-08-04 13:40 ` roopa [this message]
2015-08-04 13:40   ` roopa
2015-08-04 13:53 ` Robert Shearman
2015-08-04 13:53   ` Robert Shearman
2015-08-07  4:57 ` David Miller
2015-08-07  4:57   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C0C0C5.1040901@cumulusnetworks.com \
    --to=roopa@cumulusnetworks.com \
    --cc=dan.carpenter@oracle.com \
    --cc=davem@davemloft.net \
    --cc=ebiederm@xmission.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rshearma@brocade.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.