From: Dave Hansen <dave.hansen@intel.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com,
sasha.levin@oracle.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: add the block to the tail of the list in expand()
Date: Wed, 05 Aug 2015 07:47:07 -0700 [thread overview]
Message-ID: <55C221EB.7060500@intel.com> (raw)
In-Reply-To: <55C1C132.2010805@huawei.com>
On 08/05/2015 12:54 AM, Xishi Qiu wrote:
> I add some debug code like this, but it doesn't trigger the dump_stack().
...
> + if (!list_empty(&area->free_list[migratetype])) {
> + printk("expand(), the list is not empty\n");
> + dump_stack();
> + }
> +
That will probably not trigger unless you have allocations that are
falling back and converting other pageblocks from other migratetypes.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>, Vlastimil Babka <vbabka@suse.cz>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.cz>,
iamjoonsoo.kim@lge.com, alexander.h.duyck@redhat.com,
sasha.levin@oracle.com, Linux MM <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: add the block to the tail of the list in expand()
Date: Wed, 05 Aug 2015 07:47:07 -0700 [thread overview]
Message-ID: <55C221EB.7060500@intel.com> (raw)
In-Reply-To: <55C1C132.2010805@huawei.com>
On 08/05/2015 12:54 AM, Xishi Qiu wrote:
> I add some debug code like this, but it doesn't trigger the dump_stack().
...
> + if (!list_empty(&area->free_list[migratetype])) {
> + printk("expand(), the list is not empty\n");
> + dump_stack();
> + }
> +
That will probably not trigger unless you have allocations that are
falling back and converting other pageblocks from other migratetypes.
next prev parent reply other threads:[~2015-08-05 14:50 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 9:30 [PATCH] mm: add the block to the tail of the list in expand() Xishi Qiu
2015-07-31 9:30 ` Xishi Qiu
2015-07-31 23:24 ` Dave Hansen
2015-07-31 23:24 ` Dave Hansen
2015-08-03 2:05 ` Xishi Qiu
2015-08-03 2:05 ` Xishi Qiu
2015-08-03 4:10 ` Dave Hansen
2015-08-03 4:10 ` Dave Hansen
2015-08-04 1:13 ` Xishi Qiu
2015-08-04 1:13 ` Xishi Qiu
2015-08-04 14:27 ` Dave Hansen
2015-08-04 14:27 ` Dave Hansen
2015-08-05 7:54 ` Xishi Qiu
2015-08-05 7:54 ` Xishi Qiu
2015-08-05 14:47 ` Dave Hansen [this message]
2015-08-05 14:47 ` Dave Hansen
2015-08-14 7:55 ` Xishi Qiu
2015-08-14 7:55 ` Xishi Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C221EB.7060500@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=alexander.h.duyck@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mhocko@suse.cz \
--cc=qiuxishi@huawei.com \
--cc=sasha.levin@oracle.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.