* [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup @ 2015-07-30 9:25 Shrikant Bobade 2015-07-30 9:31 ` Shrikant Bobade 0 siblings, 1 reply; 7+ messages in thread From: Shrikant Bobade @ 2015-07-30 9:25 UTC (permalink / raw) To: yocto; +Cc: Shrikant Bobade From: Shrikant Bobade <shrikant_bobade@mentor.com> use wildcard for version: adopting libpam upgrade from 1.1.6 to 1.2.1, cleanup older recipe and remove patch sepermit-add-DESTDIR-prefix.patch since the changes already available with latest source. Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com> --- .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 -------------------- recipes-extended/pam/libpam_%.bbappend | 3 ++ recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- 3 files changed, 3 insertions(+), 41 deletions(-) delete mode 100644 recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch create mode 100644 recipes-extended/pam/libpam_%.bbappend delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend diff --git a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch deleted file mode 100644 index d48d386..0000000 --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch +++ /dev/null @@ -1,31 +0,0 @@ -Subject: [PATCH] libpam: add missing DESTDIR prefix - -The DESTDIR prefix is missing, this will cause build failures for -mkdir /var/run/sepermit on the host. - -| mkdir -p /var/run/sepermit -| mkdir: cannot create directory `/var/run/sepermit': Permission denied - -Upstream-Status: Pending - -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> ---- - modules/pam_sepermit/Makefile.am | 2 +- - 1 files changed, 1 insertions(+), 1 deletions(-) - -diff --git a/modules/pam_sepermit/Makefile.am b/modules/pam_sepermit/Makefile.am -index cfc5594..bc82275 100644 ---- a/modules/pam_sepermit/Makefile.am -+++ b/modules/pam_sepermit/Makefile.am -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX - securelib_LTLIBRARIES = pam_sepermit.la - - install-data-local: -- mkdir -p $(sepermitlockdir) -+ mkdir -p $(DESTDIR)$(sepermitlockdir) - endif - if ENABLE_REGENERATE_MAN - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 --- -1.7.5.4 - diff --git a/recipes-extended/pam/libpam_%.bbappend b/recipes-extended/pam/libpam_%.bbappend new file mode 100644 index 0000000..adcf938 --- /dev/null +++ b/recipes-extended/pam/libpam_%.bbappend @@ -0,0 +1,3 @@ +inherit enable-selinux + +RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend b/recipes-extended/pam/libpam_1.1.6.bbappend deleted file mode 100644 index 71acecc..0000000 --- a/recipes-extended/pam/libpam_1.1.6.bbappend +++ /dev/null @@ -1,10 +0,0 @@ -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], d)}" - -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" - -PR .= ".4" - -inherit enable-selinux - -RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-07-30 9:25 [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup Shrikant Bobade @ 2015-07-30 9:31 ` Shrikant Bobade 2015-08-05 15:25 ` Philip Tricca 2015-08-11 5:09 ` Philip Tricca 0 siblings, 2 replies; 7+ messages in thread From: Shrikant Bobade @ 2015-07-30 9:31 UTC (permalink / raw) To: yocto; +Cc: Shrikant Bobade [-- Attachment #1: Type: text/plain, Size: 3598 bytes --] Hi, This patch provides green build for core-image-selinux (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to 1.2.1, image boots fine,but I am unable to login at target. I have prepared build for qemuarm, does anyone else facing similar issue? please advice. Observed the login issue appears even with disabled selinux support (selinux=0). Thanks Shrikant Bobade On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade <bobadeshrikant@gmail.com> wrote: > From: Shrikant Bobade <shrikant_bobade@mentor.com> > > use wildcard for version: adopting libpam upgrade from 1.1.6 to 1.2.1, > cleanup older recipe and remove patch sepermit-add-DESTDIR-prefix.patch > since the changes already available with latest source. > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com> > --- > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > -------------------- > recipes-extended/pam/libpam_%.bbappend | 3 ++ > recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- > 3 files changed, 3 insertions(+), 41 deletions(-) > delete mode 100644 > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > create mode 100644 recipes-extended/pam/libpam_%.bbappend > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > diff --git a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > deleted file mode 100644 > index d48d386..0000000 > --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > +++ /dev/null > @@ -1,31 +0,0 @@ > -Subject: [PATCH] libpam: add missing DESTDIR prefix > - > -The DESTDIR prefix is missing, this will cause build failures for > -mkdir /var/run/sepermit on the host. > - > -| mkdir -p /var/run/sepermit > -| mkdir: cannot create directory `/var/run/sepermit': Permission denied > - > -Upstream-Status: Pending > - > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com> > ---- > - modules/pam_sepermit/Makefile.am | 2 +- > - 1 files changed, 1 insertions(+), 1 deletions(-) > - > -diff --git a/modules/pam_sepermit/Makefile.am > b/modules/pam_sepermit/Makefile.am > -index cfc5594..bc82275 100644 > ---- a/modules/pam_sepermit/Makefile.am > -+++ b/modules/pam_sepermit/Makefile.am > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > - securelib_LTLIBRARIES = pam_sepermit.la > - > - install-data-local: > -- mkdir -p $(sepermitlockdir) > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > - endif > - if ENABLE_REGENERATE_MAN > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > --- > -1.7.5.4 > - > diff --git a/recipes-extended/pam/libpam_%.bbappend > b/recipes-extended/pam/libpam_%.bbappend > new file mode 100644 > index 0000000..adcf938 > --- /dev/null > +++ b/recipes-extended/pam/libpam_%.bbappend > @@ -0,0 +1,3 @@ > +inherit enable-selinux > + > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > b/recipes-extended/pam/libpam_1.1.6.bbappend > deleted file mode 100644 > index 71acecc..0000000 > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > +++ /dev/null > @@ -1,10 +0,0 @@ > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], d)}" > - > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > - > -PR .= ".4" > - > -inherit enable-selinux > - > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > -- > 1.7.9.5 > > [-- Attachment #2: Type: text/html, Size: 4573 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-07-30 9:31 ` Shrikant Bobade @ 2015-08-05 15:25 ` Philip Tricca 2015-08-11 5:09 ` Philip Tricca 1 sibling, 0 replies; 7+ messages in thread From: Philip Tricca @ 2015-08-05 15:25 UTC (permalink / raw) To: yocto Shrikant, On 07/30/2015 02:31 AM, Shrikant Bobade wrote: > This patch provides green build for core-image-selinux > (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to > 1.2.1, > image boots fine,but I am unable to login at target. I have prepared > build for qemuarm, does anyone else facing similar issue? please advice. I've reproduced this issue. Build works, we can drop the DESTDIR patch now. But login fails with the latest version. > Observed the login issue appears even with disabled selinux support > (selinux=0). On a vanilla core-image-minimal with this libpam version login works fine. The SELinux images however, even with SELinux in permissive / disabled, login fails. I guess this means there's something wrong with the SELinux bits in the libpam package. Philip > On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade > <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> wrote: > > From: Shrikant Bobade <shrikant_bobade@mentor.com > <mailto:shrikant_bobade@mentor.com>> > > use wildcard for version: adopting libpam upgrade from 1.1.6 to 1.2.1, > cleanup older recipe and remove patch sepermit-add-DESTDIR-prefix.patch > since the changes already available with latest source. > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com > <mailto:shrikant_bobade@mentor.com>> > --- > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > -------------------- > recipes-extended/pam/libpam_%.bbappend | 3 ++ > recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- > 3 files changed, 3 insertions(+), 41 deletions(-) > delete mode 100644 > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > create mode 100644 recipes-extended/pam/libpam_%.bbappend > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > diff --git > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > deleted file mode 100644 > index d48d386..0000000 > --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > +++ /dev/null > @@ -1,31 +0,0 @@ > -Subject: [PATCH] libpam: add missing DESTDIR prefix > - > -The DESTDIR prefix is missing, this will cause build failures for > -mkdir /var/run/sepermit on the host. > - > -| mkdir -p /var/run/sepermit > -| mkdir: cannot create directory `/var/run/sepermit': Permission denied > - > -Upstream-Status: Pending > - > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com > <mailto:Xin.Ouyang@windriver.com>> > ---- > - modules/pam_sepermit/Makefile.am | 2 +- > - 1 files changed, 1 insertions(+), 1 deletions(-) > - > -diff --git a/modules/pam_sepermit/Makefile.am > b/modules/pam_sepermit/Makefile.am > -index cfc5594..bc82275 100644 > ---- a/modules/pam_sepermit/Makefile.am > -+++ b/modules/pam_sepermit/Makefile.am > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > - securelib_LTLIBRARIES = pam_sepermit.la <http://pam_sepermit.la> > - > - install-data-local: > -- mkdir -p $(sepermitlockdir) > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > - endif > - if ENABLE_REGENERATE_MAN > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > --- > -1.7.5.4 > - > diff --git a/recipes-extended/pam/libpam_%.bbappend > b/recipes-extended/pam/libpam_%.bbappend > new file mode 100644 > index 0000000..adcf938 > --- /dev/null > +++ b/recipes-extended/pam/libpam_%.bbappend > @@ -0,0 +1,3 @@ > +inherit enable-selinux > + > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > b/recipes-extended/pam/libpam_1.1.6.bbappend > deleted file mode 100644 > index 71acecc..0000000 > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > +++ /dev/null > @@ -1,10 +0,0 @@ > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], d)}" > - > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > - > -PR .= ".4" > - > -inherit enable-selinux > - > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > -- > 1.7.9.5 > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-07-30 9:31 ` Shrikant Bobade 2015-08-05 15:25 ` Philip Tricca @ 2015-08-11 5:09 ` Philip Tricca 2015-08-11 11:09 ` Shrikant Bobade 1 sibling, 1 reply; 7+ messages in thread From: Philip Tricca @ 2015-08-11 5:09 UTC (permalink / raw) To: Shrikant Bobade; +Cc: yocto, Shrikant Bobade Hey Shrikant, On 07/30/2015 02:31 AM, Shrikant Bobade wrote: > This patch provides green build for core-image-selinux > (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to > 1.2.1, > image boots fine,but I am unable to login at target. I have prepared > build for qemuarm, does anyone else facing similar issue? please advice. > > Observed the login issue appears even with disabled selinux support > (selinux=0). I just tested this again after Joe merged the commits from the backlog. I'm not longer able to reproduce the failed login. Are you still having login problems? Philip > On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade > <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> wrote: > > From: Shrikant Bobade <shrikant_bobade@mentor.com > <mailto:shrikant_bobade@mentor.com>> > > use wildcard for version: adopting libpam upgrade from 1.1.6 to 1.2.1, > cleanup older recipe and remove patch sepermit-add-DESTDIR-prefix.patch > since the changes already available with latest source. > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com > <mailto:shrikant_bobade@mentor.com>> > --- > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > -------------------- > recipes-extended/pam/libpam_%.bbappend | 3 ++ > recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- > 3 files changed, 3 insertions(+), 41 deletions(-) > delete mode 100644 > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > create mode 100644 recipes-extended/pam/libpam_%.bbappend > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > diff --git > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > deleted file mode 100644 > index d48d386..0000000 > --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > +++ /dev/null > @@ -1,31 +0,0 @@ > -Subject: [PATCH] libpam: add missing DESTDIR prefix > - > -The DESTDIR prefix is missing, this will cause build failures for > -mkdir /var/run/sepermit on the host. > - > -| mkdir -p /var/run/sepermit > -| mkdir: cannot create directory `/var/run/sepermit': Permission denied > - > -Upstream-Status: Pending > - > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com > <mailto:Xin.Ouyang@windriver.com>> > ---- > - modules/pam_sepermit/Makefile.am | 2 +- > - 1 files changed, 1 insertions(+), 1 deletions(-) > - > -diff --git a/modules/pam_sepermit/Makefile.am > b/modules/pam_sepermit/Makefile.am > -index cfc5594..bc82275 100644 > ---- a/modules/pam_sepermit/Makefile.am > -+++ b/modules/pam_sepermit/Makefile.am > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > - securelib_LTLIBRARIES = pam_sepermit.la <http://pam_sepermit.la> > - > - install-data-local: > -- mkdir -p $(sepermitlockdir) > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > - endif > - if ENABLE_REGENERATE_MAN > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > --- > -1.7.5.4 > - > diff --git a/recipes-extended/pam/libpam_%.bbappend > b/recipes-extended/pam/libpam_%.bbappend > new file mode 100644 > index 0000000..adcf938 > --- /dev/null > +++ b/recipes-extended/pam/libpam_%.bbappend > @@ -0,0 +1,3 @@ > +inherit enable-selinux > + > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > b/recipes-extended/pam/libpam_1.1.6.bbappend > deleted file mode 100644 > index 71acecc..0000000 > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > +++ /dev/null > @@ -1,10 +0,0 @@ > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], d)}" > - > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > - > -PR .= ".4" > - > -inherit enable-selinux > - > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, 'pam-plugin-selinux')}" > -- > 1.7.9.5 > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-08-11 5:09 ` Philip Tricca @ 2015-08-11 11:09 ` Shrikant Bobade 2015-08-11 13:37 ` Joe MacDonald 0 siblings, 1 reply; 7+ messages in thread From: Shrikant Bobade @ 2015-08-11 11:09 UTC (permalink / raw) To: Philip Tricca; +Cc: yocto, Shrikant Bobade [-- Attachment #1: Type: text/plain, Size: 5417 bytes --] Hi Philip, On Tue, Aug 11, 2015 at 10:39 AM, Philip Tricca <flihp@twobit.us> wrote: > Hey Shrikant, > > On 07/30/2015 02:31 AM, Shrikant Bobade wrote: > > This patch provides green build for core-image-selinux > > (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to > > 1.2.1, > > image boots fine,but I am unable to login at target. I have prepared > > build for qemuarm, does anyone else facing similar issue? please advice. > > > > Observed the login issue appears even with disabled selinux support > > (selinux=0). > > I just tested this again after Joe merged the commits from the backlog. > I'm not longer able to reproduce the failed login. Are you still having > login problems? > I also got similar results: With the check on latest bits: the login issue is not reproducible on core-image-selinux(with poky-selinux distro) I can now login properly. Build Configuration: BB_VERSION = "1.27.1" BUILD_SYS = "x86_64-linux" NATIVELSBSTRING = "Ubuntu-12.04" TARGET_SYS = "arm-poky-linux-gnueabi" MACHINE = "qemuarm" DISTRO = "poky-selinux" DISTRO_VERSION = "1.8+snapshot-20150811" TUNE_FEATURES = "arm armv5 thumb dsp" TARGET_FPU = "soft" meta meta-yocto meta-yocto-bsp = "master:a16e0b4014173af46ef80d643bb71055219b0dab" meta-selinux = "master:684ee9401f33db7c9d5b183988d89c688c9dd0be" Thanks! Shrikant > Philip > > > On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade > > <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> wrote: > > > > From: Shrikant Bobade <shrikant_bobade@mentor.com > > <mailto:shrikant_bobade@mentor.com>> > > > > use wildcard for version: adopting libpam upgrade from 1.1.6 to > 1.2.1, > > cleanup older recipe and remove patch > sepermit-add-DESTDIR-prefix.patch > > since the changes already available with latest source. > > > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com > > <mailto:shrikant_bobade@mentor.com>> > > --- > > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > > -------------------- > > recipes-extended/pam/libpam_%.bbappend | 3 ++ > > recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- > > 3 files changed, 3 insertions(+), 41 deletions(-) > > delete mode 100644 > > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > create mode 100644 recipes-extended/pam/libpam_%.bbappend > > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > > > diff --git > > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > deleted file mode 100644 > > index d48d386..0000000 > > --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > +++ /dev/null > > @@ -1,31 +0,0 @@ > > -Subject: [PATCH] libpam: add missing DESTDIR prefix > > - > > -The DESTDIR prefix is missing, this will cause build failures for > > -mkdir /var/run/sepermit on the host. > > - > > -| mkdir -p /var/run/sepermit > > -| mkdir: cannot create directory `/var/run/sepermit': Permission > denied > > - > > -Upstream-Status: Pending > > - > > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com > > <mailto:Xin.Ouyang@windriver.com>> > > ---- > > - modules/pam_sepermit/Makefile.am | 2 +- > > - 1 files changed, 1 insertions(+), 1 deletions(-) > > - > > -diff --git a/modules/pam_sepermit/Makefile.am > > b/modules/pam_sepermit/Makefile.am > > -index cfc5594..bc82275 100644 > > ---- a/modules/pam_sepermit/Makefile.am > > -+++ b/modules/pam_sepermit/Makefile.am > > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > > - securelib_LTLIBRARIES = pam_sepermit.la <http://pam_sepermit.la> > > - > > - install-data-local: > > -- mkdir -p $(sepermitlockdir) > > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > > - endif > > - if ENABLE_REGENERATE_MAN > > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > > --- > > -1.7.5.4 > > - > > diff --git a/recipes-extended/pam/libpam_%.bbappend > > b/recipes-extended/pam/libpam_%.bbappend > > new file mode 100644 > > index 0000000..adcf938 > > --- /dev/null > > +++ b/recipes-extended/pam/libpam_%.bbappend > > @@ -0,0 +1,3 @@ > > +inherit enable-selinux > > + > > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, > 'pam-plugin-selinux')}" > > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > > b/recipes-extended/pam/libpam_1.1.6.bbappend > > deleted file mode 100644 > > index 71acecc..0000000 > > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > > +++ /dev/null > > @@ -1,10 +0,0 @@ > > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], > d)}" > > - > > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > > - > > -PR .= ".4" > > - > > -inherit enable-selinux > > - > > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, > 'pam-plugin-selinux')}" > > -- > > 1.7.9.5 > > > > > > > > > > [-- Attachment #2: Type: text/html, Size: 7893 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-08-11 11:09 ` Shrikant Bobade @ 2015-08-11 13:37 ` Joe MacDonald 2015-08-12 14:22 ` Shrikant Bobade 0 siblings, 1 reply; 7+ messages in thread From: Joe MacDonald @ 2015-08-11 13:37 UTC (permalink / raw) To: Shrikant Bobade; +Cc: yocto, Shrikant Bobade [-- Attachment #1: Type: text/plain, Size: 6448 bytes --] [Re: [yocto] [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup] On 15.08.11 (Tue 16:39) Shrikant Bobade wrote: > Hi Philip, > > > On Tue, Aug 11, 2015 at 10:39 AM, Philip Tricca <flihp@twobit.us> wrote: > > Hey Shrikant, > > On 07/30/2015 02:31 AM, Shrikant Bobade wrote: > > This patch provides green build for core-image-selinux > > (meta-selinux:master & poky:master) against libpam upgrade from 1.1.6 to > > 1.2.1, > > image boots fine,but I am unable to login at target. I have prepared > > build for qemuarm, does anyone else facing similar issue? please advice. > > > > Observed the login issue appears even with disabled selinux support > > (selinux=0). > > I just tested this again after Joe merged the commits from the backlog. > I'm not longer able to reproduce the failed login. Are you still having > login problems? > > > I also got similar results: > With the check on latest bits: the login issue is not reproducible on > core-image-selinux(with poky-selinux distro) > I can now login properly. I'm glad to hear that, guys, because I wasn't able to reproduce the login problem on my setup and was thinking I needed to spend time in the next couple of days hunting down what's polluting my environment that I was getting different results than you. :-) This is a nice treat. -J. > > > Build Configuration: > BB_VERSION = "1.27.1" > BUILD_SYS = "x86_64-linux" > NATIVELSBSTRING = "Ubuntu-12.04" > TARGET_SYS = "arm-poky-linux-gnueabi" > MACHINE = "qemuarm" > DISTRO = "poky-selinux" > DISTRO_VERSION = "1.8+snapshot-20150811" > TUNE_FEATURES = "arm armv5 thumb dsp" > TARGET_FPU = "soft" > meta > meta-yocto > meta-yocto-bsp = "master:a16e0b4014173af46ef80d643bb71055219b0dab" > meta-selinux = "master:684ee9401f33db7c9d5b183988d89c688c9dd0be" > > Thanks! > Shrikant > > > > > Philip > > > On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade > > <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> wrote: > > > > From: Shrikant Bobade <shrikant_bobade@mentor.com > > <mailto:shrikant_bobade@mentor.com>> > > > > use wildcard for version: adopting libpam upgrade from 1.1.6 to > 1.2.1, > > cleanup older recipe and remove patch > sepermit-add-DESTDIR-prefix.patch > > since the changes already available with latest source. > > > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com > > <mailto:shrikant_bobade@mentor.com>> > > --- > > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > > -------------------- > > recipes-extended/pam/libpam_%.bbappend | 3 ++ > > recipes-extended/pam/libpam_1.1.6.bbappend | 10 ------- > > 3 files changed, 3 insertions(+), 41 deletions(-) > > delete mode 100644 > > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > create mode 100644 recipes-extended/pam/libpam_%.bbappend > > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > > > diff --git > > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > deleted file mode 100644 > > index d48d386..0000000 > > --- a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > +++ /dev/null > > @@ -1,31 +0,0 @@ > > -Subject: [PATCH] libpam: add missing DESTDIR prefix > > - > > -The DESTDIR prefix is missing, this will cause build failures for > > -mkdir /var/run/sepermit on the host. > > - > > -| mkdir -p /var/run/sepermit > > -| mkdir: cannot create directory `/var/run/sepermit': Permission > denied > > - > > -Upstream-Status: Pending > > - > > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com > > <mailto:Xin.Ouyang@windriver.com>> > > ---- > > - modules/pam_sepermit/Makefile.am | 2 +- > > - 1 files changed, 1 insertions(+), 1 deletions(-) > > - > > -diff --git a/modules/pam_sepermit/Makefile.am > > b/modules/pam_sepermit/Makefile.am > > -index cfc5594..bc82275 100644 > > ---- a/modules/pam_sepermit/Makefile.am > > -+++ b/modules/pam_sepermit/Makefile.am > > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > > - securelib_LTLIBRARIES = pam_sepermit.la <http://pam_sepermit.la> > > - > > - install-data-local: > > -- mkdir -p $(sepermitlockdir) > > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > > - endif > > - if ENABLE_REGENERATE_MAN > > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > > --- > > -1.7.5.4 > > - > > diff --git a/recipes-extended/pam/libpam_%.bbappend > > b/recipes-extended/pam/libpam_%.bbappend > > new file mode 100644 > > index 0000000..adcf938 > > --- /dev/null > > +++ b/recipes-extended/pam/libpam_%.bbappend > > @@ -0,0 +1,3 @@ > > +inherit enable-selinux > > + > > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, > 'pam-plugin-selinux')}" > > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > > b/recipes-extended/pam/libpam_1.1.6.bbappend > > deleted file mode 100644 > > index 71acecc..0000000 > > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > > +++ /dev/null > > @@ -1,10 +0,0 @@ > > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > -FILESPATH_append := ":${@base_set_filespath(['${THISDIR}/${PN}'], > d)}" > > - > > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > > - > > -PR .= ".4" > > - > > -inherit enable-selinux > > - > > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, > 'pam-plugin-selinux')}" > > -- > > 1.7.9.5 > > > > > > > > > > > -- -Joe MacDonald. :wq [-- Attachment #2: Digital signature --] [-- Type: application/pgp-signature, Size: 484 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup 2015-08-11 13:37 ` Joe MacDonald @ 2015-08-12 14:22 ` Shrikant Bobade 0 siblings, 0 replies; 7+ messages in thread From: Shrikant Bobade @ 2015-08-12 14:22 UTC (permalink / raw) To: Joe MacDonald; +Cc: yocto, Shrikant Bobade [-- Attachment #1: Type: text/plain, Size: 7180 bytes --] On Tue, Aug 11, 2015 at 7:07 PM, Joe MacDonald <Joe_MacDonald@mentor.com> wrote: > [Re: [yocto] [meta-selinux][PATCH v1] libpam: use wildcard for version and > cleanup] On 15.08.11 (Tue 16:39) Shrikant Bobade wrote: > > > Hi Philip, > > > > > > On Tue, Aug 11, 2015 at 10:39 AM, Philip Tricca <flihp@twobit.us> wrote: > > > > Hey Shrikant, > > > > On 07/30/2015 02:31 AM, Shrikant Bobade wrote: > > > This patch provides green build for core-image-selinux > > > (meta-selinux:master & poky:master) against libpam upgrade from > 1.1.6 to > > > 1.2.1, > > > image boots fine,but I am unable to login at target. I have > prepared > > > build for qemuarm, does anyone else facing similar issue? please > advice. > > > > > > Observed the login issue appears even with disabled selinux support > > > (selinux=0). > > > > I just tested this again after Joe merged the commits from the > backlog. > > I'm not longer able to reproduce the failed login. Are you still > having > > login problems? > > > > > > I also got similar results: > > With the check on latest bits: the login issue is not reproducible on > > core-image-selinux(with poky-selinux distro) > > I can now login properly. > > I'm glad to hear that, guys, because I wasn't able to reproduce the > login problem on my setup and was thinking I needed to spend time in the > next couple of days hunting down what's polluting my environment that I > was getting different results than you. :-) This is a nice treat. > > -J. > > Thanks Joe & Philip, I just compared my latest setup (login working) with older one(login issue) observed this patch at poky served the login fix: http://git.yoctoproject.org/cgit/cgit.cgi/poky/commit/meta/recipes-extended/pam/libpam?id=c75cefe8a382a63f625123c156137782db118f64 Thanks! Shrikant > > > > > > Build Configuration: > > BB_VERSION = "1.27.1" > > BUILD_SYS = "x86_64-linux" > > NATIVELSBSTRING = "Ubuntu-12.04" > > TARGET_SYS = "arm-poky-linux-gnueabi" > > MACHINE = "qemuarm" > > DISTRO = "poky-selinux" > > DISTRO_VERSION = "1.8+snapshot-20150811" > > TUNE_FEATURES = "arm armv5 thumb dsp" > > TARGET_FPU = "soft" > > meta > > meta-yocto > > meta-yocto-bsp = "master:a16e0b4014173af46ef80d643bb71055219b0dab" > > meta-selinux = "master:684ee9401f33db7c9d5b183988d89c688c9dd0be" > > > > Thanks! > > Shrikant > > > > > > > > > > Philip > > > > > On Thu, Jul 30, 2015 at 2:55 PM, Shrikant Bobade > > > <bobadeshrikant@gmail.com <mailto:bobadeshrikant@gmail.com>> > wrote: > > > > > > From: Shrikant Bobade <shrikant_bobade@mentor.com > > > <mailto:shrikant_bobade@mentor.com>> > > > > > > use wildcard for version: adopting libpam upgrade from 1.1.6 to > > 1.2.1, > > > cleanup older recipe and remove patch > > sepermit-add-DESTDIR-prefix.patch > > > since the changes already available with latest source. > > > > > > Signed-off-by: Shrikant Bobade <shrikant_bobade@mentor.com > > > <mailto:shrikant_bobade@mentor.com>> > > > --- > > > .../pam/libpam/sepermit-add-DESTDIR-prefix.patch | 31 > > > -------------------- > > > recipes-extended/pam/libpam_%.bbappend | 3 ++ > > > recipes-extended/pam/libpam_1.1.6.bbappend | 10 > ------- > > > 3 files changed, 3 insertions(+), 41 deletions(-) > > > delete mode 100644 > > > recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > > create mode 100644 recipes-extended/pam/libpam_%.bbappend > > > delete mode 100644 recipes-extended/pam/libpam_1.1.6.bbappend > > > > > > diff --git > > > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > > b/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > > deleted file mode 100644 > > > index d48d386..0000000 > > > --- > a/recipes-extended/pam/libpam/sepermit-add-DESTDIR-prefix.patch > > > +++ /dev/null > > > @@ -1,31 +0,0 @@ > > > -Subject: [PATCH] libpam: add missing DESTDIR prefix > > > - > > > -The DESTDIR prefix is missing, this will cause build failures > for > > > -mkdir /var/run/sepermit on the host. > > > - > > > -| mkdir -p /var/run/sepermit > > > -| mkdir: cannot create directory `/var/run/sepermit': > Permission > > denied > > > - > > > -Upstream-Status: Pending > > > - > > > -Signed-off-by: Xin Ouyang <Xin.Ouyang@windriver.com > > > <mailto:Xin.Ouyang@windriver.com>> > > > ---- > > > - modules/pam_sepermit/Makefile.am | 2 +- > > > - 1 files changed, 1 insertions(+), 1 deletions(-) > > > - > > > -diff --git a/modules/pam_sepermit/Makefile.am > > > b/modules/pam_sepermit/Makefile.am > > > -index cfc5594..bc82275 100644 > > > ---- a/modules/pam_sepermit/Makefile.am > > > -+++ b/modules/pam_sepermit/Makefile.am > > > -@@ -35,7 +35,7 @@ if HAVE_LIBSELINUX > > > - securelib_LTLIBRARIES = pam_sepermit.la < > http://pam_sepermit.la> > > > - > > > - install-data-local: > > > -- mkdir -p $(sepermitlockdir) > > > -+ mkdir -p $(DESTDIR)$(sepermitlockdir) > > > - endif > > > - if ENABLE_REGENERATE_MAN > > > - noinst_DATA = README pam_sepermit.8 sepermit.conf.5 > > > --- > > > -1.7.5.4 > > > - > > > diff --git a/recipes-extended/pam/libpam_%.bbappend > > > b/recipes-extended/pam/libpam_%.bbappend > > > new file mode 100644 > > > index 0000000..adcf938 > > > --- /dev/null > > > +++ b/recipes-extended/pam/libpam_%.bbappend > > > @@ -0,0 +1,3 @@ > > > +inherit enable-selinux > > > + > > > +RDEPENDS_${PN}-runtime += "${@target_selinux(d, > > 'pam-plugin-selinux')}" > > > diff --git a/recipes-extended/pam/libpam_1.1.6.bbappend > > > b/recipes-extended/pam/libpam_1.1.6.bbappend > > > deleted file mode 100644 > > > index 71acecc..0000000 > > > --- a/recipes-extended/pam/libpam_1.1.6.bbappend > > > +++ /dev/null > > > @@ -1,10 +0,0 @@ > > > -#FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:" > > > -FILESPATH_append := > ":${@base_set_filespath(['${THISDIR}/${PN}'], > > d)}" > > > - > > > -SRC_URI += "file://sepermit-add-DESTDIR-prefix.patch" > > > - > > > -PR .= ".4" > > > - > > > -inherit enable-selinux > > > - > > > -RDEPENDS_${PN}-runtime += "${@target_selinux(d, > > 'pam-plugin-selinux')}" > > > -- > > > 1.7.9.5 > > > > > > > > > > > > > > > > > > > > -- > -Joe MacDonald. > :wq > [-- Attachment #2: Type: text/html, Size: 10623 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-12 14:22 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-07-30 9:25 [meta-selinux][PATCH v1] libpam: use wildcard for version and cleanup Shrikant Bobade 2015-07-30 9:31 ` Shrikant Bobade 2015-08-05 15:25 ` Philip Tricca 2015-08-11 5:09 ` Philip Tricca 2015-08-11 11:09 ` Shrikant Bobade 2015-08-11 13:37 ` Joe MacDonald 2015-08-12 14:22 ` Shrikant Bobade
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.