Re: [meta-raspberrypi][PATCH 5/5] rpi-default-providers: Switch providers according to used gfx stack

[Javier Martinez Canillas <javier@osg.samsung.com>]

Hello Khem,

On 08/06/2015 04:54 AM, Khem Raj wrote:
> On Tue, Aug 4, 2015 at 11:34 PM, Javier Martinez Canillas
> <javier@osg.samsung.com> wrote:
>>> who defines the distro feature ?
>>>
>>>
>>
>> Distro features AFAICT are user defined options, you can for example have
>> the following in your conf/local.conf:
>>
>> DISTRO_FEATURES_append = " vc4-gfx"
> 
> I wasnt trying to learn about what DISTRO_FEATURES are, I was trying
> to draw attention to the fact that meta-rpi being a BSP layer

Ok, sorry. But I believe it's more productive to just do suggestions
instead of asking rhetorical questions that can be misunderstood :-)

> was trying to define a lot more than a BSP layer is supposed to do. So
> if its a distro feature, I would like it to work as expected on other
> machines besides raspberrypi. If thats not applicable then we should
> rethink if it could be folded into MACHINE_FEATURES if it needs to be

Yes, I in fact was not sure if it should be a distro or machine feature
and then decided on the former because there is more than the kernel to
make it work like changing mesa configure options. But as mentioned to
Andrea Müller, probably we should ship a mesa .bbappend for this in the
BSP so I agree that a MACHINE_FEATURE will make more sense.

> a distro feature then propose it to OE-Core, at the very least
> document them in README of this layer. Or separate it out into a
> common layer which rpi BSPs will depend on.
> but think beyond single machine when deciding on adding distro
> features, there are distros based on OE which support multiple
> machines
> 

Yes, I know that there are distros than support more tha one machine but
I thought it was OK to have machine specific DISTRO_FEATURES but seems I
was wrong.

Another option is to add a different machine (i.e: raspberrypi2-vc4.conf)
so instead of changing the default provider based on a feature, it can
be set based on the machine. Petter Mabäcker asked to have a different BB
recipe for the vc4 kernel so the conditional include of the vc4 patches
will not be needed on the kernel recipe either.

What do you think of this option?

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America