Re: [meta-raspberrypi][PATCH 5/5] rpi-default-providers: Switch providers according to used gfx stack

[Javier Martinez Canillas <javier@osg.samsung.com>]

Hello Andrei,

On 08/10/2015 01:05 AM, Andrei Gherzan wrote:
> On Thu, Aug 06, 2015 at 08:59:56AM +0200, Javier Martinez Canillas wrote:
>> Hello Khem,
>>
>> On 08/06/2015 04:54 AM, Khem Raj wrote:
>>> On Tue, Aug 4, 2015 at 11:34 PM, Javier Martinez Canillas
>>> <javier@osg.samsung.com> wrote:
>>>>> who defines the distro feature ?
>>>>>
>>>>>
>>>>
>>>> Distro features AFAICT are user defined options, you can for example have
>>>> the following in your conf/local.conf:
>>>>
>>>> DISTRO_FEATURES_append = " vc4-gfx"
>>>
>>> I wasnt trying to learn about what DISTRO_FEATURES are, I was trying
>>> to draw attention to the fact that meta-rpi being a BSP layer
>>
>> Ok, sorry. But I believe it's more productive to just do suggestions
>> instead of asking rhetorical questions that can be misunderstood :-)
>>
>>> was trying to define a lot more than a BSP layer is supposed to do. So
>>> if its a distro feature, I would like it to work as expected on other
>>> machines besides raspberrypi. If thats not applicable then we should
>>> rethink if it could be folded into MACHINE_FEATURES if it needs to be
>>
> 
> Khem definitely has a very good point. Maybe his way of putting it in words was
> not that productive. But the core idea was definitely right: I don't want rpi
> layer to introduce distro features.
>

Agreed. After Khem answers and reading about the MACHINE and DISTRO in
the documentation, I understood that the changes were not correct.
Thanks a lot to both of you for the clarification.
 
> --
> Andrei Gherzan
> 

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America