From: nick <xerofoify@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, agraf@suse.com
Cc: gleb@kernel.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing
Date: Fri, 07 Aug 2015 10:00:52 -0400 [thread overview]
Message-ID: <55C4BA14.8020307@gmail.com> (raw)
In-Reply-To: <55C4B9C0.5030102@redhat.com>
On 2015-08-07 09:59 AM, Paolo Bonzini wrote:
>
>
> On 07/08/2015 15:47, Nicholas Krause wrote:
>> - kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> + if (ret) {
>> + kfree(routing);
>> + return ret;
>> + }
>>
>> kfree(routing);
>> return 0;
>
> You could just return ret here. The new "if" is not necessary.
>
> Paolo
>
Ok sure that seems fine to be and much simpler then this.
Sorry about the wasting your time with this patch.
Nick
WARNING: multiple messages have this Message-ID (diff)
From: nick <xerofoify@gmail.com>
To: Paolo Bonzini <pbonzini@redhat.com>, agraf@suse.com
Cc: gleb@kernel.org, linuxppc-dev@lists.ozlabs.org,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing
Date: Fri, 07 Aug 2015 10:00:52 -0400 [thread overview]
Message-ID: <55C4BA14.8020307@gmail.com> (raw)
In-Reply-To: <55C4B9C0.5030102@redhat.com>
On 2015-08-07 09:59 AM, Paolo Bonzini wrote:
>
>
> On 07/08/2015 15:47, Nicholas Krause wrote:
>> - kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> + ret = kvm_set_irq_routing(opp->kvm, routing, 0, 0);
>> + if (ret) {
>> + kfree(routing);
>> + return ret;
>> + }
>>
>> kfree(routing);
>> return 0;
>
> You could just return ret here. The new "if" is not necessary.
>
> Paolo
>
Ok sure that seems fine to be and much simpler then this.
Sorry about the wasting your time with this patch.
Nick
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
next prev parent reply other threads:[~2015-08-07 14:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 13:47 [PATCH] kvm:powerpc:Fix error handling in the function mpic_set_default_irq_routing Nicholas Krause
2015-08-07 13:47 ` Nicholas Krause
2015-08-07 13:59 ` Paolo Bonzini
2015-08-07 13:59 ` Paolo Bonzini
2015-08-07 14:00 ` nick [this message]
2015-08-07 14:00 ` nick
-- strict thread matches above, loose matches on Subject: below --
2015-08-06 17:13 Nicholas Krause
2015-08-06 17:13 ` Nicholas Krause
2015-08-07 10:17 ` Paolo Bonzini
2015-08-07 10:17 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C4BA14.8020307@gmail.com \
--to=xerofoify@gmail.com \
--cc=agraf@suse.com \
--cc=gleb@kernel.org \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.