* Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) [not found] <201508110049.yV4f3Yls%fengguang.wu@intel.com> @ 2015-08-10 17:44 ` Tadeusz Struk 2015-08-11 13:57 ` Herbert Xu 0 siblings, 1 reply; 4+ messages in thread From: Tadeusz Struk @ 2015-08-10 17:44 UTC (permalink / raw) To: Herbert Xu; +Cc: kbuild test robot, kbuild-all, linux-crypto On 08/10/2015 09:24 AM, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master > head: 9cfaf082b8775e9f99fa5f2e8b2ae0ca8baff785 > commit: dd0f368398ea100e34259bf812bc482e15c81991 [119/123] crypto: qat - Add qat dh895xcc VF driver > config: mips-allyesconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout dd0f368398ea100e34259bf812bc482e15c81991 > # save the attached .config to linux build tree > make.cross ARCH=mips > > All warnings (new ones prefixed by >>): > > warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) ---8<--- Fix unmet direct dependencies for QAT_DH895xCCVF Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig index 95a9566..6d1d107 100644 --- a/drivers/crypto/qat/Kconfig +++ b/drivers/crypto/qat/Kconfig @@ -24,6 +24,7 @@ config CRYPTO_DEV_QAT_DH895xCC config CRYPTO_DEV_QAT_DH895xCCVF tristate "Support for Intel(R) DH895xCC Virtual Function" + select PCI select PCI_IOV help ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) 2015-08-10 17:44 ` [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) Tadeusz Struk @ 2015-08-11 13:57 ` Herbert Xu 2015-08-11 18:05 ` Tadeusz Struk 0 siblings, 1 reply; 4+ messages in thread From: Herbert Xu @ 2015-08-11 13:57 UTC (permalink / raw) To: Tadeusz Struk; +Cc: kbuild test robot, kbuild-all, linux-crypto On Mon, Aug 10, 2015 at 10:44:09AM -0700, Tadeusz Struk wrote: > > config CRYPTO_DEV_QAT_DH895xCCVF > tristate "Support for Intel(R) DH895xCC Virtual Function" > + select PCI > select PCI_IOV Wouldn't a dependency on PCI make more sense? Or does this not work? Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) 2015-08-11 13:57 ` Herbert Xu @ 2015-08-11 18:05 ` Tadeusz Struk 2015-08-13 7:17 ` Herbert Xu 0 siblings, 1 reply; 4+ messages in thread From: Tadeusz Struk @ 2015-08-11 18:05 UTC (permalink / raw) To: Herbert Xu; +Cc: kbuild test robot, kbuild-all, linux-crypto On 08/11/2015 06:57 AM, Herbert Xu wrote: > On Mon, Aug 10, 2015 at 10:44:09AM -0700, Tadeusz Struk wrote: >> > >> > config CRYPTO_DEV_QAT_DH895xCCVF >> > tristate "Support for Intel(R) DH895xCC Virtual Function" >> > + select PCI >> > select PCI_IOV > Wouldn't a dependency on PCI make more sense? Or does this not > work? Yes, you are right. This is how it is in the PF config. It also needs to select the qat common code. ---8<--- Fix unmet direct dependencies for QAT_DH895xCCVF Reported-by: Fengguang Wu <fengguang.wu@intel.com> Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com> diff --git a/drivers/crypto/qat/Kconfig b/drivers/crypto/qat/Kconfig index 95a9566..eefccf7 100644 --- a/drivers/crypto/qat/Kconfig +++ b/drivers/crypto/qat/Kconfig @@ -24,7 +24,9 @@ config CRYPTO_DEV_QAT_DH895xCC config CRYPTO_DEV_QAT_DH895xCCVF tristate "Support for Intel(R) DH895xCC Virtual Function" + depends on X86 && PCI select PCI_IOV + select CRYPTO_DEV_QAT help Support for Intel(R) DH895xcc with Intel(R) QuickAssist Technology ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) 2015-08-11 18:05 ` Tadeusz Struk @ 2015-08-13 7:17 ` Herbert Xu 0 siblings, 0 replies; 4+ messages in thread From: Herbert Xu @ 2015-08-13 7:17 UTC (permalink / raw) To: Tadeusz Struk; +Cc: kbuild test robot, kbuild-all, linux-crypto On Tue, Aug 11, 2015 at 11:05:37AM -0700, Tadeusz Struk wrote: > > ---8<--- > Fix unmet direct dependencies for QAT_DH895xCCVF > > Reported-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Tadeusz Struk <tadeusz.struk@intel.com> Applied. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-08-13 7:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <201508110049.yV4f3Yls%fengguang.wu@intel.com>
2015-08-10 17:44 ` [cryptodev:master 119/123] warning: (CRYPTO_DEV_QAT_DH895xCCVF) selects PCI_IOV which has unmet direct dependencies (PCI) Tadeusz Struk
2015-08-11 13:57 ` Herbert Xu
2015-08-11 18:05 ` Tadeusz Struk
2015-08-13 7:17 ` Herbert Xu
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.