* [patch] staging: comedi: me4000: use bitwise AND instead of logical
@ 2015-08-14 8:54 Dan Carpenter
2015-08-14 10:29 ` Ian Abbott
2015-08-14 17:40 ` Hartley Sweeten
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2015-08-14 8:54 UTC (permalink / raw)
To: kernel-janitors
This was supposed to bitwise AND but there is a typo.
Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
index 5aa1780..15a5320 100644
--- a/drivers/staging/comedi/drivers/me4000.c
+++ b/drivers/staging/comedi/drivers/me4000.c
@@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev,
entry = chan | ME4000_AI_LIST_RANGE(range);
if (aref = AREF_DIFF) {
- if (!(s->subdev_flags && SDF_DIFF)) {
+ if (!(s->subdev_flags & SDF_DIFF)) {
dev_err(dev->class_dev,
"Differential inputs are not available\n");
return -EINVAL;
@@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev,
}
if (aref = AREF_DIFF) {
- if (!(s->subdev_flags && SDF_DIFF)) {
+ if (!(s->subdev_flags & SDF_DIFF)) {
dev_err(dev->class_dev,
"Differential inputs are not available\n");
return -EINVAL;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [patch] staging: comedi: me4000: use bitwise AND instead of logical
2015-08-14 8:54 [patch] staging: comedi: me4000: use bitwise AND instead of logical Dan Carpenter
@ 2015-08-14 10:29 ` Ian Abbott
2015-08-14 17:40 ` Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: Ian Abbott @ 2015-08-14 10:29 UTC (permalink / raw)
To: kernel-janitors
On 14/08/15 09:54, Dan Carpenter wrote:
> This was supposed to bitwise AND but there is a typo.
>
> Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
> index 5aa1780..15a5320 100644
> --- a/drivers/staging/comedi/drivers/me4000.c
> +++ b/drivers/staging/comedi/drivers/me4000.c
> @@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev,
>
> entry = chan | ME4000_AI_LIST_RANGE(range);
> if (aref = AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
> @@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev,
> }
>
> if (aref = AREF_DIFF) {
> - if (!(s->subdev_flags && SDF_DIFF)) {
> + if (!(s->subdev_flags & SDF_DIFF)) {
> dev_err(dev->class_dev,
> "Differential inputs are not available\n");
> return -EINVAL;
>
Thanks for catching that.
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [patch] staging: comedi: me4000: use bitwise AND instead of logical
2015-08-14 8:54 [patch] staging: comedi: me4000: use bitwise AND instead of logical Dan Carpenter
2015-08-14 10:29 ` Ian Abbott
@ 2015-08-14 17:40 ` Hartley Sweeten
1 sibling, 0 replies; 3+ messages in thread
From: Hartley Sweeten @ 2015-08-14 17:40 UTC (permalink / raw)
To: kernel-janitors
On Friday, August 14, 2015 3:29 AM, Ian Abbott wrote:
> On 14/08/15 09:54, Dan Carpenter wrote:
>> This was supposed to bitwise AND but there is a typo.
>>
>> Fixes: 1a02387063fb ('staging: comedi: me4000: remove 'board' from me4000_ai_insn_read()')
>> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>>
>> diff --git a/drivers/staging/comedi/drivers/me4000.c b/drivers/staging/comedi/drivers/me4000.c
>> index 5aa1780..15a5320 100644
>> --- a/drivers/staging/comedi/drivers/me4000.c
>> +++ b/drivers/staging/comedi/drivers/me4000.c
>> @@ -480,7 +480,7 @@ static int me4000_ai_insn_read(struct comedi_device *dev,
>>
>> entry = chan | ME4000_AI_LIST_RANGE(range);
>> if (aref = AREF_DIFF) {
>> - if (!(s->subdev_flags && SDF_DIFF)) {
>> + if (!(s->subdev_flags & SDF_DIFF)) {
>> dev_err(dev->class_dev,
>> "Differential inputs are not available\n");
>> return -EINVAL;
>> @@ -559,7 +559,7 @@ static int me4000_ai_check_chanlist(struct comedi_device *dev,
>> }
>>
>> if (aref = AREF_DIFF) {
>> - if (!(s->subdev_flags && SDF_DIFF)) {
>> + if (!(s->subdev_flags & SDF_DIFF)) {
>> dev_err(dev->class_dev,
>> "Differential inputs are not available\n");
>> return -EINVAL;
>>
>
> Thanks for catching that.
>
> Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Gah... Sorry about that. Thanks for the catch Dan.
Reviewed-by: H Hartley Sweeten <hsweeten@visionengravers.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-08-14 17:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-14 8:54 [patch] staging: comedi: me4000: use bitwise AND instead of logical Dan Carpenter
2015-08-14 10:29 ` Ian Abbott
2015-08-14 17:40 ` Hartley Sweeten
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.