All of lore.kernel.org
 help / color / mirror / Atom feed
From: Hans de Goede <hdegoede@redhat.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 11/15] sunxi_nand_spl: Add support for sun4i and sun5i SoCs
Date: Mon, 17 Aug 2015 10:31:43 +0200	[thread overview]
Message-ID: <55D19BEF.3070902@redhat.com> (raw)
In-Reply-To: <1439800169.3480.64.camel@hellion.org.uk>

Hi,

On 17-08-15 10:29, Ian Campbell wrote:
> On Sat, 2015-08-15 at 22:02 +0200, Hans de Goede wrote:
>> Other then having a few less chip-select lines the nand controller
>> on sun4i, sun5i and sun7i is identical.
>>
>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>> ---
>>   board/sunxi/board.c      | 12 +++++++++---
>>   drivers/mtd/nand/Kconfig |  4 ++--
>>   2 files changed, 11 insertions(+), 5 deletions(-)
>>
>> diff --git a/board/sunxi/board.c b/board/sunxi/board.c
>> index 1ebd0a4..d411e96 100644
>> --- a/board/sunxi/board.c
>> +++ b/board/sunxi/board.c
>> @@ -112,13 +112,19 @@ int dram_init(void)
>>   static void nand_pinmux_setup(void)
>>   {
>>   	unsigned int pin;
>> -	for (pin = SUNXI_GPC(0); pin <= SUNXI_GPC(6); pin++)
>> -		sunxi_gpio_set_cfgpin(pin, SUNXI_GPC_NAND);
>>
>> -	for (pin = SUNXI_GPC(8); pin <= SUNXI_GPC(22); pin++)
>> +	for (pin = SUNXI_GPC(0); pin <= SUNXI_GPC(19); pin++)
>
> This looks to have added GPC(7) to all platforms, was that intentional?

Yes, as GPC7 is a nand pin on all platforms, no idea why the original
code was skipping it. I should probably mention this in the commit msg though.

Regards,

Hans

  reply	other threads:[~2015-08-17  8:31 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-15 20:02 [U-Boot] [PATCH 00/15] sunxi_nand_spl: cleanups, auto config and bad block handling Hans de Goede
2015-08-15 20:02 ` [U-Boot] [PATCH 01/15] sunxi_nand_spl: Fix CONFIG_SPL_NAND_SUNXI handling Hans de Goede
2015-08-17  8:11   ` Ian Campbell
2015-08-19 13:45   ` Maxime Ripard
2015-08-20  6:33     ` Hans de Goede
2015-08-27 12:36       ` Maxime Ripard
2015-08-15 20:02 ` [U-Boot] [PATCH 02/15] sunxi_nand_spl: Drop unnecessary temp buf Hans de Goede
2015-08-17  7:22   ` Chen-Yu Tsai
2015-08-17  8:14     ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 03/15] sunxi_nand_spl: We only need to reset the nand chip once Hans de Goede
2015-08-17  8:14   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 04/15] sunxi_nand_spl: Do not bother writing the spare-area reg in syndrome mode Hans de Goede
2015-08-17  8:19   ` Ian Campbell
2015-08-17  8:59     ` Hans de Goede
2015-08-17 11:28       ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 05/15] sunxi_nand_spl: Use SYS_NAND_SELF_INIT and only do nand init when necessary Hans de Goede
2015-08-17  8:20   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 06/15] sunxi_nand_spl: Make sure the DMA controller is enabled Hans de Goede
2015-08-17  8:21   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 07/15] sunxi_nand_spl: Turn off clocks when we're done with the nand Hans de Goede
2015-08-17  8:22   ` Ian Campbell
2015-08-19 13:48   ` Maxime Ripard
2015-08-20  6:35     ` Hans de Goede
2015-08-24 14:54       ` Maxime Ripard
2015-08-15 20:02 ` [U-Boot] [PATCH 08/15] sunxi_nand_spl: Add proper cache flusing Hans de Goede
2015-08-17  8:22   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 09/15] sunxi_nand_spl: Use kernel driver algorithm for determining ecc_mode / _off Hans de Goede
2015-08-17  8:24   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 10/15] sunxi_nand_spl: Remove NAND_SUNXI_SPL_SYNDROME_PARTITIONS_END Hans de Goede
2015-08-17  8:27   ` Ian Campbell
2015-08-17  9:05     ` Hans de Goede
2015-08-15 20:02 ` [U-Boot] [PATCH 11/15] sunxi_nand_spl: Add support for sun4i and sun5i SoCs Hans de Goede
2015-08-17  8:29   ` Ian Campbell
2015-08-17  8:31     ` Hans de Goede [this message]
2015-08-17  8:35       ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 12/15] sunxi_nand_spl: Properly config page-size in the nand ctl register Hans de Goede
2015-08-17  8:29   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 13/15] sunxi_nand_spl: Parametrize lowlevel read functions Hans de Goede
2015-08-17  8:31   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 14/15] sunxi_nand_spl: Auto detect nand configuration parameters Hans de Goede
2015-08-17  8:32   ` Ian Campbell
2015-08-15 20:02 ` [U-Boot] [PATCH 15/15] sunxi_nand_spl: Add support for backup boot partitions Hans de Goede
2015-08-17  8:34   ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55D19BEF.3070902@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.