From: Helge Deller <deller@gmx.de>
To: Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: John David Anglin <dave.anglin@bell.net>,
Meelis Roos <mroos@linux.ee>,
linux-parisc@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: A500 boot crash in 4.2.0-rc3-00246-g763e326
Date: Thu, 20 Aug 2015 23:15:06 +0200 [thread overview]
Message-ID: <55D6435A.9060808@gmx.de> (raw)
In-Reply-To: <CAE9FiQXmzAoJ-5DtrzR94otRKtwJyzAxx8BUK+tuo2j_+rP9JA@mail.gmail.com>
On 20.08.2015 21:31, Yinghai Lu wrote:
> On Wed, Aug 19, 2015 at 10:42 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>
>> commit 51a660a2732c
>> Author: Bjorn Helgaas <bhelgaas@google.com>
>> Date: Thu Aug 20 00:08:15 2015 -0500
>>
>> PCI: Don't use 64-bit bus addresses on PA-RISC
>>
>> Meelis and Helge reported that 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t")
>> caused HPMCs on A500 and hangs on rp5470.
>>
>> PA-RISC does not set ARCH_DMA_ADDR_T_64BIT, even for 64-bit kernels, so
>> prior to 3a9ad0b4fdcd, we always used 32-bit PCI addresses. After
>> 3a9ad0b4fdcd, we do use 64-bit PCI addresses in 64-bit kernels, and
>> apparently there's some PA-RISC problem related to them.
>>
>> Fixes: 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t")
>> Link: http://lkml.kernel.org/r/alpine.LRH.2.11.1507260929000.30065@math.ut.ee
>> Reported-by: Meelis Roos <mroos@linux.ee>
>> Reported-by: Helge Deller <deller@gmx.de>
>> Based-on-idea-by: Yinghai Lu <yinghai@kernel.org>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>
>> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
>> index 73de4ef..944f500 100644
>> --- a/drivers/pci/Kconfig
>> +++ b/drivers/pci/Kconfig
>> @@ -2,7 +2,7 @@
>> # PCI configuration
>> #
>> config PCI_BUS_ADDR_T_64BIT
>> - def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT)
>> + def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC))
>> depends on PCI
>>
>> config PCI_MSI
>
> Yes, that is better.
>
> Acked-by: Yinghai Lu <yinghai@kernel.org>
Tested-by: Helge Deller <deller@gmx.de>
and please add:
CC: stable@vger.kernel.org # v3.19+
Helge
WARNING: multiple messages have this Message-ID (diff)
From: Helge Deller <deller@gmx.de>
To: Yinghai Lu <yinghai@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>
Cc: John David Anglin <dave.anglin@bell.net>,
Meelis Roos <mroos@linux.ee>,
linux-parisc@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"sparclinux@vger.kernel.org" <sparclinux@vger.kernel.org>,
James Bottomley <James.Bottomley@hansenpartnership.com>
Subject: Re: A500 boot crash in 4.2.0-rc3-00246-g763e326
Date: Thu, 20 Aug 2015 21:15:06 +0000 [thread overview]
Message-ID: <55D6435A.9060808@gmx.de> (raw)
In-Reply-To: <CAE9FiQXmzAoJ-5DtrzR94otRKtwJyzAxx8BUK+tuo2j_+rP9JA@mail.gmail.com>
On 20.08.2015 21:31, Yinghai Lu wrote:
> On Wed, Aug 19, 2015 at 10:42 PM, Bjorn Helgaas <bhelgaas@google.com> wrote:
>
>> commit 51a660a2732c
>> Author: Bjorn Helgaas <bhelgaas@google.com>
>> Date: Thu Aug 20 00:08:15 2015 -0500
>>
>> PCI: Don't use 64-bit bus addresses on PA-RISC
>>
>> Meelis and Helge reported that 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t")
>> caused HPMCs on A500 and hangs on rp5470.
>>
>> PA-RISC does not set ARCH_DMA_ADDR_T_64BIT, even for 64-bit kernels, so
>> prior to 3a9ad0b4fdcd, we always used 32-bit PCI addresses. After
>> 3a9ad0b4fdcd, we do use 64-bit PCI addresses in 64-bit kernels, and
>> apparently there's some PA-RISC problem related to them.
>>
>> Fixes: 3a9ad0b4fdcd ("PCI: Add pci_bus_addr_t")
>> Link: http://lkml.kernel.org/r/alpine.LRH.2.11.1507260929000.30065@math.ut.ee
>> Reported-by: Meelis Roos <mroos@linux.ee>
>> Reported-by: Helge Deller <deller@gmx.de>
>> Based-on-idea-by: Yinghai Lu <yinghai@kernel.org>
>> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
>>
>> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
>> index 73de4ef..944f500 100644
>> --- a/drivers/pci/Kconfig
>> +++ b/drivers/pci/Kconfig
>> @@ -2,7 +2,7 @@
>> # PCI configuration
>> #
>> config PCI_BUS_ADDR_T_64BIT
>> - def_bool y if (ARCH_DMA_ADDR_T_64BIT || 64BIT)
>> + def_bool y if (ARCH_DMA_ADDR_T_64BIT || (64BIT && !PARISC))
>> depends on PCI
>>
>> config PCI_MSI
>
> Yes, that is better.
>
> Acked-by: Yinghai Lu <yinghai@kernel.org>
Tested-by: Helge Deller <deller@gmx.de>
and please add:
CC: stable@vger.kernel.org # v3.19+
Helge
next prev parent reply other threads:[~2015-08-20 21:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-12 20:35 A500 boot crash in 4.2.0-rc3-00246-g763e326 Meelis Roos
2015-08-13 11:32 ` John David Anglin
2015-08-13 15:42 ` Meelis Roos
2015-08-13 16:49 ` John David Anglin
2015-08-14 6:35 ` Meelis Roos
2015-08-14 11:29 ` John David Anglin
2015-08-13 11:35 ` John David Anglin
2015-08-13 15:42 ` Meelis Roos
2015-08-17 14:06 ` Aw: " Helge Deller
2015-08-18 13:01 ` Helge Deller
2015-08-18 18:44 ` Meelis Roos
2015-08-18 18:44 ` Meelis Roos
2015-08-18 19:47 ` Helge Deller
2015-08-18 19:47 ` Helge Deller
2015-08-18 21:24 ` Yinghai Lu
2015-08-18 21:24 ` Yinghai Lu
2015-08-19 4:48 ` Meelis Roos
2015-08-19 4:48 ` Meelis Roos
2015-08-19 5:30 ` Yinghai Lu
2015-08-19 5:30 ` Yinghai Lu
2015-08-19 11:25 ` John David Anglin
2015-08-19 11:25 ` John David Anglin
2015-08-19 14:06 ` Aw: " Helge Deller
2015-08-19 14:06 ` Helge Deller
2015-08-20 5:42 ` Bjorn Helgaas
2015-08-20 5:42 ` Bjorn Helgaas
2015-08-20 6:53 ` Helge Deller
2015-08-20 6:53 ` Helge Deller
2015-08-20 19:31 ` Yinghai Lu
2015-08-20 19:31 ` Yinghai Lu
2015-08-20 21:15 ` Helge Deller [this message]
2015-08-20 21:15 ` Helge Deller
2015-08-20 21:30 ` Bjorn Helgaas
2015-08-20 21:30 ` Bjorn Helgaas
2015-08-19 10:40 ` Aw: " Meelis Roos
2015-08-19 10:40 ` Meelis Roos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55D6435A.9060808@gmx.de \
--to=deller@gmx.de \
--cc=James.Bottomley@hansenpartnership.com \
--cc=bhelgaas@google.com \
--cc=dave.anglin@bell.net \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mroos@linux.ee \
--cc=sparclinux@vger.kernel.org \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.