All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Cc: robh+dt@kernel.org, mturquette@baylibre.com,
	lee.jones@linaro.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice
Date: Tue, 25 Aug 2015 14:01:02 +0530	[thread overview]
Message-ID: <55DC27C6.3020500@linaro.org> (raw)
In-Reply-To: <55DBFC40.3010603@samsung.com>



On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote:
> On 25.08.2015 03:56, Vaibhav Hiremath wrote:
>> This patch adds mfd_cell/clk-subdevice for 88PM800 MFD
>> (and family of devices).
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   drivers/mfd/88pm800.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
>> index c4e097d..a928eed 100644
>> --- a/drivers/mfd/88pm800.c
>> +++ b/drivers/mfd/88pm800.c
>> @@ -173,6 +173,14 @@ static const struct mfd_cell regulator_devs[] = {
>>   	},
>>   };
>>
>> +static struct mfd_cell clk_devs[] = {
>> +	{
>> +		.name = "88pm80x-clk",
>> +		.of_compatible = "marvell,88pm800-clk",
>> +		.id = -1,
>
> The "-1" here stands for PLATFORM_DEVID_NONE?
>

Yes,

But it is rarely used in the kernel. so was reluctant to use and
decided to follow existing implementation.

Thanks,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice
Date: Tue, 25 Aug 2015 14:01:02 +0530	[thread overview]
Message-ID: <55DC27C6.3020500@linaro.org> (raw)
In-Reply-To: <55DBFC40.3010603@samsung.com>



On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote:
> On 25.08.2015 03:56, Vaibhav Hiremath wrote:
>> This patch adds mfd_cell/clk-subdevice for 88PM800 MFD
>> (and family of devices).
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   drivers/mfd/88pm800.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
>> index c4e097d..a928eed 100644
>> --- a/drivers/mfd/88pm800.c
>> +++ b/drivers/mfd/88pm800.c
>> @@ -173,6 +173,14 @@ static const struct mfd_cell regulator_devs[] = {
>>   	},
>>   };
>>
>> +static struct mfd_cell clk_devs[] = {
>> +	{
>> +		.name = "88pm80x-clk",
>> +		.of_compatible = "marvell,88pm800-clk",
>> +		.id = -1,
>
> The "-1" here stands for PLATFORM_DEVID_NONE?
>

Yes,

But it is rarely used in the kernel. so was reluctant to use and
decided to follow existing implementation.

Thanks,
Vaibhav

WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
	linux-arm-kernel@lists.infradead.org
Cc: devicetree@vger.kernel.org, mturquette@baylibre.com,
	linux-kernel@vger.kernel.org, robh+dt@kernel.org,
	lee.jones@linaro.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice
Date: Tue, 25 Aug 2015 14:01:02 +0530	[thread overview]
Message-ID: <55DC27C6.3020500@linaro.org> (raw)
In-Reply-To: <55DBFC40.3010603@samsung.com>



On Tuesday 25 August 2015 10:55 AM, Krzysztof Kozlowski wrote:
> On 25.08.2015 03:56, Vaibhav Hiremath wrote:
>> This patch adds mfd_cell/clk-subdevice for 88PM800 MFD
>> (and family of devices).
>>
>> Signed-off-by: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
>> ---
>>   drivers/mfd/88pm800.c | 25 +++++++++++++++++++++++++
>>   1 file changed, 25 insertions(+)
>>
>> diff --git a/drivers/mfd/88pm800.c b/drivers/mfd/88pm800.c
>> index c4e097d..a928eed 100644
>> --- a/drivers/mfd/88pm800.c
>> +++ b/drivers/mfd/88pm800.c
>> @@ -173,6 +173,14 @@ static const struct mfd_cell regulator_devs[] = {
>>   	},
>>   };
>>
>> +static struct mfd_cell clk_devs[] = {
>> +	{
>> +		.name = "88pm80x-clk",
>> +		.of_compatible = "marvell,88pm800-clk",
>> +		.id = -1,
>
> The "-1" here stands for PLATFORM_DEVID_NONE?
>

Yes,

But it is rarely used in the kernel. so was reluctant to use and
decided to follow existing implementation.

Thanks,
Vaibhav

  parent reply	other threads:[~2015-08-25  8:31 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24 18:56 [PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  7:51   ` Lee Jones
2015-08-25  7:51     ` Lee Jones
2015-08-25  7:51     ` Lee Jones
2015-08-25  8:41     ` Vaibhav Hiremath
2015-08-25  8:41       ` Vaibhav Hiremath
2015-08-25  8:41       ` Vaibhav Hiremath
2015-08-25 10:30       ` Lee Jones
2015-08-25 10:30         ` Lee Jones
2015-08-25 10:49         ` Vaibhav Hiremath
2015-08-25 10:49           ` Vaibhav Hiremath
2015-08-25 10:49           ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  7:52   ` Lee Jones
2015-08-25  7:52     ` Lee Jones
2015-08-25  7:52     ` Lee Jones
2015-08-25  8:50     ` Vaibhav Hiremath
2015-08-25  8:50       ` Vaibhav Hiremath
2015-08-25  8:50       ` Vaibhav Hiremath
2015-08-25 10:35       ` Lee Jones
2015-08-25 10:35         ` Lee Jones
2015-08-25 10:56         ` Vaibhav Hiremath
2015-08-25 10:56           ` Vaibhav Hiremath
2015-08-25 10:56           ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  7:55   ` Lee Jones
2015-08-25  7:55     ` Lee Jones
2015-08-25  7:55     ` Lee Jones
2015-08-25  8:45     ` Vaibhav Hiremath
2015-08-25  8:45       ` Vaibhav Hiremath
2015-08-25  8:45       ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  7:58   ` Lee Jones
2015-08-25  7:58     ` Lee Jones
2015-08-25  7:58     ` Lee Jones
2015-08-25  8:51     ` Vaibhav Hiremath
2015-08-25  8:51       ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  5:08   ` Krzysztof Kozlowski
2015-08-25  5:08     ` Krzysztof Kozlowski
2015-08-25  5:08     ` Krzysztof Kozlowski
2015-08-24 18:56 ` [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice Vaibhav Hiremath
2015-08-24 18:56   ` Vaibhav Hiremath
2015-08-25  5:25   ` Krzysztof Kozlowski
2015-08-25  5:25     ` Krzysztof Kozlowski
2015-08-25  7:49     ` Lee Jones
2015-08-25  7:49       ` Lee Jones
2015-08-25  7:49       ` Lee Jones
2015-08-25  8:38       ` Vaibhav Hiremath
2015-08-25  8:38         ` Vaibhav Hiremath
2015-08-25  8:38         ` Vaibhav Hiremath
2015-08-25  8:31     ` Vaibhav Hiremath [this message]
2015-08-25  8:31       ` Vaibhav Hiremath
2015-08-25  8:31       ` Vaibhav Hiremath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DC27C6.3020500@linaro.org \
    --to=vaibhav.hiremath@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=k.kozlowski@samsung.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.