From: Vaibhav Hiremath <vaibhav.hiremath@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
mturquette@baylibre.com, k.kozlowski@samsung.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org
Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue
Date: Tue, 25 Aug 2015 16:19:18 +0530 [thread overview]
Message-ID: <55DC482E.8030206@linaro.org> (raw)
In-Reply-To: <20150825103019.GP19409@x1>
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>> On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote:
>>> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>>>
>>>> Driver had coding style issues where spaces were used instead
>>>> of tabs. This patch fixes them all.
>>>
>>> That's not all it's doing though is it?
>>>
>>
>> Yes, its just tabbing related fixes.
>
> No, it's really not.
>
>>> Please describe all of your changes.
>
> ... we're also taking the opportunity to remove the unnecessary
> protection surrounding some of the defined values.
>
Ohhh ok. Forgot about brackets :)
Anyway,
Based on the comments you provided, I think both header file and
source file needs some more cleanup.
I will try to incorporate all changes in next version.
I may also submit separate series for cleanup version (depends on
patches I produce).
Thanks,
Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: vaibhav.hiremath@linaro.org (Vaibhav Hiremath)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue
Date: Tue, 25 Aug 2015 16:19:18 +0530 [thread overview]
Message-ID: <55DC482E.8030206@linaro.org> (raw)
In-Reply-To: <20150825103019.GP19409@x1>
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>> On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote:
>>> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>>>
>>>> Driver had coding style issues where spaces were used instead
>>>> of tabs. This patch fixes them all.
>>>
>>> That's not all it's doing though is it?
>>>
>>
>> Yes, its just tabbing related fixes.
>
> No, it's really not.
>
>>> Please describe all of your changes.
>
> ... we're also taking the opportunity to remove the unnecessary
> protection surrounding some of the defined values.
>
Ohhh ok. Forgot about brackets :)
Anyway,
Based on the comments you provided, I think both header file and
source file needs some more cleanup.
I will try to incorporate all changes in next version.
I may also submit separate series for cleanup version (depends on
patches I produce).
Thanks,
Vaibhav
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Hiremath <vaibhav.hiremath-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org,
k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue
Date: Tue, 25 Aug 2015 16:19:18 +0530 [thread overview]
Message-ID: <55DC482E.8030206@linaro.org> (raw)
In-Reply-To: <20150825103019.GP19409@x1>
On Tuesday 25 August 2015 04:00 PM, Lee Jones wrote:
> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>> On Tuesday 25 August 2015 01:21 PM, Lee Jones wrote:
>>> On Tue, 25 Aug 2015, Vaibhav Hiremath wrote:
>>>
>>>> Driver had coding style issues where spaces were used instead
>>>> of tabs. This patch fixes them all.
>>>
>>> That's not all it's doing though is it?
>>>
>>
>> Yes, its just tabbing related fixes.
>
> No, it's really not.
>
>>> Please describe all of your changes.
>
> ... we're also taking the opportunity to remove the unnecessary
> protection surrounding some of the defined values.
>
Ohhh ok. Forgot about brackets :)
Anyway,
Based on the comments you provided, I think both header file and
source file needs some more cleanup.
I will try to incorporate all changes in next version.
I may also submit separate series for cleanup version (depends on
patches I produce).
Thanks,
Vaibhav
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-08-25 10:49 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-24 18:56 [PATCH-v2 0/5] clk: 88pm800: Add new clk provider driver for 88PM800 MFD Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 1/5] mfd: 88pm800: Fix tabbing issue Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 7:51 ` Lee Jones
2015-08-25 7:51 ` Lee Jones
2015-08-25 7:51 ` Lee Jones
2015-08-25 8:41 ` Vaibhav Hiremath
2015-08-25 8:41 ` Vaibhav Hiremath
2015-08-25 8:41 ` Vaibhav Hiremath
2015-08-25 10:30 ` Lee Jones
2015-08-25 10:30 ` Lee Jones
2015-08-25 10:49 ` Vaibhav Hiremath [this message]
2015-08-25 10:49 ` Vaibhav Hiremath
2015-08-25 10:49 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 7:52 ` Lee Jones
2015-08-25 7:52 ` Lee Jones
2015-08-25 7:52 ` Lee Jones
2015-08-25 8:50 ` Vaibhav Hiremath
2015-08-25 8:50 ` Vaibhav Hiremath
2015-08-25 8:50 ` Vaibhav Hiremath
2015-08-25 10:35 ` Lee Jones
2015-08-25 10:35 ` Lee Jones
2015-08-25 10:56 ` Vaibhav Hiremath
2015-08-25 10:56 ` Vaibhav Hiremath
2015-08-25 10:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 2/5] mfd: 88pm800: Update the header file with 32K clk related macros Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 7:55 ` Lee Jones
2015-08-25 7:55 ` Lee Jones
2015-08-25 7:55 ` Lee Jones
2015-08-25 8:45 ` Vaibhav Hiremath
2015-08-25 8:45 ` Vaibhav Hiremath
2015-08-25 8:45 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 3/5] mfd: devicetree: bindings: Add clock subdevice node information Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 7:58 ` Lee Jones
2015-08-25 7:58 ` Lee Jones
2015-08-25 7:58 ` Lee Jones
2015-08-25 8:51 ` Vaibhav Hiremath
2015-08-25 8:51 ` Vaibhav Hiremath
2015-08-24 18:56 ` [PATCH-v2 4/5] clk: 88pm800: Add clk provider driver for 88pm800 family of devices Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 5:08 ` Krzysztof Kozlowski
2015-08-25 5:08 ` Krzysztof Kozlowski
2015-08-25 5:08 ` Krzysztof Kozlowski
2015-08-24 18:56 ` [PATCH-v2 5/5] mfd: 88pm800: Add support for clk subdevice Vaibhav Hiremath
2015-08-24 18:56 ` Vaibhav Hiremath
2015-08-25 5:25 ` Krzysztof Kozlowski
2015-08-25 5:25 ` Krzysztof Kozlowski
2015-08-25 7:49 ` Lee Jones
2015-08-25 7:49 ` Lee Jones
2015-08-25 7:49 ` Lee Jones
2015-08-25 8:38 ` Vaibhav Hiremath
2015-08-25 8:38 ` Vaibhav Hiremath
2015-08-25 8:38 ` Vaibhav Hiremath
2015-08-25 8:31 ` Vaibhav Hiremath
2015-08-25 8:31 ` Vaibhav Hiremath
2015-08-25 8:31 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DC482E.8030206@linaro.org \
--to=vaibhav.hiremath@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.