From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Kris Borer <kborer@gmail.com>, gregkh@linuxfoundation.org
Cc: stefan.koch10@gmail.com, lkml14@scotdoyle.com,
stern@rowland.harvard.edu, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: message: remove redundant declaration
Date: Wed, 26 Aug 2015 00:12:41 +0300 [thread overview]
Message-ID: <55DCDA49.9040308@cogentembedded.com> (raw)
In-Reply-To: <1440469808-3505-1-git-send-email-kborer@gmail.com>
Hello.
On 08/25/2015 05:30 AM, Kris Borer wrote:
> Fix the Sparse warning:
>
> message.c:1390:21: warning: symbol 'i' shadows an earlier one
> message.c:1294:13: originally declared here
>
> Signed-off-by: Kris Borer <kborer@gmail.com>
> ---
> drivers/usb/core/message.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index f368d20..e83648d 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
> * new altsetting.
> */
> if (manual) {
> - int i;
>
Why not remove (now unneeded) empty line?
> for (i = 0; i < alt->desc.bNumEndpoints; i++) {
> epaddr = alt->endpoint[i].desc.bEndpointAddress;
MBR, Sergei
prev parent reply other threads:[~2015-08-25 21:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 2:30 [PATCH] usb: message: remove redundant declaration Kris Borer
2015-08-25 21:12 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DCDA49.9040308@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=gregkh@linuxfoundation.org \
--cc=kborer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkml14@scotdoyle.com \
--cc=stefan.koch10@gmail.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.