* [PATCH] usb: message: remove redundant declaration
@ 2015-08-25 2:30 Kris Borer
2015-08-25 21:12 ` Sergei Shtylyov
0 siblings, 1 reply; 2+ messages in thread
From: Kris Borer @ 2015-08-25 2:30 UTC (permalink / raw)
To: gregkh; +Cc: stefan.koch10, lkml14, stern, linux-usb, linux-kernel, Kris Borer
Fix the Sparse warning:
message.c:1390:21: warning: symbol 'i' shadows an earlier one
message.c:1294:13: originally declared here
Signed-off-by: Kris Borer <kborer@gmail.com>
---
drivers/usb/core/message.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
index f368d20..e83648d 100644
--- a/drivers/usb/core/message.c
+++ b/drivers/usb/core/message.c
@@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
* new altsetting.
*/
if (manual) {
- int i;
for (i = 0; i < alt->desc.bNumEndpoints; i++) {
epaddr = alt->endpoint[i].desc.bEndpointAddress;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] usb: message: remove redundant declaration
2015-08-25 2:30 [PATCH] usb: message: remove redundant declaration Kris Borer
@ 2015-08-25 21:12 ` Sergei Shtylyov
0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2015-08-25 21:12 UTC (permalink / raw)
To: Kris Borer, gregkh; +Cc: stefan.koch10, lkml14, stern, linux-usb, linux-kernel
Hello.
On 08/25/2015 05:30 AM, Kris Borer wrote:
> Fix the Sparse warning:
>
> message.c:1390:21: warning: symbol 'i' shadows an earlier one
> message.c:1294:13: originally declared here
>
> Signed-off-by: Kris Borer <kborer@gmail.com>
> ---
> drivers/usb/core/message.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/core/message.c b/drivers/usb/core/message.c
> index f368d20..e83648d 100644
> --- a/drivers/usb/core/message.c
> +++ b/drivers/usb/core/message.c
> @@ -1387,7 +1387,6 @@ int usb_set_interface(struct usb_device *dev, int interface, int alternate)
> * new altsetting.
> */
> if (manual) {
> - int i;
>
Why not remove (now unneeded) empty line?
> for (i = 0; i < alt->desc.bNumEndpoints; i++) {
> epaddr = alt->endpoint[i].desc.bEndpointAddress;
MBR, Sergei
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-25 21:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-25 2:30 [PATCH] usb: message: remove redundant declaration Kris Borer
2015-08-25 21:12 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.