From: "Denis V. Lunev" <den-lists@parallels.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: QEMU <qemu-devel@nongnu.org>, Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function
Date: Wed, 26 Aug 2015 21:23:12 +0300 [thread overview]
Message-ID: <55DE0410.3040800@parallels.com> (raw)
In-Reply-To: <CAJ+F1C+avAbk-Gtt17orUVbQpX-WAp6aVCPf_dPsgDyjqNfk2g@mail.gmail.com>
On 08/26/2015 09:07 PM, Marc-André Lureau wrote:
> Hi
>
> On Wed, Aug 26, 2015 at 7:55 PM, Denis V. Lunev <den-lists@parallels.com> wrote:
>> it would be much better to declare this helper as "split_list(const gchar
>> *str, ...
>> and make temporary copy of parameter inside. Without this the function
>> as NASTY side-effect and trashes the string passed in.
>> Also it is rather reinvents strtok wheel.
> Yep, notice I didn't change the code, merely moved it.
I think that this side effect is visible if the code remains in place
and becomes invisible since you move it to the function.
This could create problem if somebody will reuse this call.
>> you can also use g_strsplit at your convenience, but may be this is overkill
> But it doesn't return a glist. So while I agree with you in general,
> that wasn't my goal to change this code, but just to be able to reuse
> it.
>
> thanks
>
next prev parent reply other threads:[~2015-08-26 18:23 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-26 10:05 [Qemu-devel] [PATCH v3 00/12] qemu-ga: add a configuration file marcandre.lureau
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 01/12] qga: misc spelling marcandre.lureau
2015-08-26 17:40 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 02/12] qga: use exit() when parsing options marcandre.lureau
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 03/12] qga: move string split in separate function marcandre.lureau
2015-08-26 17:55 ` Denis V. Lunev
2015-08-26 18:07 ` Marc-André Lureau
2015-08-26 18:23 ` Denis V. Lunev [this message]
2015-08-26 18:30 ` Marc-André Lureau
2015-08-26 18:33 ` Marc-André Lureau
2015-08-26 18:44 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 04/12] qga: rename 'path' to 'channel_path' marcandre.lureau
2015-08-26 17:56 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings marcandre.lureau
2015-08-26 18:09 ` Denis V. Lunev
2015-08-26 18:17 ` Marc-André Lureau
2015-08-26 18:27 ` Denis V. Lunev
2015-08-26 18:41 ` Marc-André Lureau
2015-08-26 18:49 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 06/12] qga: move option parsing to separate function marcandre.lureau
2015-08-26 18:11 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 07/12] qga: fill default options in main() marcandre.lureau
2015-08-26 18:14 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 08/12] qga: move agent run in a separate function marcandre.lureau
2015-08-26 18:32 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 09/12] qga: free a bit more marcandre.lureau
2015-08-26 18:35 ` Denis V. Lunev
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 10/12] qga: add an optionnal qemu-ga.conf system configuration marcandre.lureau
2015-08-26 12:55 ` Eric Blake
2015-08-26 15:11 ` Marc-André Lureau
2015-08-26 15:17 ` Michael Roth
2015-08-26 18:41 ` Denis V. Lunev
2015-08-26 18:45 ` Marc-André Lureau
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 11/12] qga: add --dump-conf option marcandre.lureau
2015-08-26 19:00 ` Denis V. Lunev
2015-08-26 19:03 ` Marc-André Lureau
2015-08-26 10:05 ` [Qemu-devel] [PATCH v3 12/12] qga: start a man page marcandre.lureau
2015-08-26 19:08 ` Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DE0410.3040800@parallels.com \
--to=den-lists@parallels.com \
--cc=marcandre.lureau@gmail.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.