Re: [Qemu-devel] [PATCH v3 05/12] qga: copy argument strings

["Denis V. Lunev" <den-lists@parallels.com>]

On 08/26/2015 09:41 PM, Marc-André Lureau wrote:
> On Wed, Aug 26, 2015 at 8:27 PM, Denis V. Lunev <den-lists@parallels.com> wrote:
>> lets consider this patch. You have done 2 things:
>> - changed initialisation order and dropped nasty temporary variables
>> - introduced alloc/free code
>>
>> But in the next patch each line with alloc/free code
>> will be changed due to variable rename and
>> moving to the separate function (free), which
>> IMHO means that this preparatory step is unnecessary,
>> you will make almost same changes in the next
>> patch
> to me this patch is a preparatory cleanup, having variable initialized
> to NULL, string allocated, and free. The nice side effect is that we
> can get rid of the weird fixed_state_dir stuff.
>
>> Thus the sum of changes in this patch/next patch
>> would be less with uncovering initialization
>> change details, which are missed in the patch
>> description
> I agree I can complete the commit description, but I think it's best
> to keep this preparatory cleanup.
>
yep. This is good to me.