From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Joseph Myers <joseph@codesourcery.com>,
Mike Frysinger <vapier@gentoo.org>
Cc: <libc-alpha@sourceware.org>, <linux-mips@linux-mips.org>
Subject: Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]
Date: Thu, 27 Aug 2015 09:00:57 +0100 [thread overview]
Message-ID: <55DEC3B9.1070105@imgtec.com> (raw)
In-Reply-To: <20150826171017.GD3116@vapier>
On 08/26/2015 06:10 PM, Mike Frysinger wrote:
> On 26 Aug 2015 09:30, Joseph Myers wrote:
>> On Wed, 26 Aug 2015, Mike Frysinger wrote:
>>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
>>> keep in sync with it.
>>>
>>> 2015-08-25 Mike Frysinger <vapier@gentoo.org>
>>>
>>> [BZ #18863]
>>> * sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
>>> (si_call_addr): Define.
>>> (si_syscall): Define.
>>> (si_arch): Define.
>>
>> OK. CC to linux-mips because I see that the MIPS implementation of
>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so
>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
>
> i'm getting reports of seccomp misbehavior on mips already which is what
> started me down this glibc path. i suspect the original port was tested
> against o32 kernels only.
> -mike
>
I have recently tested mips64 n64/n32 with the testsuite from libseccomp
and that led me to this fix
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
if you are aware of other problems (and perhaps a test to trigger them)
that could be kernel related let me know
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: Joseph Myers <joseph@codesourcery.com>,
Mike Frysinger <vapier@gentoo.org>
Cc: libc-alpha@sourceware.org, linux-mips@linux-mips.org
Subject: Re: [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863]
Date: Thu, 27 Aug 2015 09:00:57 +0100 [thread overview]
Message-ID: <55DEC3B9.1070105@imgtec.com> (raw)
Message-ID: <20150827080057.3y4g1CfHf6_7vZfebn75qE7tjDKLNDB9wuoiLT76reE@z> (raw)
In-Reply-To: <20150826171017.GD3116@vapier>
On 08/26/2015 06:10 PM, Mike Frysinger wrote:
> On 26 Aug 2015 09:30, Joseph Myers wrote:
>> On Wed, 26 Aug 2015, Mike Frysinger wrote:
>>> Linux 3.13 added SIGSYS details to siginfo_t; update glibc's copy to
>>> keep in sync with it.
>>>
>>> 2015-08-25 Mike Frysinger <vapier@gentoo.org>
>>>
>>> [BZ #18863]
>>> * sysdeps/unix/sysv/linux/mips/bits/siginfo.h (siginfo_t): Add _sigsys.
>>> (si_call_addr): Define.
>>> (si_syscall): Define.
>>> (si_arch): Define.
>>
>> OK. CC to linux-mips because I see that the MIPS implementation of
>> copy_siginfo_to_user32 doesn't handle __SI_SYS, unlike arm64 at least, so
>> I suspect this won't in fact work for n32 or for o32 with a 64-bit kernel.
>
> i'm getting reports of seccomp misbehavior on mips already which is what
> started me down this glibc path. i suspect the original port was tested
> against o32 kernels only.
> -mike
>
I have recently tested mips64 n64/n32 with the testsuite from libseccomp
and that led me to this fix
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=9f161439e4104b641a7bfb9b89581d801159fec8
if you are aware of other problems (and perhaps a test to trigger them)
that could be kernel related let me know
--
markos
next prev parent reply other threads:[~2015-08-27 8:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1440563342-5411-1-git-send-email-vapier@gentoo.org>
2015-08-26 9:30 ` [PATCH] mips: siginfo.h: add SIGSYS details [BZ #18863] Joseph Myers
2015-08-26 9:30 ` Joseph Myers
2015-08-26 17:10 ` Mike Frysinger
2015-08-27 8:00 ` Markos Chandras [this message]
2015-08-27 8:00 ` Markos Chandras
2015-08-27 9:41 ` Joseph Myers
2015-08-27 9:41 ` Joseph Myers
2015-08-27 9:56 ` Markos Chandras
2015-08-27 9:56 ` Markos Chandras
2015-08-27 22:09 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55DEC3B9.1070105@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-mips@linux-mips.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.