* [rtc-linux] [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-27 10:34 ` Javier Martinez Canillas
0 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 10:34 UTC (permalink / raw)
To: linux-kernel
Cc: Luis de Bethencourt, Javier Martinez Canillas, linux-samsung-soc,
Alessandro Zummo, Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
These platform drivers have a platform device ID table but the module
alias information is not created so module autoloading will not work.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/rtc/rtc-ab8500.c | 1 +
drivers/rtc/rtc-max8997.c | 1 +
drivers/rtc/rtc-s5m.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 133d2e2e1a25..8537d1e3a995 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
{ "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
{ "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
};
+MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
static int ab8500_rtc_probe(struct platform_device *pdev)
{
diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
index 9e02bcda0c09..db984d4bf952 100644
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -521,6 +521,7 @@ static const struct platform_device_id rtc_id[] = {
{ "max8997-rtc", 0 },
{},
};
+MODULE_DEVICE_TABLE(platform, rtc_id);
static struct platform_driver max8997_rtc_driver = {
.driver = {
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index ab60287ee72d..f2504b4eef34 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -807,6 +807,7 @@ static const struct platform_device_id s5m_rtc_id[] = {
{ "s2mps14-rtc", S2MPS14X },
{ },
};
+MODULE_DEVICE_TABLE(platform, s5m_rtc_id);
static struct platform_driver s5m_rtc_driver = {
.driver = {
--
2.4.3
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-27 10:34 ` Javier Martinez Canillas
0 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 10:34 UTC (permalink / raw)
To: linux-kernel
Cc: Luis de Bethencourt, Javier Martinez Canillas, linux-samsung-soc,
Alessandro Zummo, Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
These platform drivers have a platform device ID table but the module
alias information is not created so module autoloading will not work.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/rtc/rtc-ab8500.c | 1 +
drivers/rtc/rtc-max8997.c | 1 +
drivers/rtc/rtc-s5m.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 133d2e2e1a25..8537d1e3a995 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
{ "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
{ "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
};
+MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
static int ab8500_rtc_probe(struct platform_device *pdev)
{
diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
index 9e02bcda0c09..db984d4bf952 100644
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -521,6 +521,7 @@ static const struct platform_device_id rtc_id[] = {
{ "max8997-rtc", 0 },
{},
};
+MODULE_DEVICE_TABLE(platform, rtc_id);
static struct platform_driver max8997_rtc_driver = {
.driver = {
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index ab60287ee72d..f2504b4eef34 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -807,6 +807,7 @@ static const struct platform_device_id s5m_rtc_id[] = {
{ "s2mps14-rtc", S2MPS14X },
{ },
};
+MODULE_DEVICE_TABLE(platform, s5m_rtc_id);
static struct platform_driver s5m_rtc_driver = {
.driver = {
--
2.4.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500, max8997, s5m} drivers
@ 2015-08-27 10:34 ` Javier Martinez Canillas
0 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 10:34 UTC (permalink / raw)
To: linux-arm-kernel
These platform drivers have a platform device ID table but the module
alias information is not created so module autoloading will not work.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/rtc/rtc-ab8500.c | 1 +
drivers/rtc/rtc-max8997.c | 1 +
drivers/rtc/rtc-s5m.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
index 133d2e2e1a25..8537d1e3a995 100644
--- a/drivers/rtc/rtc-ab8500.c
+++ b/drivers/rtc/rtc-ab8500.c
@@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
{ "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
{ "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
};
+MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
static int ab8500_rtc_probe(struct platform_device *pdev)
{
diff --git a/drivers/rtc/rtc-max8997.c b/drivers/rtc/rtc-max8997.c
index 9e02bcda0c09..db984d4bf952 100644
--- a/drivers/rtc/rtc-max8997.c
+++ b/drivers/rtc/rtc-max8997.c
@@ -521,6 +521,7 @@ static const struct platform_device_id rtc_id[] = {
{ "max8997-rtc", 0 },
{},
};
+MODULE_DEVICE_TABLE(platform, rtc_id);
static struct platform_driver max8997_rtc_driver = {
.driver = {
diff --git a/drivers/rtc/rtc-s5m.c b/drivers/rtc/rtc-s5m.c
index ab60287ee72d..f2504b4eef34 100644
--- a/drivers/rtc/rtc-s5m.c
+++ b/drivers/rtc/rtc-s5m.c
@@ -807,6 +807,7 @@ static const struct platform_device_id s5m_rtc_id[] = {
{ "s2mps14-rtc", S2MPS14X },
{ },
};
+MODULE_DEVICE_TABLE(platform, s5m_rtc_id);
static struct platform_driver s5m_rtc_driver = {
.driver = {
--
2.4.3
^ permalink raw reply related [flat|nested] 15+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
2015-08-27 10:34 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Javier Martinez Canillas
(?)
@ 2015-08-27 12:20 ` Andrey Ryabinin
-1 siblings, 0 replies; 15+ messages in thread
From: Andrey Ryabinin @ 2015-08-27 12:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: LKML, Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 133d2e2e1a25..8537d1e3a995 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
Completely irrelevant, but this array should have an empty terminating element.
> };
> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-27 12:20 ` Andrey Ryabinin
0 siblings, 0 replies; 15+ messages in thread
From: Andrey Ryabinin @ 2015-08-27 12:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: LKML, Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 133d2e2e1a25..8537d1e3a995 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
Completely irrelevant, but this array should have an empty terminating element.
> };
> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500, max8997, s5m} drivers
@ 2015-08-27 12:20 ` Andrey Ryabinin
0 siblings, 0 replies; 15+ messages in thread
From: Andrey Ryabinin @ 2015-08-27 12:20 UTC (permalink / raw)
To: linux-arm-kernel
2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
> index 133d2e2e1a25..8537d1e3a995 100644
> --- a/drivers/rtc/rtc-ab8500.c
> +++ b/drivers/rtc/rtc-ab8500.c
> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
Completely irrelevant, but this array should have an empty terminating element.
> };
> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>
^ permalink raw reply [flat|nested] 15+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
2015-08-27 12:20 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Andrey Ryabinin
(?)
@ 2015-08-27 12:23 ` Javier Martinez Canillas
-1 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 12:23 UTC (permalink / raw)
To: Andrey Ryabinin
Cc: LKML, Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
Hello Andrey,
On 08/27/2015 02:20 PM, Andrey Ryabinin wrote:
> 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
>> These platform drivers have a platform device ID table but the module
>> alias information is not created so module autoloading will not work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> drivers/rtc/rtc-ab8500.c | 1 +
>> drivers/rtc/rtc-max8997.c | 1 +
>> drivers/rtc/rtc-s5m.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
>> index 133d2e2e1a25..8537d1e3a995 100644
>> --- a/drivers/rtc/rtc-ab8500.c
>> +++ b/drivers/rtc/rtc-ab8500.c
>> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
>> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
>> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
>
> Completely irrelevant, but this array should have an empty terminating element.
>
You are right, it's missing a sentinel indeed. But
that change should be done in a separate patch.
>> };
>> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-27 12:23 ` Javier Martinez Canillas
0 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 12:23 UTC (permalink / raw)
To: Andrey Ryabinin
Cc: LKML, Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
Hello Andrey,
On 08/27/2015 02:20 PM, Andrey Ryabinin wrote:
> 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
>> These platform drivers have a platform device ID table but the module
>> alias information is not created so module autoloading will not work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> drivers/rtc/rtc-ab8500.c | 1 +
>> drivers/rtc/rtc-max8997.c | 1 +
>> drivers/rtc/rtc-s5m.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
>> index 133d2e2e1a25..8537d1e3a995 100644
>> --- a/drivers/rtc/rtc-ab8500.c
>> +++ b/drivers/rtc/rtc-ab8500.c
>> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
>> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
>> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
>
> Completely irrelevant, but this array should have an empty terminating element.
>
You are right, it's missing a sentinel indeed. But
that change should be done in a separate patch.
>> };
>> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-27 12:23 ` Javier Martinez Canillas
0 siblings, 0 replies; 15+ messages in thread
From: Javier Martinez Canillas @ 2015-08-27 12:23 UTC (permalink / raw)
To: linux-arm-kernel
Hello Andrey,
On 08/27/2015 02:20 PM, Andrey Ryabinin wrote:
> 2015-08-27 13:34 GMT+03:00 Javier Martinez Canillas <javier@osg.samsung.com>:
>> These platform drivers have a platform device ID table but the module
>> alias information is not created so module autoloading will not work.
>>
>> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>>
>> ---
>>
>> drivers/rtc/rtc-ab8500.c | 1 +
>> drivers/rtc/rtc-max8997.c | 1 +
>> drivers/rtc/rtc-s5m.c | 1 +
>> 3 files changed, 3 insertions(+)
>>
>> diff --git a/drivers/rtc/rtc-ab8500.c b/drivers/rtc/rtc-ab8500.c
>> index 133d2e2e1a25..8537d1e3a995 100644
>> --- a/drivers/rtc/rtc-ab8500.c
>> +++ b/drivers/rtc/rtc-ab8500.c
>> @@ -446,6 +446,7 @@ static const struct platform_device_id ab85xx_rtc_ids[] = {
>> { "ab8500-rtc", (kernel_ulong_t)&ab8500_rtc_ops, },
>> { "ab8540-rtc", (kernel_ulong_t)&ab8540_rtc_ops, },
>
> Completely irrelevant, but this array should have an empty terminating element.
>
You are right, it's missing a sentinel indeed. But
that change should be done in a separate patch.
>> };
>> +MODULE_DEVICE_TABLE(platform, ab85xx_rtc_ids);
>>
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 15+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
2015-08-27 10:34 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Javier Martinez Canillas
(?)
@ 2015-08-28 0:27 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-28 0:27 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni, rtc-linux,
linux-arm-kernel
On 27.08.2015 19:34, Javier Martinez Canillas wrote:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Makes sense:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-28 0:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-28 0:27 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Luis de Bethencourt, linux-samsung-soc, Alessandro Zummo,
Sangbeom Kim, Linus Walleij, Alexandre Belloni, rtc-linux,
linux-arm-kernel
On 27.08.2015 19:34, Javier Martinez Canillas wrote:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Makes sense:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-28 0:27 ` Krzysztof Kozlowski
0 siblings, 0 replies; 15+ messages in thread
From: Krzysztof Kozlowski @ 2015-08-28 0:27 UTC (permalink / raw)
To: linux-arm-kernel
On 27.08.2015 19:34, Javier Martinez Canillas wrote:
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Makes sense:
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 15+ messages in thread
* [rtc-linux] Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
2015-08-27 10:34 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Javier Martinez Canillas
(?)
@ 2015-08-31 20:09 ` Alexandre Belloni
-1 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2015-08-31 20:09 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Luis de Bethencourt, linux-samsung-soc,
Alessandro Zummo, Sangbeom Kim, Linus Walleij,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
On 27/08/2015 at 12:34:32 +0200, Javier Martinez Canillas wrote :
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-31 20:09 ` Alexandre Belloni
0 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2015-08-31 20:09 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, Luis de Bethencourt, linux-samsung-soc,
Alessandro Zummo, Sangbeom Kim, Linus Walleij,
Krzysztof Kozlowski, rtc-linux, linux-arm-kernel
On 27/08/2015 at 12:34:32 +0200, Javier Martinez Canillas wrote :
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
* [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers
@ 2015-08-31 20:09 ` Alexandre Belloni
0 siblings, 0 replies; 15+ messages in thread
From: Alexandre Belloni @ 2015-08-31 20:09 UTC (permalink / raw)
To: linux-arm-kernel
On 27/08/2015 at 12:34:32 +0200, Javier Martinez Canillas wrote :
> These platform drivers have a platform device ID table but the module
> alias information is not created so module autoloading will not work.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/rtc/rtc-ab8500.c | 1 +
> drivers/rtc/rtc-max8997.c | 1 +
> drivers/rtc/rtc-s5m.c | 1 +
> 3 files changed, 3 insertions(+)
Applied, thanks.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2015-08-31 20:09 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-27 10:34 [rtc-linux] [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Javier Martinez Canillas
2015-08-27 10:34 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500, max8997, s5m} drivers Javier Martinez Canillas
2015-08-27 10:34 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Javier Martinez Canillas
2015-08-27 12:20 ` [rtc-linux] " Andrey Ryabinin
2015-08-27 12:20 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500, max8997, s5m} drivers Andrey Ryabinin
2015-08-27 12:20 ` [PATCH] rtc: Fix module autoload for rtc-{ab8500,max8997,s5m} drivers Andrey Ryabinin
2015-08-27 12:23 ` [rtc-linux] " Javier Martinez Canillas
2015-08-27 12:23 ` Javier Martinez Canillas
2015-08-27 12:23 ` Javier Martinez Canillas
2015-08-28 0:27 ` [rtc-linux] " Krzysztof Kozlowski
2015-08-28 0:27 ` Krzysztof Kozlowski
2015-08-28 0:27 ` Krzysztof Kozlowski
2015-08-31 20:09 ` [rtc-linux] " Alexandre Belloni
2015-08-31 20:09 ` Alexandre Belloni
2015-08-31 20:09 ` Alexandre Belloni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.