All of lore.kernel.org
 help / color / mirror / Atom feed
From: horia.geanta@freescale.com (Horia Geantă)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] ARM: configs: Add Freescale LS1021A defconfig
Date: Fri, 28 Aug 2015 11:50:29 +0300	[thread overview]
Message-ID: <55E020D5.4090201@freescale.com> (raw)
In-Reply-To: <BN3PR0301MB0867591B07957C47F30C9711FE6E0@BN3PR0301MB0867.namprd03.prod.outlook.com>

On 8/28/2015 11:04 AM, Wang Huan-B18965 wrote:
> Hi, Horia,
> 
>> On 8/17/2015 6:42 AM, Wang Huan-B18965 wrote:
>>> Hi, Fabio,
>>
>> Please don't top post.
>>
>>>
>>> 	Based on the analysis and discussion, we prefer to use
>> ls1021a_defconfig and remove LS1021A from imx_v6_v7_defconfig.
>>
>> Alison, when you submit v4 for this patch (adding
>> CONFIG_ARCH_DMA_ADDR_T_64BIT=y as suggested), could you also send a
>> patch removing CONFIG_SOC_LS1021A from imx_v6_v7_config?
> [Alison Wang] I don?t know CONFIG_ARCH_DMA_ADDR_T_64BIT=y is suggested.
> Could you help to explain the suggestion?

Please see
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/072446.html

Instead of having CONFIG_ARCH_DMA_ADDR_T_64BIT=y in the defconfig, I
guess selecting it from Kconfig makes more sense:

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 573536f1bb73..bb417e73af0f 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -563,6 +563,7 @@ config SOC_LS1021A
        select HAVE_ARM_ARCH_TIMER
        select PCI_DOMAINS if PCI
        select ZONE_DMA if ARM_LPAE
+       select ARCH_DMA_ADDR_T_64BIT
        help
          This enables support for Freescale LS1021A processor.

Horia

WARNING: multiple messages have this Message-ID (diff)
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Wang Huan-B18965 <alison.wang@freescale.com>,
	Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Estevam Fabio-R49496 <Fabio.Estevam@freescale.com>,
	Jin Zhengxiong-R64188 <Jason.Jin@freescale.com>
Subject: Re: [PATCH v3] ARM: configs: Add Freescale LS1021A defconfig
Date: Fri, 28 Aug 2015 11:50:29 +0300	[thread overview]
Message-ID: <55E020D5.4090201@freescale.com> (raw)
In-Reply-To: <BN3PR0301MB0867591B07957C47F30C9711FE6E0@BN3PR0301MB0867.namprd03.prod.outlook.com>

On 8/28/2015 11:04 AM, Wang Huan-B18965 wrote:
> Hi, Horia,
> 
>> On 8/17/2015 6:42 AM, Wang Huan-B18965 wrote:
>>> Hi, Fabio,
>>
>> Please don't top post.
>>
>>>
>>> 	Based on the analysis and discussion, we prefer to use
>> ls1021a_defconfig and remove LS1021A from imx_v6_v7_defconfig.
>>
>> Alison, when you submit v4 for this patch (adding
>> CONFIG_ARCH_DMA_ADDR_T_64BIT=y as suggested), could you also send a
>> patch removing CONFIG_SOC_LS1021A from imx_v6_v7_config?
> [Alison Wang] I don’t know CONFIG_ARCH_DMA_ADDR_T_64BIT=y is suggested.
> Could you help to explain the suggestion?

Please see
http://lists.infradead.org/pipermail/linux-arm-kernel/2011-November/072446.html

Instead of having CONFIG_ARCH_DMA_ADDR_T_64BIT=y in the defconfig, I
guess selecting it from Kconfig makes more sense:

diff --git a/arch/arm/mach-imx/Kconfig b/arch/arm/mach-imx/Kconfig
index 573536f1bb73..bb417e73af0f 100644
--- a/arch/arm/mach-imx/Kconfig
+++ b/arch/arm/mach-imx/Kconfig
@@ -563,6 +563,7 @@ config SOC_LS1021A
        select HAVE_ARM_ARCH_TIMER
        select PCI_DOMAINS if PCI
        select ZONE_DMA if ARM_LPAE
+       select ARCH_DMA_ADDR_T_64BIT
        help
          This enables support for Freescale LS1021A processor.

Horia


  reply	other threads:[~2015-08-28  8:50 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 10:03 [PATCH v3] ARM: configs: Add Freescale LS1021A defconfig Alison Wang
2015-08-07 10:03 ` Alison Wang
2015-08-12 13:20 ` Horia Geantă
2015-08-12 13:20   ` Horia Geantă
2015-08-14 17:06   ` Horia Geantă
2015-08-14 17:06     ` Horia Geantă
2015-08-14 17:28     ` Fabio Estevam
2015-08-14 17:28       ` Fabio Estevam
2015-08-17  3:42       ` Huan Wang
2015-08-17  3:42         ` Huan Wang
2015-08-20 16:58         ` Horia Geantă
2015-08-20 16:58           ` Horia Geantă
2015-08-28  8:04           ` Huan Wang
2015-08-28  8:04             ` Huan Wang
2015-08-28  8:50             ` Horia Geantă [this message]
2015-08-28  8:50               ` Horia Geantă
2015-08-28 16:54             ` Fabio Estevam
2015-08-28 16:54               ` Fabio Estevam
2015-09-16  8:22               ` Huan Wang
2015-09-16  8:22                 ` Huan Wang
2015-09-17  1:10                 ` Shawn Guo
2015-09-17  1:10                   ` Shawn Guo
2015-09-17  9:11                   ` Huan Wang
2015-09-17  9:11                     ` Huan Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55E020D5.4090201@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.