[PATCH] kvmtool Makefile: relax arm test

[PATCH] kvmtool Makefile: relax arm test

[riku.voipio]

From: Riku Voipio <riku.voipio@linaro.org>

Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
We expect doing 32bit arm builds in Aarch64 to become standard the same way
people do i386 builds on x86_64 machines.

Make the sed test a little more greedy so armv8l becomes acceptable.

Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 1534e6f..7b17d52 100644
--- a/Makefile
+++ b/Makefile
@@ -103,7 +103,7 @@ OBJS	+= hw/i8042.o
 
 # Translate uname -m into ARCH string
 ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \
-	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
+	  -e s/armv.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
 
 ifeq ($(ARCH),i386)
 	ARCH         := x86
-- 
2.4.6

Re: [PATCH] kvmtool Makefile: relax arm test

[Andre Przywara]

Hi Riku,

On 03/09/15 12:20, riku.voipio@linaro.org wrote:
> From: Riku Voipio <riku.voipio@linaro.org>
> 
> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
> We expect doing 32bit arm builds in Aarch64 to become standard the same way
> people do i386 builds on x86_64 machines.
> 
> Make the sed test a little more greedy so armv8l becomes acceptable.
> 
> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>

The patch looks OK to me, I just wonder how you do the actual build
within the linux32 environment?
Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
there a magic compiler (driver) which uses uname -m as well?
And what would be the difference to setting ARCH=arm as well? Just
convenience?

Cheers,
Andre.

> ---
>  Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Makefile b/Makefile
> index 1534e6f..7b17d52 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -103,7 +103,7 @@ OBJS	+= hw/i8042.o
>  
>  # Translate uname -m into ARCH string
>  ARCH ?= $(shell uname -m | sed -e s/i.86/i386/ -e s/ppc.*/powerpc/ \
> -	  -e s/armv7.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
> +	  -e s/armv.*/arm/ -e s/aarch64.*/arm64/ -e s/mips64/mips/)
>  
>  ifeq ($(ARCH),i386)
>  	ARCH         := x86
> 

Re: [PATCH] kvmtool Makefile: relax arm test

[Riku Voipio]

On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi Riku,
>
> On 03/09/15 12:20, riku.voipio@linaro.org wrote:
>> From: Riku Voipio <riku.voipio@linaro.org>
>>
>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
>> We expect doing 32bit arm builds in Aarch64 to become standard the same way
>> people do i386 builds on x86_64 machines.
>>
>> Make the sed test a little more greedy so armv8l becomes acceptable.
>>
>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>
> The patch looks OK to me, I just wonder how you do the actual build
> within the linux32 environment?
> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
> there a magic compiler (driver) which uses uname -m as well?
> And what would be the difference to setting ARCH=arm as well? Just
> convenience?

It's just an arm32 chroot, with an native arm32 compiler. The chroot
is on an arm64 machine since these tend to be much faster than arm32
hardware.

It would of course be possible to set ARCH=arm, but that would mean
some ifdefs in the Debian packaging, since the same build rule should
work for all architectures.

Riku

Re: [PATCH] kvmtool Makefile: relax arm test

[Andre Przywara]

Hi Riku,

On 04/09/15 11:52, Riku Voipio wrote:
> On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@arm.com> wrote:
>> Hi Riku,
>>
>> On 03/09/15 12:20, riku.voipio@linaro.org wrote:
>>> From: Riku Voipio <riku.voipio@linaro.org>
>>>
>>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
>>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
>>> We expect doing 32bit arm builds in Aarch64 to become standard the same way
>>> people do i386 builds on x86_64 machines.
>>>
>>> Make the sed test a little more greedy so armv8l becomes acceptable.
>>>
>>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>>
>> The patch looks OK to me, I just wonder how you do the actual build
>> within the linux32 environment?
>> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
>> there a magic compiler (driver) which uses uname -m as well?
>> And what would be the difference to setting ARCH=arm as well? Just
>> convenience?
> 
> It's just an arm32 chroot, with an native arm32 compiler. The chroot
> is on an arm64 machine since these tend to be much faster than arm32
> hardware.

Oh right, a chroot, didn't think about the obvious ;-)
Also it applies to 64-bit kernels with 32-bit root filesystems, I think.
So:

Acked-by: Andre Przywara <andre.przywara@arm.com>

Cheers,
Andre.

> 
> It would of course be possible to set ARCH=arm, but that would mean
> some ifdefs in the Debian packaging, since the same build rule should
> work for all architectures.
> 
> Riku
> 

Re: [PATCH] kvmtool Makefile: relax arm test

[Riku Voipio]

On 4 September 2015 at 14:06, Andre Przywara <andre.przywara@arm.com> wrote:
> Hi Riku,
>
> On 04/09/15 11:52, Riku Voipio wrote:
>> On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@arm.com> wrote:
>>> Hi Riku,
>>>
>>> On 03/09/15 12:20, riku.voipio@linaro.org wrote:
>>>> From: Riku Voipio <riku.voipio@linaro.org>
>>>>
>>>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
>>>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
>>>> We expect doing 32bit arm builds in Aarch64 to become standard the same way
>>>> people do i386 builds on x86_64 machines.
>>>>
>>>> Make the sed test a little more greedy so armv8l becomes acceptable.
>>>>
>>>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
>>>
>>> The patch looks OK to me, I just wonder how you do the actual build
>>> within the linux32 environment?
>>> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
>>> there a magic compiler (driver) which uses uname -m as well?
>>> And what would be the difference to setting ARCH=arm as well? Just
>>> convenience?
>>
>> It's just an arm32 chroot, with an native arm32 compiler. The chroot
>> is on an arm64 machine since these tend to be much faster than arm32
>> hardware.
>
> Oh right, a chroot, didn't think about the obvious ;-)
> Also it applies to 64-bit kernels with 32-bit root filesystems, I think.
> So:
>
> Acked-by: Andre Przywara <andre.przywara@arm.com>

Ping?

>>
>> It would of course be possible to set ARCH=arm, but that would mean
>> some ifdefs in the Debian packaging, since the same build rule should
>> work for all architectures.
>>
>> Riku
>>

Re: [PATCH] kvmtool Makefile: relax arm test

[Will Deacon]

On Thu, Sep 10, 2015 at 06:45:59AM +0100, Riku Voipio wrote:
> On 4 September 2015 at 14:06, Andre Przywara <andre.przywara@arm.com> wrote:
> > On 04/09/15 11:52, Riku Voipio wrote:
> >> On 4 September 2015 at 13:10, Andre Przywara <andre.przywara@arm.com> wrote:
> >>> On 03/09/15 12:20, riku.voipio@linaro.org wrote:
> >>>> From: Riku Voipio <riku.voipio@linaro.org>
> >>>>
> >>>> Currently Makefile accepts only armv7l.* When building kvmtool under 32bit
> >>>> personality on Aarch64 machines, uname -m reports "armv8l", so build fails.
> >>>> We expect doing 32bit arm builds in Aarch64 to become standard the same way
> >>>> people do i386 builds on x86_64 machines.
> >>>>
> >>>> Make the sed test a little more greedy so armv8l becomes acceptable.
> >>>>
> >>>> Signed-off-by: Riku Voipio <riku.voipio@linaro.org>
> >>>
> >>> The patch looks OK to me, I just wonder how you do the actual build
> >>> within the linux32 environment?
> >>> Do you have an arm cross compiler installed and set CROSS_COMPILE? Or is
> >>> there a magic compiler (driver) which uses uname -m as well?
> >>> And what would be the difference to setting ARCH=arm as well? Just
> >>> convenience?
> >>
> >> It's just an arm32 chroot, with an native arm32 compiler. The chroot
> >> is on an arm64 machine since these tend to be much faster than arm32
> >> hardware.
> >
> > Oh right, a chroot, didn't think about the obvious ;-)
> > Also it applies to 64-bit kernels with 32-bit root filesystems, I think.
> > So:
> >
> > Acked-by: Andre Przywara <andre.przywara@arm.com>
> 
> Ping?

Applied and pushed, thanks.

In future, it's best to Cc me if you want to make sure stuff doesn't
get missed :)

Cheers,

Will

Re: [PATCH] kvmtool Makefile: relax arm test

[Riku Voipio]

On 10 September 2015 at 13:30, Will Deacon <will.deacon@arm.com> wrote:
> On Thu, Sep 10, 2015 at 06:45:59AM +0100, Riku Voipio wrote:
>> Ping?

> Applied and pushed, thanks.

thanks

> In future, it's best to Cc me if you want to make sure stuff doesn't
> get missed :)

I just followed the CONTRIBUTING section from the README, maybe it
needs to be appended with the CC hint?

Riku