From: Jonathan Cameron <jic23@kernel.org>
To: Martin Kepplinger <martink@posteo.de>,
knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net,
mfuzzey@parkeon.com, roberta.dobrescu@gmail.com,
robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org
Cc: devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
christoph.muellner@theobroma-systems.com,
Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
Subject: Re: [PATCH 6/6] iio: mma8452: leave sysfs namings to the iio core
Date: Sat, 5 Sep 2015 18:07:33 +0100 [thread overview]
Message-ID: <55EB2155.7050305@kernel.org> (raw)
In-Reply-To: <1441107913-4112-7-git-send-email-martink@posteo.de>
On 01/09/15 12:45, Martin Kepplinger wrote:
> This doesn't actually change anything since the core names the sysfs folder
> for the iio event attributes "events" anyways. It only leaves the job to the
> core.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@theobroma-systems.com>
> Signed-off-by: Christoph Muellner <christoph.muellner@theobroma-systems.com>
Good point. I wonder if we have others of these in the tree.
Anyhow, an excellent patch set. As I've said, I'll pick them up in
perhaps a week if Peter or someone else hasn't intervened in the meantime.
Give me a poke if I don't seem to be doing so!
Jonathan
> ---
> drivers/iio/accel/mma8452.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 15d50c9..1eccc2d 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -772,7 +772,6 @@ static struct attribute *mma8452_event_attributes[] = {
>
> static struct attribute_group mma8452_event_attribute_group = {
> .attrs = mma8452_event_attributes,
> - .name = "events",
> };
>
> #define MMA8452_CHANNEL(axis, idx, bits) { \
>
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Martin Kepplinger
<martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>,
knaack.h-Mmb7MZpHnFY@public.gmane.org,
lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org,
pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org,
mfuzzey-mB3Nsq4MPf1BDgjK7y7TUQ@public.gmane.org,
roberta.dobrescu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org
Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org,
Martin Kepplinger
<martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
Subject: Re: [PATCH 6/6] iio: mma8452: leave sysfs namings to the iio core
Date: Sat, 5 Sep 2015 18:07:33 +0100 [thread overview]
Message-ID: <55EB2155.7050305@kernel.org> (raw)
In-Reply-To: <1441107913-4112-7-git-send-email-martink-1KBjaw7Xf1+zQB+pC5nmwQ@public.gmane.org>
On 01/09/15 12:45, Martin Kepplinger wrote:
> This doesn't actually change anything since the core names the sysfs folder
> for the iio event attributes "events" anyways. It only leaves the job to the
> core.
>
> Signed-off-by: Martin Kepplinger <martin.kepplinger-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
> Signed-off-by: Christoph Muellner <christoph.muellner-SN7IsUiht6C/RdPyistoZJqQE7yCjDx5@public.gmane.org>
Good point. I wonder if we have others of these in the tree.
Anyhow, an excellent patch set. As I've said, I'll pick them up in
perhaps a week if Peter or someone else hasn't intervened in the meantime.
Give me a poke if I don't seem to be doing so!
Jonathan
> ---
> drivers/iio/accel/mma8452.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/accel/mma8452.c b/drivers/iio/accel/mma8452.c
> index 15d50c9..1eccc2d 100644
> --- a/drivers/iio/accel/mma8452.c
> +++ b/drivers/iio/accel/mma8452.c
> @@ -772,7 +772,6 @@ static struct attribute *mma8452_event_attributes[] = {
>
> static struct attribute_group mma8452_event_attribute_group = {
> .attrs = mma8452_event_attributes,
> - .name = "events",
> };
>
> #define MMA8452_CHANNEL(axis, idx, bits) { \
>
next prev parent reply other threads:[~2015-09-05 17:07 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 11:45 [PATCHv6 0/6] iio: mma8452: improve driver and support more chips Martin Kepplinger
2015-09-01 11:45 ` Martin Kepplinger
2015-09-01 11:45 ` [PATCH 1/6] iio: mma8452: refactor for seperating chip specific data Martin Kepplinger
2015-09-05 16:52 ` Jonathan Cameron
2015-09-05 16:52 ` Jonathan Cameron
2015-09-12 10:07 ` Jonathan Cameron
2015-09-12 10:07 ` Jonathan Cameron
2015-09-01 11:45 ` [PATCH 2/6] iio: mma8452: add support for MMA8453Q accelerometer chip Martin Kepplinger
2015-09-05 16:56 ` Jonathan Cameron
2015-09-05 16:56 ` Jonathan Cameron
2015-09-12 10:07 ` Jonathan Cameron
2015-09-12 10:07 ` Jonathan Cameron
2015-09-01 11:45 ` [PATCH 3/6] iio: mma8452: add freefall / motion interrupt source Martin Kepplinger
2015-09-05 16:58 ` Jonathan Cameron
2015-09-05 16:58 ` Jonathan Cameron
2015-09-12 10:08 ` Jonathan Cameron
2015-09-12 10:08 ` Jonathan Cameron
2015-09-01 11:45 ` [PATCH 4/6] iio: mma8452: add support for MMA8652FC and MMA8653FC Martin Kepplinger
2015-09-01 11:45 ` Martin Kepplinger
2015-09-05 17:05 ` Jonathan Cameron
2015-09-05 17:05 ` Jonathan Cameron
2015-09-12 10:08 ` Jonathan Cameron
2015-09-12 10:08 ` Jonathan Cameron
2015-09-01 11:45 ` [PATCH 5/6] iio: mma8452: add copyright notice comment Martin Kepplinger
2015-09-01 11:45 ` Martin Kepplinger
2015-09-12 10:09 ` Jonathan Cameron
2015-09-12 10:09 ` Jonathan Cameron
2015-09-01 11:45 ` [PATCH 6/6] iio: mma8452: leave sysfs namings to the iio core Martin Kepplinger
2015-09-01 11:45 ` Martin Kepplinger
2015-09-05 17:07 ` Jonathan Cameron [this message]
2015-09-05 17:07 ` Jonathan Cameron
2015-09-12 10:09 ` Jonathan Cameron
2015-09-12 10:09 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EB2155.7050305@kernel.org \
--to=jic23@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.kepplinger@theobroma-systems.com \
--cc=martink@posteo.de \
--cc=mfuzzey@parkeon.com \
--cc=pawel.moll@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=roberta.dobrescu@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.