All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Nowicki <tn@semihalf.com>
To: Marc Zyngier <marc.zyngier@arm.com>,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	Len Brown <lenb@kernel.org>, Hanjun Guo <hanjun.guo@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Jason Cooper <jason@lakedaemon.net>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>
Cc: linaro-acpi@lists.linaro.org, linux-acpi@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/5] ACPI probing infrastructure
Date: Mon, 7 Sep 2015 08:58:33 +0200	[thread overview]
Message-ID: <55ED3599.5090508@semihalf.com> (raw)
In-Reply-To: <1441386412-8139-1-git-send-email-marc.zyngier@arm.com>

Hi Marc,

On 04.09.2015 19:06, Marc Zyngier wrote:
> IRQ controllers and timers are the two types of device the kernel
> requires before being able to use the device driver model.
>
> ACPI so far lacks a proper probing infrastructure similar to the one
> we have with DT, where we're able to declare IRQ chips and
> clocksources inside the driver code, and let the core code pick it up
> and call us back on a match. This leads to all kind of really ugly
> hacks all over the arm64 code and even in the ACPI layer.
>
> It turns out that providing such a probing infrastructure is rather
> easy, and provides a much deserved cleanup in both the arch code, the
> GIC driver, and the architected timer driver.
>
> I'm sure there is some more code to be deleted, and one can only
> wonder why this wasn't done before the arm64 code was initially merged
> (the diffstat says it all...).
>
> Patches are against v4.2, and a branch is available at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git acpi/device-probing
>
> Marc Zyngier (5):
>    acpi: Add basic device probing infrastructure
>    irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>    irqchip/gic: Convert the GIC driver to ACPI probing
>    clocksource/acpi: Add probing infrastructure for ACPI-based
>      clocksources
>    clocksource/arm_arch_timer: Convert to ACPI probing
>
>   arch/arm64/include/asm/acpi.h        |  1 -
>   arch/arm64/include/asm/irq.h         | 13 -------
>   arch/arm64/kernel/acpi.c             | 25 -------------
>   arch/arm64/kernel/time.c             |  6 ----
>   drivers/acpi/scan.c                  | 41 +++++++++++++++++++++
>   drivers/clocksource/arm_arch_timer.c | 10 +-----
>   drivers/clocksource/clksrc-of.c      |  4 +++
>   drivers/irqchip/irq-gic.c            | 69 ++++++++++++++++++------------------
>   drivers/irqchip/irqchip.c            |  5 ++-
>   include/asm-generic/vmlinux.lds.h    | 11 ++++++
>   include/linux/acpi.h                 | 56 +++++++++++++++++++++++++++++
>   include/linux/acpi_irq.h             | 10 ------
>   include/linux/clocksource.h          |  6 ----
>   include/linux/irqchip.h              | 16 +++++++++
>   include/linux/irqchip/arm-gic-acpi.h | 31 ----------------
>   15 files changed, 166 insertions(+), 138 deletions(-)
>   delete mode 100644 include/linux/acpi_irq.h
>   delete mode 100644 include/linux/irqchip/arm-gic-acpi.h
>

Thanks for cleaning this up!

For the whole series:
Acked-by: Tomasz Nowicki <tn@semihalf.com>

WARNING: multiple messages have this Message-ID (diff)
From: tn@semihalf.com (Tomasz Nowicki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/5] ACPI probing infrastructure
Date: Mon, 7 Sep 2015 08:58:33 +0200	[thread overview]
Message-ID: <55ED3599.5090508@semihalf.com> (raw)
In-Reply-To: <1441386412-8139-1-git-send-email-marc.zyngier@arm.com>

Hi Marc,

On 04.09.2015 19:06, Marc Zyngier wrote:
> IRQ controllers and timers are the two types of device the kernel
> requires before being able to use the device driver model.
>
> ACPI so far lacks a proper probing infrastructure similar to the one
> we have with DT, where we're able to declare IRQ chips and
> clocksources inside the driver code, and let the core code pick it up
> and call us back on a match. This leads to all kind of really ugly
> hacks all over the arm64 code and even in the ACPI layer.
>
> It turns out that providing such a probing infrastructure is rather
> easy, and provides a much deserved cleanup in both the arch code, the
> GIC driver, and the architected timer driver.
>
> I'm sure there is some more code to be deleted, and one can only
> wonder why this wasn't done before the arm64 code was initially merged
> (the diffstat says it all...).
>
> Patches are against v4.2, and a branch is available at
>
> git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git acpi/device-probing
>
> Marc Zyngier (5):
>    acpi: Add basic device probing infrastructure
>    irqchip/acpi: Add probing infrastructure for ACPI-based irqchips
>    irqchip/gic: Convert the GIC driver to ACPI probing
>    clocksource/acpi: Add probing infrastructure for ACPI-based
>      clocksources
>    clocksource/arm_arch_timer: Convert to ACPI probing
>
>   arch/arm64/include/asm/acpi.h        |  1 -
>   arch/arm64/include/asm/irq.h         | 13 -------
>   arch/arm64/kernel/acpi.c             | 25 -------------
>   arch/arm64/kernel/time.c             |  6 ----
>   drivers/acpi/scan.c                  | 41 +++++++++++++++++++++
>   drivers/clocksource/arm_arch_timer.c | 10 +-----
>   drivers/clocksource/clksrc-of.c      |  4 +++
>   drivers/irqchip/irq-gic.c            | 69 ++++++++++++++++++------------------
>   drivers/irqchip/irqchip.c            |  5 ++-
>   include/asm-generic/vmlinux.lds.h    | 11 ++++++
>   include/linux/acpi.h                 | 56 +++++++++++++++++++++++++++++
>   include/linux/acpi_irq.h             | 10 ------
>   include/linux/clocksource.h          |  6 ----
>   include/linux/irqchip.h              | 16 +++++++++
>   include/linux/irqchip/arm-gic-acpi.h | 31 ----------------
>   15 files changed, 166 insertions(+), 138 deletions(-)
>   delete mode 100644 include/linux/acpi_irq.h
>   delete mode 100644 include/linux/irqchip/arm-gic-acpi.h
>

Thanks for cleaning this up!

For the whole series:
Acked-by: Tomasz Nowicki <tn@semihalf.com>

  parent reply	other threads:[~2015-09-07  6:58 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-04 17:06 [PATCH 0/5] ACPI probing infrastructure Marc Zyngier
2015-09-04 17:06 ` Marc Zyngier
2015-09-04 17:06 ` [PATCH 1/5] acpi: Add basic device " Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-07 16:00   ` Lorenzo Pieralisi
2015-09-07 16:00     ` Lorenzo Pieralisi
2015-09-07 17:35     ` Marc Zyngier
2015-09-07 17:35       ` Marc Zyngier
2015-09-07 21:29   ` Rafael J. Wysocki
2015-09-07 21:29     ` Rafael J. Wysocki
2015-09-08  9:57     ` Marc Zyngier
2015-09-08  9:57       ` Marc Zyngier
2015-09-08 13:01       ` Hanjun Guo
2015-09-08 13:01         ` Hanjun Guo
2015-09-04 17:06 ` [PATCH 2/5] irqchip/acpi: Add probing infrastructure for ACPI-based irqchips Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-04 17:06 ` [PATCH 3/5] irqchip/gic: Convert the GIC driver to ACPI probing Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-04 17:06 ` [PATCH 4/5] clocksource/acpi: Add probing infrastructure for ACPI-based clocksources Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-04 17:06 ` [PATCH 5/5] clocksource/arm_arch_timer: Convert to ACPI probing Marc Zyngier
2015-09-04 17:06   ` Marc Zyngier
2015-09-07  6:58 ` Tomasz Nowicki [this message]
2015-09-07  6:58   ` [PATCH 0/5] ACPI probing infrastructure Tomasz Nowicki
2015-09-08 14:38   ` Tomasz Nowicki
2015-09-08 14:38     ` Tomasz Nowicki
2015-09-07 21:26 ` Rafael J. Wysocki
2015-09-07 21:26   ` Rafael J. Wysocki
2015-09-08  9:45   ` Marc Zyngier
2015-09-08  9:45     ` Marc Zyngier
2015-09-08 22:26     ` Rafael J. Wysocki
2015-09-08 22:26       ` Rafael J. Wysocki
2015-09-08 13:19 ` Hanjun Guo
2015-09-08 13:19   ` Hanjun Guo
2015-09-10  9:03   ` Hanjun Guo
2015-09-10  9:03     ` Hanjun Guo
2015-09-11 14:06     ` Marc Zyngier
2015-09-11 14:06       ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55ED3599.5090508@semihalf.com \
    --to=tn@semihalf.com \
    --cc=catalin.marinas@arm.com \
    --cc=hanjun.guo@linaro.org \
    --cc=jason@lakedaemon.net \
    --cc=lenb@kernel.org \
    --cc=linaro-acpi@lists.linaro.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=marc.zyngier@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=sudeep.holla@arm.com \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.