From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: nicolas.ferre@atmel.com, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, linux-kernel@vger.kernel.org,
alsa-devel@alsa-project.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Tue, 8 Sep 2015 17:36:13 +0800 [thread overview]
Message-ID: <55EEAC0D.7010003@atmel.com> (raw)
In-Reply-To: <20150907162548.GW5313@sirena.org.uk>
On 9/8/2015 00:25, Mark Brown wrote:
> On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote:
>> On 9/3/2015 19:43, Mark Brown wrote:
>
>>> Why is this a separate DT node? It seems that this IP is entirely self
>>> contained so I'm not clear why we need a separate node for the card, the
>>> card is usually a separate node because it ties together multiple
>>> different devices in the system but that's not the case here.
>
>> The classD can finish the audio function without other devices.
>> But I want to reuse the code in ASoC, leave many things(like creating PCM,
>> DMA operations) to ASoC, then the driver can only focus on how to configure
>> classD.
>> The classD IP is divided to tree parts logically, platform, CPU dai,
>> and codec, and these parts are registered to ASoC.
>
>> This separate DT node is needed in ASoC, ties these tree parts in ClassD.
>
> Sure, there's no problem at all having that structure in software but it
> should be possible to do this without having to represent this structure
> in DT. It should be possible to register the card at the same time as
> the rest of the components rather than needing the separate device in
> the DT.
>
Do you mean using a single entry in the DT for the whole classD system
and instantiate ASoC components from it.
For now, there are two entry, they could be combined to one entry.
WARNING: multiple messages have this Message-ID (diff)
From: songjun.wu@atmel.com (Wu, Songjun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Tue, 8 Sep 2015 17:36:13 +0800 [thread overview]
Message-ID: <55EEAC0D.7010003@atmel.com> (raw)
In-Reply-To: <20150907162548.GW5313@sirena.org.uk>
On 9/8/2015 00:25, Mark Brown wrote:
> On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote:
>> On 9/3/2015 19:43, Mark Brown wrote:
>
>>> Why is this a separate DT node? It seems that this IP is entirely self
>>> contained so I'm not clear why we need a separate node for the card, the
>>> card is usually a separate node because it ties together multiple
>>> different devices in the system but that's not the case here.
>
>> The classD can finish the audio function without other devices.
>> But I want to reuse the code in ASoC, leave many things(like creating PCM,
>> DMA operations) to ASoC, then the driver can only focus on how to configure
>> classD.
>> The classD IP is divided to tree parts logically, platform, CPU dai,
>> and codec, and these parts are registered to ASoC.
>
>> This separate DT node is needed in ASoC, ties these tree parts in ClassD.
>
> Sure, there's no problem at all having that structure in software but it
> should be possible to do this without having to represent this structure
> in DT. It should be possible to register the card at the same time as
> the rest of the components rather than needing the separate device in
> the DT.
>
Do you mean using a single entry in the DT for the whole classD system
and instantiate ASoC components from it.
For now, there are two entry, they could be combined to one entry.
WARNING: multiple messages have this Message-ID (diff)
From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <nicolas.ferre@atmel.com>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Tue, 8 Sep 2015 17:36:13 +0800 [thread overview]
Message-ID: <55EEAC0D.7010003@atmel.com> (raw)
In-Reply-To: <20150907162548.GW5313@sirena.org.uk>
On 9/8/2015 00:25, Mark Brown wrote:
> On Sun, Sep 06, 2015 at 05:44:30PM +0800, Wu, Songjun wrote:
>> On 9/3/2015 19:43, Mark Brown wrote:
>
>>> Why is this a separate DT node? It seems that this IP is entirely self
>>> contained so I'm not clear why we need a separate node for the card, the
>>> card is usually a separate node because it ties together multiple
>>> different devices in the system but that's not the case here.
>
>> The classD can finish the audio function without other devices.
>> But I want to reuse the code in ASoC, leave many things(like creating PCM,
>> DMA operations) to ASoC, then the driver can only focus on how to configure
>> classD.
>> The classD IP is divided to tree parts logically, platform, CPU dai,
>> and codec, and these parts are registered to ASoC.
>
>> This separate DT node is needed in ASoC, ties these tree parts in ClassD.
>
> Sure, there's no problem at all having that structure in software but it
> should be possible to do this without having to represent this structure
> in DT. It should be possible to register the card at the same time as
> the rest of the components rather than needing the separate device in
> the DT.
>
Do you mean using a single entry in the DT for the whole classD system
and instantiate ASoC components from it.
For now, there are two entry, they could be combined to one entry.
next prev parent reply other threads:[~2015-09-08 9:36 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 5:41 [PATCH 0/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-1-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-01 5:41 ` [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-2-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-03 11:37 ` Mark Brown
2015-09-03 11:37 ` Mark Brown
[not found] ` <20150903113716.GU12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-06 9:44 ` Wu, Songjun
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:23 ` Mark Brown
2015-09-07 16:23 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
[not found] ` <55EEAC01.3080409-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
[not found] ` <20150908122322.GB9751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
[not found] ` <55EFA478.1000109-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-09 9:52 ` Mark Brown
2015-09-09 9:52 ` Mark Brown
2015-09-09 9:52 ` Mark Brown
2015-09-10 2:31 ` Wu, Songjun
2015-09-10 2:31 ` Wu, Songjun
2015-09-10 2:31 ` Wu, Songjun
[not found] ` <55F0EB68.9070800-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:34 ` Mark Brown
2015-09-11 10:34 ` Mark Brown
2015-09-11 10:34 ` Mark Brown
[not found] ` <20150911103417.GF12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-14 6:34 ` Wu, Songjun
2015-09-14 6:34 ` Wu, Songjun
2015-09-14 6:34 ` Wu, Songjun
2015-09-01 5:41 ` [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-3-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-03 11:43 ` Mark Brown
2015-09-03 11:43 ` Mark Brown
[not found] ` <20150903114316.GV12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-06 9:44 ` Wu, Songjun
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:25 ` Mark Brown
2015-09-07 16:25 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun [this message]
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
[not found] ` <20150908122340.GC9751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
[not found] ` <55F78C79.30102-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-16 19:42 ` Mark Brown
2015-09-16 19:42 ` Mark Brown
2015-09-16 19:42 ` Mark Brown
[not found] ` <20150916194234.GR12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-17 3:07 ` Wu, Songjun
2015-09-17 3:07 ` Wu, Songjun
2015-09-17 3:07 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55EEAC0D.7010003@atmel.com \
--to=songjun.wu@atmel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.