From: "Wu, Songjun" <songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
To: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org,
lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
perex-/Fr2/VpizcU@public.gmane.org,
tiwai-IBi9RG/b67k@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Thu, 17 Sep 2015 11:07:20 +0800 [thread overview]
Message-ID: <55FA2E68.5010104@atmel.com> (raw)
In-Reply-To: <20150916194234.GR12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
On 9/17/2015 03:42, Mark Brown wrote:
> On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote:
>
>> I try to use one entry, but there is a problem.
>> It's about 'driver_data' in struct device.
>> In function snd_soc_register_card, the parameter 'card' will be set to
>> 'driver_data' by the code 'dev_set_drvdata(card->dev, card)'.
>> Then some resources(eg. regmap, clock) also need be recorded by
>> 'driver_data'. One entry could only has one 'driver_data'. I think the best
>> way is to create two entries, like the current dts.
>> What's your opinion?
>
> Look at the recently applied sunxi driver for an example of how to do
> this - it's a similar piece of hardware (entirely in the SoC and so on).
>
Thank you, It really helps me. I will make a second version soon.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: songjun.wu@atmel.com (Wu, Songjun)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Thu, 17 Sep 2015 11:07:20 +0800 [thread overview]
Message-ID: <55FA2E68.5010104@atmel.com> (raw)
In-Reply-To: <20150916194234.GR12027@sirena.org.uk>
On 9/17/2015 03:42, Mark Brown wrote:
> On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote:
>
>> I try to use one entry, but there is a problem.
>> It's about 'driver_data' in struct device.
>> In function snd_soc_register_card, the parameter 'card' will be set to
>> 'driver_data' by the code 'dev_set_drvdata(card->dev, card)'.
>> Then some resources(eg. regmap, clock) also need be recorded by
>> 'driver_data'. One entry could only has one 'driver_data'. I think the best
>> way is to create two entries, like the current dts.
>> What's your opinion?
>
> Look at the recently applied sunxi driver for an example of how to do
> this - it's a similar piece of hardware (entirely in the SoC and so on).
>
Thank you, It really helps me. I will make a second version soon.
WARNING: multiple messages have this Message-ID (diff)
From: "Wu, Songjun" <songjun.wu@atmel.com>
To: Mark Brown <broonie@kernel.org>
Cc: <nicolas.ferre@atmel.com>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <tiwai@suse.com>,
<linux-kernel@vger.kernel.org>, <alsa-devel@alsa-project.org>,
<robh+dt@kernel.org>, <pawel.moll@arm.com>,
<mark.rutland@arm.com>, <ijc+devicetree@hellion.org.uk>,
<galak@codeaurora.org>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver
Date: Thu, 17 Sep 2015 11:07:20 +0800 [thread overview]
Message-ID: <55FA2E68.5010104@atmel.com> (raw)
In-Reply-To: <20150916194234.GR12027@sirena.org.uk>
On 9/17/2015 03:42, Mark Brown wrote:
> On Tue, Sep 15, 2015 at 11:11:53AM +0800, Wu, Songjun wrote:
>
>> I try to use one entry, but there is a problem.
>> It's about 'driver_data' in struct device.
>> In function snd_soc_register_card, the parameter 'card' will be set to
>> 'driver_data' by the code 'dev_set_drvdata(card->dev, card)'.
>> Then some resources(eg. regmap, clock) also need be recorded by
>> 'driver_data'. One entry could only has one 'driver_data'. I think the best
>> way is to create two entries, like the current dts.
>> What's your opinion?
>
> Look at the recently applied sunxi driver for an example of how to do
> this - it's a similar piece of hardware (entirely in the SoC and so on).
>
Thank you, It really helps me. I will make a second version soon.
next prev parent reply other threads:[~2015-09-17 3:07 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 5:41 [PATCH 0/2] ASoC: atmel-classd: add the Audio Class D Amplifier Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-1-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-01 5:41 ` [PATCH 1/2] ASoC: atmel-classd: add the Audio Class D Amplifier code Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-2-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-03 11:37 ` Mark Brown
2015-09-03 11:37 ` Mark Brown
[not found] ` <20150903113716.GU12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-06 9:44 ` Wu, Songjun
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:23 ` Mark Brown
2015-09-07 16:23 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
[not found] ` <55EEAC01.3080409-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
[not found] ` <20150908122322.GB9751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
[not found] ` <55EFA478.1000109-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-09 9:52 ` Mark Brown
2015-09-09 9:52 ` Mark Brown
2015-09-09 9:52 ` Mark Brown
2015-09-10 2:31 ` Wu, Songjun
2015-09-10 2:31 ` Wu, Songjun
2015-09-10 2:31 ` Wu, Songjun
[not found] ` <55F0EB68.9070800-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-11 10:34 ` Mark Brown
2015-09-11 10:34 ` Mark Brown
2015-09-11 10:34 ` Mark Brown
[not found] ` <20150911103417.GF12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-14 6:34 ` Wu, Songjun
2015-09-14 6:34 ` Wu, Songjun
2015-09-14 6:34 ` Wu, Songjun
2015-09-01 5:41 ` [PATCH 2/2] ASoC: atmel-classd: DT binding for Class D audio amplifier driver Songjun Wu
2015-09-01 5:41 ` Songjun Wu
[not found] ` <1441086101-15303-3-git-send-email-songjun.wu-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-03 11:43 ` Mark Brown
2015-09-03 11:43 ` Mark Brown
[not found] ` <20150903114316.GV12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-06 9:44 ` Wu, Songjun
2015-09-06 9:44 ` Wu, Songjun
2015-09-07 16:25 ` Mark Brown
2015-09-07 16:25 ` Mark Brown
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 9:36 ` Wu, Songjun
2015-09-08 12:23 ` Mark Brown
2015-09-08 12:23 ` Mark Brown
[not found] ` <20150908122340.GC9751-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-09 3:16 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
2015-09-15 3:11 ` Wu, Songjun
[not found] ` <55F78C79.30102-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2015-09-16 19:42 ` Mark Brown
2015-09-16 19:42 ` Mark Brown
2015-09-16 19:42 ` Mark Brown
[not found] ` <20150916194234.GR12027-GFdadSzt00ze9xe1eoZjHA@public.gmane.org>
2015-09-17 3:07 ` Wu, Songjun [this message]
2015-09-17 3:07 ` Wu, Songjun
2015-09-17 3:07 ` Wu, Songjun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FA2E68.5010104@atmel.com \
--to=songjun.wu-aife0yeh4naavxtiumwx3w@public.gmane.org \
--cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
--cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=nicolas.ferre-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=perex-/Fr2/VpizcU@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=tiwai-IBi9RG/b67k@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.