Re: [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages

[Michael Tokarev <mjt@tls.msk.ru>]

08.09.2015 23:29, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  docs/specs/vhost-user.txt | 18 +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
> index 0322bcf..1bc6adb 100644
> --- a/docs/specs/vhost-user.txt
> +++ b/docs/specs/vhost-user.txt
> @@ -112,19 +112,19 @@ The communication consists of master sending message requests and slave sending
>  message replies. Most of the requests don't require replies. Here is a list of
>  the ones that do:
>  
> - * VHOST_GET_FEATURES
> - * VHOST_GET_PROTOCOL_FEATURES
> - * VHOST_GET_VRING_BASE
> + * VHOST_USER_GET_FEATURES
> + * VHOST_USER_GET_PROTOCOL_FEATURES
> + * VHOST_USER_GET_VRING_BASE

The patch doesn't apply to qemu master as vhost-user.txt does not
have VHOST_GET_PROTOCOL_FEATURES in here.  What treee you're basing
your patch on?

Besides, this is quite confusing.  Both VHOST_USER_GET_FEATURES and
VHOST_GET_FEATURES #defines exists and used, which one is which?

Thanks,

/mjt