* [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages
@ 2015-09-08 20:29 ` marcandre.lureau
0 siblings, 0 replies; 10+ messages in thread
From: marcandre.lureau @ 2015-09-08 20:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/vhost-user.txt | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
index 0322bcf..1bc6adb 100644
--- a/docs/specs/vhost-user.txt
+++ b/docs/specs/vhost-user.txt
@@ -112,19 +112,19 @@ The communication consists of master sending message requests and slave sending
message replies. Most of the requests don't require replies. Here is a list of
the ones that do:
- * VHOST_GET_FEATURES
- * VHOST_GET_PROTOCOL_FEATURES
- * VHOST_GET_VRING_BASE
+ * VHOST_USER_GET_FEATURES
+ * VHOST_USER_GET_PROTOCOL_FEATURES
+ * VHOST_USER_GET_VRING_BASE
There are several messages that the master sends with file descriptors passed
in the ancillary data:
- * VHOST_SET_MEM_TABLE
- * VHOST_SET_LOG_BASE (if VHOST_USER_PROTOCOL_F_LOG_SHMFD)
- * VHOST_SET_LOG_FD
- * VHOST_SET_VRING_KICK
- * VHOST_SET_VRING_CALL
- * VHOST_SET_VRING_ERR
+ * VHOST_USER_SET_MEM_TABLE
+ * VHOST_USER_SET_LOG_BASE (if VHOST_USER_PROTOCOL_F_LOG_SHMFD)
+ * VHOST_USER_SET_LOG_FD
+ * VHOST_USER_SET_VRING_KICK
+ * VHOST_USER_SET_VRING_CALL
+ * VHOST_USER_SET_VRING_ERR
If Master is unable to send the full message or receives a wrong reply it will
close the connection. An optional reconnection mechanism can be implemented.
--
2.4.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages
@ 2015-09-08 20:29 ` marcandre.lureau
0 siblings, 0 replies; 10+ messages in thread
From: marcandre.lureau @ 2015-09-08 20:29 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau, mst
From: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
docs/specs/vhost-user.txt | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
index 0322bcf..1bc6adb 100644
--- a/docs/specs/vhost-user.txt
+++ b/docs/specs/vhost-user.txt
@@ -112,19 +112,19 @@ The communication consists of master sending message requests and slave sending
message replies. Most of the requests don't require replies. Here is a list of
the ones that do:
- * VHOST_GET_FEATURES
- * VHOST_GET_PROTOCOL_FEATURES
- * VHOST_GET_VRING_BASE
+ * VHOST_USER_GET_FEATURES
+ * VHOST_USER_GET_PROTOCOL_FEATURES
+ * VHOST_USER_GET_VRING_BASE
There are several messages that the master sends with file descriptors passed
in the ancillary data:
- * VHOST_SET_MEM_TABLE
- * VHOST_SET_LOG_BASE (if VHOST_USER_PROTOCOL_F_LOG_SHMFD)
- * VHOST_SET_LOG_FD
- * VHOST_SET_VRING_KICK
- * VHOST_SET_VRING_CALL
- * VHOST_SET_VRING_ERR
+ * VHOST_USER_SET_MEM_TABLE
+ * VHOST_USER_SET_LOG_BASE (if VHOST_USER_PROTOCOL_F_LOG_SHMFD)
+ * VHOST_USER_SET_LOG_FD
+ * VHOST_USER_SET_VRING_KICK
+ * VHOST_USER_SET_VRING_CALL
+ * VHOST_USER_SET_VRING_ERR
If Master is unable to send the full message or receives a wrong reply it will
close the connection. An optional reconnection mechanism can be implemented.
--
2.4.3
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages
2015-09-08 20:29 ` [Qemu-devel] " marcandre.lureau
@ 2015-09-11 7:24 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-09-11 7:24 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: qemu-trivial, mst
08.09.2015 23:29, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> docs/specs/vhost-user.txt | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
> index 0322bcf..1bc6adb 100644
> --- a/docs/specs/vhost-user.txt
> +++ b/docs/specs/vhost-user.txt
> @@ -112,19 +112,19 @@ The communication consists of master sending message requests and slave sending
> message replies. Most of the requests don't require replies. Here is a list of
> the ones that do:
>
> - * VHOST_GET_FEATURES
> - * VHOST_GET_PROTOCOL_FEATURES
> - * VHOST_GET_VRING_BASE
> + * VHOST_USER_GET_FEATURES
> + * VHOST_USER_GET_PROTOCOL_FEATURES
> + * VHOST_USER_GET_VRING_BASE
The patch doesn't apply to qemu master as vhost-user.txt does not
have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
your patch on?
Besides, this is quite confusing. Both VHOST_USER_GET_FEATURES and
VHOST_GET_FEATURES #defines exists and used, which one is which?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages
@ 2015-09-11 7:24 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-09-11 7:24 UTC (permalink / raw)
To: marcandre.lureau, qemu-devel; +Cc: qemu-trivial, mst
08.09.2015 23:29, marcandre.lureau@redhat.com wrote:
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> docs/specs/vhost-user.txt | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/docs/specs/vhost-user.txt b/docs/specs/vhost-user.txt
> index 0322bcf..1bc6adb 100644
> --- a/docs/specs/vhost-user.txt
> +++ b/docs/specs/vhost-user.txt
> @@ -112,19 +112,19 @@ The communication consists of master sending message requests and slave sending
> message replies. Most of the requests don't require replies. Here is a list of
> the ones that do:
>
> - * VHOST_GET_FEATURES
> - * VHOST_GET_PROTOCOL_FEATURES
> - * VHOST_GET_VRING_BASE
> + * VHOST_USER_GET_FEATURES
> + * VHOST_USER_GET_PROTOCOL_FEATURES
> + * VHOST_USER_GET_VRING_BASE
The patch doesn't apply to qemu master as vhost-user.txt does not
have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
your patch on?
Besides, this is quite confusing. Both VHOST_USER_GET_FEATURES and
VHOST_GET_FEATURES #defines exists and used, which one is which?
Thanks,
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages
2015-09-11 7:24 ` [Qemu-devel] " Michael Tokarev
@ 2015-09-16 9:13 ` Marc-André Lureau
-1 siblings, 0 replies; 10+ messages in thread
From: Marc-André Lureau @ 2015-09-16 9:13 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, QEMU, Michael S. Tsirkin
Hi
On Fri, Sep 11, 2015 at 9:24 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> The patch doesn't apply to qemu master as vhost-user.txt does not
> have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
> your patch on?
It is after your pending protocol feature patches.
> Besides, this is quite confusing. Both VHOST_USER_GET_FEATURES and
> VHOST_GET_FEATURES #defines exists and used, which one is which?
I don't know what you mean, VHOST_USER_GET_FEATURES maps to
VHOST_GET_FEATURES. But the protocol should use only VHOST_USER*
constants.
I'll resend this patch later
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages
@ 2015-09-16 9:13 ` Marc-André Lureau
0 siblings, 0 replies; 10+ messages in thread
From: Marc-André Lureau @ 2015-09-16 9:13 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, QEMU, Michael S. Tsirkin
Hi
On Fri, Sep 11, 2015 at 9:24 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
> The patch doesn't apply to qemu master as vhost-user.txt does not
> have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
> your patch on?
It is after your pending protocol feature patches.
> Besides, this is quite confusing. Both VHOST_USER_GET_FEATURES and
> VHOST_GET_FEATURES #defines exists and used, which one is which?
I don't know what you mean, VHOST_USER_GET_FEATURES maps to
VHOST_GET_FEATURES. But the protocol should use only VHOST_USER*
constants.
I'll resend this patch later
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages
2015-09-16 9:13 ` Marc-André Lureau
@ 2015-09-16 10:57 ` Michael Tokarev
-1 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-09-16 10:57 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-trivial, QEMU, Michael S. Tsirkin
16.09.2015 12:13, Marc-André Lureau wrote:
> On Fri, Sep 11, 2015 at 9:24 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> The patch doesn't apply to qemu master as vhost-user.txt does not
>> have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
>> your patch on?
>
> It is after your pending protocol feature patches.
Are you confusing me with Michael S. Tsirkin (mst)? :)
(that's no problem ofcourse, and you're welcome :)
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-devel] [PATCH] specs/vhost-user.txt: fix name of messages
@ 2015-09-16 10:57 ` Michael Tokarev
0 siblings, 0 replies; 10+ messages in thread
From: Michael Tokarev @ 2015-09-16 10:57 UTC (permalink / raw)
To: Marc-André Lureau; +Cc: qemu-trivial, QEMU, Michael S. Tsirkin
16.09.2015 12:13, Marc-André Lureau wrote:
> On Fri, Sep 11, 2015 at 9:24 AM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>> The patch doesn't apply to qemu master as vhost-user.txt does not
>> have VHOST_GET_PROTOCOL_FEATURES in here. What treee you're basing
>> your patch on?
>
> It is after your pending protocol feature patches.
Are you confusing me with Michael S. Tsirkin (mst)? :)
(that's no problem ofcourse, and you're welcome :)
/mjt
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages
2015-09-16 10:57 ` [Qemu-devel] " Michael Tokarev
@ 2015-09-16 12:13 ` Marc-André Lureau
-1 siblings, 0 replies; 10+ messages in thread
From: Marc-André Lureau @ 2015-09-16 12:13 UTC (permalink / raw)
To: Michael Tokarev; +Cc: qemu-trivial, QEMU, Michael S. Tsirkin
Hi
On Wed, Sep 16, 2015 at 12:57 PM, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> Are you confusing me with Michael S. Tsirkin (mst)? :)
>
> (that's no problem ofcourse, and you're welcome :)
Oh, sorry! I might have confused you two for a while :)
thanks
--
Marc-André Lureau
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2015-09-16 12:14 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-08 20:29 [Qemu-trivial] [PATCH] specs/vhost-user.txt: fix name of messages marcandre.lureau
2015-09-08 20:29 ` [Qemu-devel] " marcandre.lureau
2015-09-11 7:24 ` [Qemu-trivial] " Michael Tokarev
2015-09-11 7:24 ` [Qemu-devel] " Michael Tokarev
2015-09-16 9:13 ` [Qemu-trivial] " Marc-André Lureau
2015-09-16 9:13 ` Marc-André Lureau
2015-09-16 10:57 ` [Qemu-trivial] " Michael Tokarev
2015-09-16 10:57 ` [Qemu-devel] " Michael Tokarev
2015-09-16 12:13 ` [Qemu-trivial] " Marc-André Lureau
2015-09-16 12:13 ` [Qemu-devel] " Marc-André Lureau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.