From: Ray Jui <rjui@broadcom.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: linux-mmc@vger.kernel.org, Scott Branden <sbranden@broadcom.com>,
bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
Date: Wed, 16 Sep 2015 10:20:11 -0700 [thread overview]
Message-ID: <55F9A4CB.7070302@broadcom.com> (raw)
In-Reply-To: <1442397200-29731-1-git-send-email-javier@osg.samsung.com>
On 9/16/2015 2:53 AM, Javier Martinez Canillas wrote:
> The driver prints if the data width is 8-bit but it's using a
> binary OR instead of a binary AND so it will always report as
> "is_8bit=Y" regardless of the flags in host->mmc->caps.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 2bd90fb35c75..00a8a40a3729 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
The fix looks good to me. Thanks.
Reviewed-by: Ray Jui <rjui@broadcom.com>
Ray
WARNING: multiple messages have this Message-ID (diff)
From: Ray Jui <rjui@broadcom.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>,
<linux-kernel@vger.kernel.org>
Cc: <linux-mmc@vger.kernel.org>,
Scott Branden <sbranden@broadcom.com>,
<bcm-kernel-feedback-list@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
Date: Wed, 16 Sep 2015 10:20:11 -0700 [thread overview]
Message-ID: <55F9A4CB.7070302@broadcom.com> (raw)
In-Reply-To: <1442397200-29731-1-git-send-email-javier@osg.samsung.com>
On 9/16/2015 2:53 AM, Javier Martinez Canillas wrote:
> The driver prints if the data width is 8-bit but it's using a
> binary OR instead of a binary AND so it will always report as
> "is_8bit=Y" regardless of the flags in host->mmc->caps.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 2bd90fb35c75..00a8a40a3729 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
The fix looks good to me. Thanks.
Reviewed-by: Ray Jui <rjui@broadcom.com>
Ray
next prev parent reply other threads:[~2015-09-16 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-16 9:53 [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width Javier Martinez Canillas
2015-09-16 17:20 ` Ray Jui [this message]
2015-09-16 17:20 ` Ray Jui
2015-09-17 8:49 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55F9A4CB.7070302@broadcom.com \
--to=rjui@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=sbranden@broadcom.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.