* [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
@ 2015-09-16 9:53 Javier Martinez Canillas
2015-09-16 17:20 ` Ray Jui
2015-09-17 8:49 ` Ulf Hansson
0 siblings, 2 replies; 4+ messages in thread
From: Javier Martinez Canillas @ 2015-09-16 9:53 UTC (permalink / raw)
To: linux-kernel
Cc: Javier Martinez Canillas, linux-mmc, Scott Branden,
bcm-kernel-feedback-list, Florian Fainelli, Ray Jui, Ulf Hansson
The driver prints if the data width is 8-bit but it's using a
binary OR instead of a binary AND so it will always report as
"is_8bit=Y" regardless of the flags in host->mmc->caps.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
index 2bd90fb35c75..00a8a40a3729 100644
--- a/drivers/mmc/host/sdhci-bcm-kona.c
+++ b/drivers/mmc/host/sdhci-bcm-kona.c
@@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
dev_dbg(dev, "is_8bit=%c\n",
- (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
+ (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
ret = sdhci_bcm_kona_sd_reset(host);
if (ret)
--
2.4.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
2015-09-16 9:53 [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width Javier Martinez Canillas
@ 2015-09-16 17:20 ` Ray Jui
2015-09-17 8:49 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ray Jui @ 2015-09-16 17:20 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-mmc, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Ulf Hansson
On 9/16/2015 2:53 AM, Javier Martinez Canillas wrote:
> The driver prints if the data width is 8-bit but it's using a
> binary OR instead of a binary AND so it will always report as
> "is_8bit=Y" regardless of the flags in host->mmc->caps.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 2bd90fb35c75..00a8a40a3729 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
The fix looks good to me. Thanks.
Reviewed-by: Ray Jui <rjui@broadcom.com>
Ray
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
@ 2015-09-16 17:20 ` Ray Jui
0 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2015-09-16 17:20 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-mmc, Scott Branden, bcm-kernel-feedback-list,
Florian Fainelli, Ulf Hansson
On 9/16/2015 2:53 AM, Javier Martinez Canillas wrote:
> The driver prints if the data width is 8-bit but it's using a
> binary OR instead of a binary AND so it will always report as
> "is_8bit=Y" regardless of the flags in host->mmc->caps.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
>
> ---
>
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 2bd90fb35c75..00a8a40a3729 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
The fix looks good to me. Thanks.
Reviewed-by: Ray Jui <rjui@broadcom.com>
Ray
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width
2015-09-16 9:53 [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width Javier Martinez Canillas
2015-09-16 17:20 ` Ray Jui
@ 2015-09-17 8:49 ` Ulf Hansson
1 sibling, 0 replies; 4+ messages in thread
From: Ulf Hansson @ 2015-09-17 8:49 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel@vger.kernel.org, linux-mmc, Scott Branden,
bcm-kernel-feedback-list, Florian Fainelli, Ray Jui
On 16 September 2015 at 11:53, Javier Martinez Canillas
<javier@osg.samsung.com> wrote:
> The driver prints if the data width is 8-bit but it's using a
> binary OR instead of a binary AND so it will always report as
> "is_8bit=Y" regardless of the flags in host->mmc->caps.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
Thanks, applied for next!
Kind regards
Uffe
>
> ---
>
> drivers/mmc/host/sdhci-bcm-kona.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/sdhci-bcm-kona.c b/drivers/mmc/host/sdhci-bcm-kona.c
> index 2bd90fb35c75..00a8a40a3729 100644
> --- a/drivers/mmc/host/sdhci-bcm-kona.c
> +++ b/drivers/mmc/host/sdhci-bcm-kona.c
> @@ -273,7 +273,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)
> host->quirks |= SDHCI_QUIRK_BROKEN_CARD_DETECTION;
>
> dev_dbg(dev, "is_8bit=%c\n",
> - (host->mmc->caps | MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
> + (host->mmc->caps & MMC_CAP_8_BIT_DATA) ? 'Y' : 'N');
>
> ret = sdhci_bcm_kona_sd_reset(host);
> if (ret)
> --
> 2.4.3
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-09-17 8:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 9:53 [PATCH] mmc: sdhci-bcm-kona: fix logic to check for 8-bit data width Javier Martinez Canillas
2015-09-16 17:20 ` Ray Jui
2015-09-16 17:20 ` Ray Jui
2015-09-17 8:49 ` Ulf Hansson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.