From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33
Date: Fri, 18 Sep 2015 11:29:48 -0400 [thread overview]
Message-ID: <55FC2DEC.7080104@redhat.com> (raw)
In-Reply-To: <1442561739-6824-2-git-send-email-wens@csie.org>
Hi,
Good stuff, thanks for working on this.
On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> A23/A33 have a PWM controller that is compatible to the one on the A20.
> Add a device node for it.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 27a925ec17d2..e7054304018a 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -466,6 +466,14 @@
> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + pwm: pwm at 01c21400 {
> + compatible = "allwinner,sun7i-a20-pwm";
> + reg = <0x01c21400 0xc>;
> + clocks = <&osc24M>;
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> lradc: lradc at 01c22800 {
> compatible = "allwinner,sun4i-a10-lradc-keys";
> reg = <0x01c22800 0x100>;
>
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33
Date: Fri, 18 Sep 2015 11:29:48 -0400 [thread overview]
Message-ID: <55FC2DEC.7080104@redhat.com> (raw)
In-Reply-To: <1442561739-6824-2-git-send-email-wens@csie.org>
Hi,
Good stuff, thanks for working on this.
On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> A23/A33 have a PWM controller that is compatible to the one on the A20.
> Add a device node for it.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 27a925ec17d2..e7054304018a 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -466,6 +466,14 @@
> interrupts = <GIC_SPI 25 IRQ_TYPE_LEVEL_HIGH>;
> };
>
> + pwm: pwm@01c21400 {
> + compatible = "allwinner,sun7i-a20-pwm";
> + reg = <0x01c21400 0xc>;
> + clocks = <&osc24M>;
> + #pwm-cells = <3>;
> + status = "disabled";
> + };
> +
> lradc: lradc@01c22800 {
> compatible = "allwinner,sun4i-a10-lradc-keys";
> reg = <0x01c22800 0x100>;
>
next prev parent reply other threads:[~2015-09-18 15:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 7:35 [PATCH 0/4] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 Q8 format tablets Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 7:35 ` [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33 Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:29 ` Hans de Goede [this message]
2015-09-18 15:29 ` [linux-sunxi] " Hans de Goede
2015-09-18 19:24 ` Maxime Ripard
2015-09-18 19:24 ` Maxime Ripard
2015-09-18 7:35 ` [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting " Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:30 ` [linux-sunxi] " Hans de Goede
2015-09-18 15:30 ` Hans de Goede
2015-09-18 16:18 ` Chen-Yu Tsai
2015-09-18 16:18 ` Chen-Yu Tsai
2015-09-18 19:33 ` Maxime Ripard
2015-09-18 19:33 ` Maxime Ripard
2015-09-18 7:35 ` [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:32 ` [linux-sunxi] " Hans de Goede
2015-09-18 15:32 ` Hans de Goede
2015-09-18 16:25 ` Chen-Yu Tsai
2015-09-18 16:25 ` Chen-Yu Tsai
2015-09-19 21:39 ` Hans de Goede
2015-09-19 21:39 ` Hans de Goede
2015-09-18 7:35 ` [PATCH 4/4] ARM: dts: sun8i: Add pwm-backlight device for " Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC2DEC.7080104@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.