From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets
Date: Fri, 18 Sep 2015 11:32:37 -0400 [thread overview]
Message-ID: <55FC2E95.7040006@redhat.com> (raw)
In-Reply-To: <1442561739-6824-4-git-send-email-wens@csie.org>
Hi,
On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for
> backlight dimming.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> index 6f8a8bb4e9bb..4c2d0b459d6f 100644
> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi
> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> @@ -70,6 +70,12 @@
> };
> };
>
> +&pwm {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm0_pins>;
> + status = "okay";
> +};
> +
> &r_uart {
> pinctrl-names = "default";
> pinctrl-0 = <&r_uart_pins_a>;
>
I've a feeling this should be in sunxi-q8-common.dtsi not sun8i-q8-common.dtsi, which requires adding a pwm
node to sun5i.dtsi I'll look into this.
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede@redhat.com>
To: Chen-Yu Tsai <wens@csie.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com
Subject: Re: [linux-sunxi] [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets
Date: Fri, 18 Sep 2015 11:32:37 -0400 [thread overview]
Message-ID: <55FC2E95.7040006@redhat.com> (raw)
In-Reply-To: <1442561739-6824-4-git-send-email-wens@csie.org>
Hi,
On 09/18/2015 03:35 AM, Chen-Yu Tsai wrote:
> A23/A33 based Q8 format tablets use channel 0 of the PWM controller for
> backlight dimming.
>
> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> ---
> arch/arm/boot/dts/sun8i-q8-common.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-q8-common.dtsi b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> index 6f8a8bb4e9bb..4c2d0b459d6f 100644
> --- a/arch/arm/boot/dts/sun8i-q8-common.dtsi
> +++ b/arch/arm/boot/dts/sun8i-q8-common.dtsi
> @@ -70,6 +70,12 @@
> };
> };
>
> +&pwm {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pwm0_pins>;
> + status = "okay";
> +};
> +
> &r_uart {
> pinctrl-names = "default";
> pinctrl-0 = <&r_uart_pins_a>;
>
I've a feeling this should be in sunxi-q8-common.dtsi not sun8i-q8-common.dtsi, which requires adding a pwm
node to sun5i.dtsi I'll look into this.
Regards,
Hans
next prev parent reply other threads:[~2015-09-18 15:32 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 7:35 [PATCH 0/4] ARM: dts: sun8i: Add pwm-backlight device for A23/A33 Q8 format tablets Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 7:35 ` [PATCH 1/4] ARM: dts: sun8i: Add PWM controller node for A23/A33 Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:29 ` [linux-sunxi] " Hans de Goede
2015-09-18 15:29 ` Hans de Goede
2015-09-18 19:24 ` Maxime Ripard
2015-09-18 19:24 ` Maxime Ripard
2015-09-18 7:35 ` [PATCH 2/4] ARM: dts: sun8i: Add PWM channel 0 pinmux setting " Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:30 ` [linux-sunxi] " Hans de Goede
2015-09-18 15:30 ` Hans de Goede
2015-09-18 16:18 ` Chen-Yu Tsai
2015-09-18 16:18 ` Chen-Yu Tsai
2015-09-18 19:33 ` Maxime Ripard
2015-09-18 19:33 ` Maxime Ripard
2015-09-18 7:35 ` [PATCH 3/4] ARM: dts: sun8i: Enable PWM controller on A23/A33 Q8 format tablets Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
2015-09-18 15:32 ` Hans de Goede [this message]
2015-09-18 15:32 ` [linux-sunxi] " Hans de Goede
2015-09-18 16:25 ` Chen-Yu Tsai
2015-09-18 16:25 ` Chen-Yu Tsai
2015-09-19 21:39 ` Hans de Goede
2015-09-19 21:39 ` Hans de Goede
2015-09-18 7:35 ` [PATCH 4/4] ARM: dts: sun8i: Add pwm-backlight device for " Chen-Yu Tsai
2015-09-18 7:35 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55FC2E95.7040006@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.