* [PATCH] char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct
@ 2015-09-19 15:43 Luis de Bethencourt
2015-09-20 0:46 ` Corey Minyard
0 siblings, 1 reply; 2+ messages in thread
From: Luis de Bethencourt @ 2015-09-19 15:43 UTC (permalink / raw)
To: linux-kernel; +Cc: minyard, openipmi-developer, Luis de Bethencourt
The policy for drivers is to have MODULE_DEVICE_TABLE() just after the
struct used in it. For clarity.
Suggested-by: Corey Minyard <minyard@acm.org>
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
---
Suggested in:
https://lkml.org/lkml/2015/9/18/842
Thanks Corey,
Luis
drivers/char/ipmi/ipmi_si_intf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
index 654f6f3..061fef0 100644
--- a/drivers/char/ipmi/ipmi_si_intf.c
+++ b/drivers/char/ipmi/ipmi_si_intf.c
@@ -2560,6 +2560,7 @@ static const struct of_device_id of_ipmi_match[] = {
.data = (void *)(unsigned long) SI_BT },
{},
};
+MODULE_DEVICE_TABLE(of, of_ipmi_match);
static int of_ipmi_probe(struct platform_device *dev)
{
@@ -2646,7 +2647,6 @@ static int of_ipmi_probe(struct platform_device *dev)
}
return 0;
}
-MODULE_DEVICE_TABLE(of, of_ipmi_match);
#else
#define of_ipmi_match NULL
static int of_ipmi_probe(struct platform_device *dev)
--
2.5.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct
2015-09-19 15:43 [PATCH] char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct Luis de Bethencourt
@ 2015-09-20 0:46 ` Corey Minyard
0 siblings, 0 replies; 2+ messages in thread
From: Corey Minyard @ 2015-09-20 0:46 UTC (permalink / raw)
To: Luis de Bethencourt, linux-kernel; +Cc: openipmi-developer
Ok, queued for 4.4.
Thanks,
-corey
On 09/19/2015 10:43 AM, Luis de Bethencourt wrote:
> The policy for drivers is to have MODULE_DEVICE_TABLE() just after the
> struct used in it. For clarity.
>
> Suggested-by: Corey Minyard <minyard@acm.org>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Suggested in:
> https://lkml.org/lkml/2015/9/18/842
>
> Thanks Corey,
> Luis
>
> drivers/char/ipmi/ipmi_si_intf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c
> index 654f6f3..061fef0 100644
> --- a/drivers/char/ipmi/ipmi_si_intf.c
> +++ b/drivers/char/ipmi/ipmi_si_intf.c
> @@ -2560,6 +2560,7 @@ static const struct of_device_id of_ipmi_match[] = {
> .data = (void *)(unsigned long) SI_BT },
> {},
> };
> +MODULE_DEVICE_TABLE(of, of_ipmi_match);
>
> static int of_ipmi_probe(struct platform_device *dev)
> {
> @@ -2646,7 +2647,6 @@ static int of_ipmi_probe(struct platform_device *dev)
> }
> return 0;
> }
> -MODULE_DEVICE_TABLE(of, of_ipmi_match);
> #else
> #define of_ipmi_match NULL
> static int of_ipmi_probe(struct platform_device *dev)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-20 0:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-19 15:43 [PATCH] char: ipmi: Move MODULE_DEVICE_TABLE() to follow struct Luis de Bethencourt
2015-09-20 0:46 ` Corey Minyard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.