All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
	"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH] ath10k: Fix CCK rate definitions.
Date: Mon, 21 Sep 2015 08:51:10 -0700	[thread overview]
Message-ID: <5600276E.6080408@candelatech.com> (raw)
In-Reply-To: <CA+BoTQkXma5KXpGa3XnnFw=13GRVoTEth0_=K-YNEKru1CpaOA@mail.gmail.com>

On 09/21/2015 12:33 AM, Michal Kazior wrote:
> On 16 September 2015 at 02:08,  <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The old values did NOT match what is found in 10.1.467
>> firmware.  I figure it is likely it is wrong for the others
>> as well.
>
> Does this fix anything at all?

I'm adding support to CT firmware to set arbitrary ratectrl
masks, and I'm using that enum for part of the implementation.

In the 4.0 kernel, the 'hw-value' for CCK rates is broken since the enum doesn't
match firmware.

I'll check what code is using that enum and see if it can be fixed.  Otherwise,
I can fix it with a new enum with the values I need.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Ben Greear <greearb@candelatech.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: Fix CCK rate definitions.
Date: Mon, 21 Sep 2015 08:51:10 -0700	[thread overview]
Message-ID: <5600276E.6080408@candelatech.com> (raw)
In-Reply-To: <CA+BoTQkXma5KXpGa3XnnFw=13GRVoTEth0_=K-YNEKru1CpaOA@mail.gmail.com>

On 09/21/2015 12:33 AM, Michal Kazior wrote:
> On 16 September 2015 at 02:08,  <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The old values did NOT match what is found in 10.1.467
>> firmware.  I figure it is likely it is wrong for the others
>> as well.
>
> Does this fix anything at all?

I'm adding support to CT firmware to set arbitrary ratectrl
masks, and I'm using that enum for part of the implementation.

In the 4.0 kernel, the 'hw-value' for CCK rates is broken since the enum doesn't
match firmware.

I'll check what code is using that enum and see if it can be fixed.  Otherwise,
I can fix it with a new enum with the values I need.

Thanks,
Ben

-- 
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc  http://www.candelatech.com


  reply	other threads:[~2015-09-21 15:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16  0:08 [PATCH] ath10k: Fix CCK rate definitions greearb
2015-09-16  0:08 ` greearb
2015-09-21  7:33 ` Michal Kazior
2015-09-21  7:33   ` Michal Kazior
2015-09-21 15:51   ` Ben Greear [this message]
2015-09-21 15:51     ` Ben Greear

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5600276E.6080408@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.