* [PATCH] ath10k: Fix CCK rate definitions.
@ 2015-09-16 0:08 ` greearb
0 siblings, 0 replies; 6+ messages in thread
From: greearb @ 2015-09-16 0:08 UTC (permalink / raw)
To: ath10k; +Cc: Ben Greear, linux-wireless
From: Ben Greear <greearb@candelatech.com>
The old values did NOT match what is found in 10.1.467
firmware. I figure it is likely it is wrong for the others
as well.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 4c5eee4..710ca32 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -202,13 +202,13 @@ enum ath10k_hw_rate_ofdm {
};
enum ath10k_hw_rate_cck {
- ATH10K_HW_RATE_CCK_LP_11M = 0,
- ATH10K_HW_RATE_CCK_LP_5_5M,
- ATH10K_HW_RATE_CCK_LP_2M,
- ATH10K_HW_RATE_CCK_LP_1M,
- ATH10K_HW_RATE_CCK_SP_11M,
- ATH10K_HW_RATE_CCK_SP_5_5M,
- ATH10K_HW_RATE_CCK_SP_2M,
+ ATH10K_HW_RATE_CCK_LP_11M = 0x40,
+ ATH10K_HW_RATE_CCK_LP_5_5M = 0x41,
+ ATH10K_HW_RATE_CCK_LP_2M = 0x42,
+ ATH10K_HW_RATE_CCK_LP_1M = 0x43,
+ ATH10K_HW_RATE_CCK_SP_11M = ATH10K_HW_RATE_CCK_LP_11M | 0x4,
+ ATH10K_HW_RATE_CCK_SP_5_5M = ATH10K_HW_RATE_CCK_LP_5_5M | 0x4,
+ ATH10K_HW_RATE_CCK_SP_2M = ATH10K_HW_RATE_CCK_LP_2M | 0x4,
};
/* Target specific defines for MAIN firmware */
--
2.4.3
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] ath10k: Fix CCK rate definitions.
@ 2015-09-16 0:08 ` greearb
0 siblings, 0 replies; 6+ messages in thread
From: greearb @ 2015-09-16 0:08 UTC (permalink / raw)
To: ath10k; +Cc: linux-wireless, Ben Greear
From: Ben Greear <greearb@candelatech.com>
The old values did NOT match what is found in 10.1.467
firmware. I figure it is likely it is wrong for the others
as well.
Signed-off-by: Ben Greear <greearb@candelatech.com>
---
drivers/net/wireless/ath/ath10k/hw.h | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
index 4c5eee4..710ca32 100644
--- a/drivers/net/wireless/ath/ath10k/hw.h
+++ b/drivers/net/wireless/ath/ath10k/hw.h
@@ -202,13 +202,13 @@ enum ath10k_hw_rate_ofdm {
};
enum ath10k_hw_rate_cck {
- ATH10K_HW_RATE_CCK_LP_11M = 0,
- ATH10K_HW_RATE_CCK_LP_5_5M,
- ATH10K_HW_RATE_CCK_LP_2M,
- ATH10K_HW_RATE_CCK_LP_1M,
- ATH10K_HW_RATE_CCK_SP_11M,
- ATH10K_HW_RATE_CCK_SP_5_5M,
- ATH10K_HW_RATE_CCK_SP_2M,
+ ATH10K_HW_RATE_CCK_LP_11M = 0x40,
+ ATH10K_HW_RATE_CCK_LP_5_5M = 0x41,
+ ATH10K_HW_RATE_CCK_LP_2M = 0x42,
+ ATH10K_HW_RATE_CCK_LP_1M = 0x43,
+ ATH10K_HW_RATE_CCK_SP_11M = ATH10K_HW_RATE_CCK_LP_11M | 0x4,
+ ATH10K_HW_RATE_CCK_SP_5_5M = ATH10K_HW_RATE_CCK_LP_5_5M | 0x4,
+ ATH10K_HW_RATE_CCK_SP_2M = ATH10K_HW_RATE_CCK_LP_2M | 0x4,
};
/* Target specific defines for MAIN firmware */
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ath10k: Fix CCK rate definitions.
2015-09-16 0:08 ` greearb
@ 2015-09-21 7:33 ` Michal Kazior
-1 siblings, 0 replies; 6+ messages in thread
From: Michal Kazior @ 2015-09-21 7:33 UTC (permalink / raw)
To: Ben Greear; +Cc: linux-wireless, ath10k@lists.infradead.org
On 16 September 2015 at 02:08, <greearb@candelatech.com> wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The old values did NOT match what is found in 10.1.467
> firmware. I figure it is likely it is wrong for the others
> as well.
Does this fix anything at all?
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 4c5eee4..710ca32 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -202,13 +202,13 @@ enum ath10k_hw_rate_ofdm {
> };
>
> enum ath10k_hw_rate_cck {
> - ATH10K_HW_RATE_CCK_LP_11M = 0,
> - ATH10K_HW_RATE_CCK_LP_5_5M,
> - ATH10K_HW_RATE_CCK_LP_2M,
> - ATH10K_HW_RATE_CCK_LP_1M,
> - ATH10K_HW_RATE_CCK_SP_11M,
> - ATH10K_HW_RATE_CCK_SP_5_5M,
> - ATH10K_HW_RATE_CCK_SP_2M,
> + ATH10K_HW_RATE_CCK_LP_11M = 0x40,
> + ATH10K_HW_RATE_CCK_LP_5_5M = 0x41,
> + ATH10K_HW_RATE_CCK_LP_2M = 0x42,
> + ATH10K_HW_RATE_CCK_LP_1M = 0x43,
> + ATH10K_HW_RATE_CCK_SP_11M = ATH10K_HW_RATE_CCK_LP_11M | 0x4,
> + ATH10K_HW_RATE_CCK_SP_5_5M = ATH10K_HW_RATE_CCK_LP_5_5M | 0x4,
> + ATH10K_HW_RATE_CCK_SP_2M = ATH10K_HW_RATE_CCK_LP_2M | 0x4,
> };
This breaks Rx CCK rate decoding/reporting. See code associated with
ath10k_mac_hw_rate_to_idx().
Michał
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ath10k: Fix CCK rate definitions.
@ 2015-09-21 7:33 ` Michal Kazior
0 siblings, 0 replies; 6+ messages in thread
From: Michal Kazior @ 2015-09-21 7:33 UTC (permalink / raw)
To: Ben Greear; +Cc: ath10k@lists.infradead.org, linux-wireless
On 16 September 2015 at 02:08, <greearb@candelatech.com> wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> The old values did NOT match what is found in 10.1.467
> firmware. I figure it is likely it is wrong for the others
> as well.
Does this fix anything at all?
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
> drivers/net/wireless/ath/ath10k/hw.h | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath10k/hw.h b/drivers/net/wireless/ath/ath10k/hw.h
> index 4c5eee4..710ca32 100644
> --- a/drivers/net/wireless/ath/ath10k/hw.h
> +++ b/drivers/net/wireless/ath/ath10k/hw.h
> @@ -202,13 +202,13 @@ enum ath10k_hw_rate_ofdm {
> };
>
> enum ath10k_hw_rate_cck {
> - ATH10K_HW_RATE_CCK_LP_11M = 0,
> - ATH10K_HW_RATE_CCK_LP_5_5M,
> - ATH10K_HW_RATE_CCK_LP_2M,
> - ATH10K_HW_RATE_CCK_LP_1M,
> - ATH10K_HW_RATE_CCK_SP_11M,
> - ATH10K_HW_RATE_CCK_SP_5_5M,
> - ATH10K_HW_RATE_CCK_SP_2M,
> + ATH10K_HW_RATE_CCK_LP_11M = 0x40,
> + ATH10K_HW_RATE_CCK_LP_5_5M = 0x41,
> + ATH10K_HW_RATE_CCK_LP_2M = 0x42,
> + ATH10K_HW_RATE_CCK_LP_1M = 0x43,
> + ATH10K_HW_RATE_CCK_SP_11M = ATH10K_HW_RATE_CCK_LP_11M | 0x4,
> + ATH10K_HW_RATE_CCK_SP_5_5M = ATH10K_HW_RATE_CCK_LP_5_5M | 0x4,
> + ATH10K_HW_RATE_CCK_SP_2M = ATH10K_HW_RATE_CCK_LP_2M | 0x4,
> };
This breaks Rx CCK rate decoding/reporting. See code associated with
ath10k_mac_hw_rate_to_idx().
Michał
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ath10k: Fix CCK rate definitions.
2015-09-21 7:33 ` Michal Kazior
@ 2015-09-21 15:51 ` Ben Greear
-1 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2015-09-21 15:51 UTC (permalink / raw)
To: Michal Kazior; +Cc: linux-wireless, ath10k@lists.infradead.org
On 09/21/2015 12:33 AM, Michal Kazior wrote:
> On 16 September 2015 at 02:08, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The old values did NOT match what is found in 10.1.467
>> firmware. I figure it is likely it is wrong for the others
>> as well.
>
> Does this fix anything at all?
I'm adding support to CT firmware to set arbitrary ratectrl
masks, and I'm using that enum for part of the implementation.
In the 4.0 kernel, the 'hw-value' for CCK rates is broken since the enum doesn't
match firmware.
I'll check what code is using that enum and see if it can be fixed. Otherwise,
I can fix it with a new enum with the values I need.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ath10k: Fix CCK rate definitions.
@ 2015-09-21 15:51 ` Ben Greear
0 siblings, 0 replies; 6+ messages in thread
From: Ben Greear @ 2015-09-21 15:51 UTC (permalink / raw)
To: Michal Kazior; +Cc: ath10k@lists.infradead.org, linux-wireless
On 09/21/2015 12:33 AM, Michal Kazior wrote:
> On 16 September 2015 at 02:08, <greearb@candelatech.com> wrote:
>> From: Ben Greear <greearb@candelatech.com>
>>
>> The old values did NOT match what is found in 10.1.467
>> firmware. I figure it is likely it is wrong for the others
>> as well.
>
> Does this fix anything at all?
I'm adding support to CT firmware to set arbitrary ratectrl
masks, and I'm using that enum for part of the implementation.
In the 4.0 kernel, the 'hw-value' for CCK rates is broken since the enum doesn't
match firmware.
I'll check what code is using that enum and see if it can be fixed. Otherwise,
I can fix it with a new enum with the values I need.
Thanks,
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-21 15:51 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 0:08 [PATCH] ath10k: Fix CCK rate definitions greearb
2015-09-16 0:08 ` greearb
2015-09-21 7:33 ` Michal Kazior
2015-09-21 7:33 ` Michal Kazior
2015-09-21 15:51 ` Ben Greear
2015-09-21 15:51 ` Ben Greear
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.