From: nsekhar@ti.com (Sekhar Nori)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: davinci: clock: Correct return values for API functions
Date: Tue, 22 Sep 2015 20:57:52 +0530 [thread overview]
Message-ID: <56017378.5060503@ti.com> (raw)
In-Reply-To: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com>
On Monday 14 September 2015 02:59 PM, Peter Ujfalusi wrote:
> Fix the values returned by the publicly used functions.
> These function should return 0 when they are called with clk == NULL in
> similar manner as the clock API does to avoid different behavior in drivers
> used by daVinci and other architectures.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Sekhar,
>
> This issue is visible when using generic drivers like ASoC simnple card for
> audio support.
> They rely on the fact that these functions will not return with error in case
> of clk == NULL.
Looks good. Will queue for v4.4. Some of the information below the tear
line could go into the commit text too, I think.
Thanks,
Sekhar
WARNING: multiple messages have this Message-ID (diff)
From: Sekhar Nori <nsekhar@ti.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: <khilman@deeprootsystems.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: davinci: clock: Correct return values for API functions
Date: Tue, 22 Sep 2015 20:57:52 +0530 [thread overview]
Message-ID: <56017378.5060503@ti.com> (raw)
In-Reply-To: <1442222979-9703-1-git-send-email-peter.ujfalusi@ti.com>
On Monday 14 September 2015 02:59 PM, Peter Ujfalusi wrote:
> Fix the values returned by the publicly used functions.
> These function should return 0 when they are called with clk == NULL in
> similar manner as the clock API does to avoid different behavior in drivers
> used by daVinci and other architectures.
>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi Sekhar,
>
> This issue is visible when using generic drivers like ASoC simnple card for
> audio support.
> They rely on the fact that these functions will not return with error in case
> of clk == NULL.
Looks good. Will queue for v4.4. Some of the information below the tear
line could go into the commit text too, I think.
Thanks,
Sekhar
next prev parent reply other threads:[~2015-09-22 15:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-14 9:29 [PATCH] ARM: davinci: clock: Correct return values for API functions Peter Ujfalusi
2015-09-14 9:29 ` Peter Ujfalusi
2015-09-22 15:27 ` Sekhar Nori [this message]
2015-09-22 15:27 ` Sekhar Nori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56017378.5060503@ti.com \
--to=nsekhar@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.