From: Weidong Wang <wangweidong1@huawei.com>
To: David Miller <davem@davemloft.net>
Cc: <sony.chacko@qlogic.com>, <Dept-HSGLinuxNICDev@qlogic.com>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<rui.xiang@huawei.com>
Subject: Re: [PATCH net-next] BNX2: fix a Null Pointer for stats_blk
Date: Thu, 24 Sep 2015 14:53:26 +0800 [thread overview]
Message-ID: <56039DE6.5020904@huawei.com> (raw)
In-Reply-To: <20150923.223436.53190852255282400.davem@davemloft.net>
On 2015/9/24 13:34, David Miller wrote:
> From: Weidong Wang <wangweidong1@huawei.com>
> Date: Thu, 24 Sep 2015 10:00:45 +0800
>
>> It does affect the intention. Although, the problem exists then makes the
>> system panic within some case.
>>
>> Do you have any idea about it?
>
> Allocate the statistics block at probe time so that this problem is
> impossible.
>
It is a good idea.
Yet, what is the intention of the dynamic to alloc/free stats_block?
what will be affected by allocating the statistics block.
Best Regards,
Weidong
>
next prev parent reply other threads:[~2015-09-24 6:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 12:42 [PATCH net-next] BNX2: fix a Null Pointer for stats_blk Weidong Wang
2015-09-23 22:31 ` David Miller
2015-09-24 2:00 ` Weidong Wang
2015-09-24 5:34 ` David Miller
2015-09-24 6:53 ` Weidong Wang [this message]
2015-09-28 7:01 ` [PATCH net-next v2] " Weidong Wang
2015-09-29 3:15 ` Weidong Wang
2015-09-29 3:18 ` [PATCH net-next v2 RESEND] " Weidong Wang
2015-09-30 4:10 ` David Miller
2015-10-08 10:03 ` [PATCH net-next v3] " Weidong Wang
2015-10-11 12:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56039DE6.5020904@huawei.com \
--to=wangweidong1@huawei.com \
--cc=Dept-HSGLinuxNICDev@qlogic.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rui.xiang@huawei.com \
--cc=sony.chacko@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.