All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
	linux-kernel@vger.kernel.org
Cc: Grygorii Strashko <grygorii.strashko@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 13:41:56 +0300	[thread overview]
Message-ID: <5603D374.3010806@ti.com> (raw)
In-Reply-To: <20150917142146.GA20176@goodgumbo.baconseed.org>


[-- Attachment #1.1: Type: text/plain, Size: 1108 bytes --]


On 17/09/15 17:21, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..ecbc9e5 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, dmm_of_match);
>  #endif
>  
>  struct platform_driver omap_dmm_driver = {

I think this one is not needed.

Tiler cannot be compiled as a module. Or, to be more exact, the tiler
driver is included in the omapdrm module, along with the main omapdrm
driver, which can be a module.

The autoloading should happen via omapdrm, and when that happens, tiler
driver comes along.

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
	<linux-kernel@vger.kernel.org>
Cc: David Airlie <airlied@linux.ie>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Grygorii Strashko <grygorii.strashko@linaro.org>,
	Rob Clark <robdclark@gmail.com>,
	<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 13:41:56 +0300	[thread overview]
Message-ID: <5603D374.3010806@ti.com> (raw)
In-Reply-To: <20150917142146.GA20176@goodgumbo.baconseed.org>

[-- Attachment #1: Type: text/plain, Size: 1108 bytes --]


On 17/09/15 17:21, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>  drivers/gpu/drm/omapdrm/omap_dmm_tiler.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> index 7841970..ecbc9e5 100644
> --- a/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> +++ b/drivers/gpu/drm/omapdrm/omap_dmm_tiler.c
> @@ -1014,6 +1014,7 @@ static const struct of_device_id dmm_of_match[] = {
>  	},
>  	{},
>  };
> +MODULE_DEVICE_TABLE(of, dmm_of_match);
>  #endif
>  
>  struct platform_driver omap_dmm_driver = {

I think this one is not needed.

Tiler cannot be compiled as a module. Or, to be more exact, the tiler
driver is included in the omapdrm module, along with the main omapdrm
driver, which can be a module.

The autoloading should happen via omapdrm, and when that happens, tiler
driver comes along.

 Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-24 10:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17 14:21 [PATCH 3/5] drm: omapdrm: tiler: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-24 10:41 ` Tomi Valkeinen [this message]
2015-09-24 10:41   ` Tomi Valkeinen
2015-09-24 15:36   ` Luis de Bethencourt
2015-09-24 15:43     ` Tomi Valkeinen
2015-09-24 15:43       ` Tomi Valkeinen
2015-09-24 16:06       ` Luis de Bethencourt
2015-09-24 16:10         ` Tomi Valkeinen
2015-09-24 16:10           ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603D374.3010806@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=grygorii.strashko@linaro.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis@debethencourt.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.