[meta-fsl-arm PATCH v2 0/5] Consolidate all i.MX base settings in imx-base.inc

[meta-fsl-arm PATCH v2 0/5] Consolidate all i.MX base settings in imx-base.inc

[Otavio Salvador]

This patchset removes the mxs-base.inc file so all i.MX related
based settings are consolidated in imx-base.inc file.

Changes in v2:
- Don't remove the ext4 from filesystem type list

Otavio Salvador (5):
  mxs-base.inc: Consolidate IMAGE_FSTYPES definition
  imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by
    default
  imx-base.inc, mxs-base.inc: Change default image to sdcard.gz
  imx-base.inc, mxs-base.inc: Use ext4 filesystem for images as default
  Move mxs-base.inc contents to imx-base.inc

 conf/machine/imx23evk.conf        |  6 ++----
 conf/machine/imx28evk.conf        |  6 ++----
 conf/machine/include/imx-base.inc | 38 ++++++++++++++++++++++++++++++++------
 conf/machine/include/mxs-base.inc | 39 ---------------------------------------
 4 files changed, 36 insertions(+), 53 deletions(-)
 delete mode 100644 conf/machine/include/mxs-base.inc

-- 
2.5.3

[meta-fsl-arm PATCH v2 1/5] mxs-base.inc: Consolidate IMAGE_FSTYPES definition

[Otavio Salvador]

The IMAGE_FSTYPES should have a default that uses the SD Card class
for image generation, using this all evaluation boards work out of box
using the provided .sdcard image.

The duplicated definition has been removed, affected machines are:

 - imx23evk
 - imx28evk

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2: None

 conf/machine/imx23evk.conf        | 3 ---
 conf/machine/imx28evk.conf        | 3 ---
 conf/machine/include/mxs-base.inc | 3 +++
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
index ecaef9a..1d5eaef 100644
--- a/conf/machine/imx23evk.conf
+++ b/conf/machine/imx23evk.conf
@@ -13,7 +13,4 @@ UBOOT_MACHINE = "mx23evk_config"
 
 KERNEL_DEVICETREE = "imx23-evk.dtb"
 
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
-
 MACHINE_FEATURES = "apm usbgadget usbhost vfat touchscreen"
diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
index 86123c3..5a55d72 100644
--- a/conf/machine/imx28evk.conf
+++ b/conf/machine/imx28evk.conf
@@ -17,9 +17,6 @@ UBOOT_CONFIG[sd-auart-console] = "mx28evk_auart_console_config,sdcard"
 
 KERNEL_DEVICETREE = "imx28-evk.dtb"
 
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
-
 SERIAL_CONSOLE = "115200 ttyAMA0"
 
 MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index d576dd3..b32e926 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -35,5 +35,8 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
 
 KERNEL_IMAGETYPE = "zImage"
 
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
+IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
+
 # Add the ability to specify _imx machines
 MACHINEOVERRIDES =. "imx:"
-- 
2.5.3

[meta-fsl-arm PATCH v2 2/5] imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by default

[Otavio Salvador]

The tar.bz2 is useful for people using NFS or generating the SD card
image byhand, those can enable this in the board file or in the
local.conf when needed. By the fault the SD card image should be the
only image built as it is the most commonly used one for initial
development.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2: None

 conf/machine/include/imx-base.inc | 2 +-
 conf/machine/include/mxs-base.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index e0a67c7..799067d 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -139,7 +139,7 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
 PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "tar.bz2 ext3 sdcard"
+IMAGE_FSTYPES ?= "ext3 sdcard"
 
 SERIAL_CONSOLE = "115200 ttymxc0"
 
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index b32e926..38450be 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -36,7 +36,7 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
 KERNEL_IMAGETYPE = "zImage"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
+IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard"
 
 # Add the ability to specify _imx machines
 MACHINEOVERRIDES =. "imx:"
-- 
2.5.3

[meta-fsl-arm PATCH v2 3/5] imx-base.inc, mxs-base.inc: Change default image to sdcard.gz

[Otavio Salvador]

The sdcard image can be compressed for easier download and transfer
between machine when doing the development. For it, we can change it
for sdcard.gz so the image generation backend handles the compression
steps.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2: None

 conf/machine/include/imx-base.inc | 2 +-
 conf/machine/include/mxs-base.inc | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 799067d..b0dca6a 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -139,7 +139,7 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
 PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "ext3 sdcard"
+IMAGE_FSTYPES ?= "ext3 sdcard.gz"
 
 SERIAL_CONSOLE = "115200 ttymxc0"
 
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index 38450be..230b776 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -36,7 +36,7 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
 KERNEL_IMAGETYPE = "zImage"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard"
+IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard.gz"
 
 # Add the ability to specify _imx machines
 MACHINEOVERRIDES =. "imx:"
-- 
2.5.3

[meta-fsl-arm PATCH v2 4/5] imx-base.inc, mxs-base.inc: Use ext4 filesystem for images as default

[Otavio Salvador]

The ext4 is now the default for images in OpenEmbedded-Core, we now
follow this change for all i.MX reference boards.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2:
- Don't remove the ext4 from filesystem type list

 conf/machine/include/imx-base.inc | 4 ++--
 conf/machine/include/mxs-base.inc | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index b0dca6a..094c9c5 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -138,8 +138,8 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
 
 PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
 
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "ext3 sdcard.gz"
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
+IMAGE_FSTYPES ?= "ext4 sdcard.gz"
 
 SERIAL_CONSOLE = "115200 ttymxc0"
 
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
index 230b776..6083fd5 100644
--- a/conf/machine/include/mxs-base.inc
+++ b/conf/machine/include/mxs-base.inc
@@ -35,8 +35,8 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
 
 KERNEL_IMAGETYPE = "zImage"
 
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
-IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard.gz"
+SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
+IMAGE_FSTYPES ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
 
 # Add the ability to specify _imx machines
 MACHINEOVERRIDES =. "imx:"
-- 
2.5.3

[meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Otavio Salvador]

The consolidation of all i.MX related base settings allow for a more
global view of the settings in place. Up to now, the i.MX 23 and i.MX
28 SoCs were using the mxs-base.inc file, causing fragmentation.

The changes necessary to keep all i.MX 23 and i.MX 28 reference boards
working properly has been done, some values need to be reworked to
apply to SoC families instead of global setting but the price for
clearness seems worth it.

Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---

Changes in v2: None

 conf/machine/imx23evk.conf        |  3 ++-
 conf/machine/imx28evk.conf        |  3 ++-
 conf/machine/include/imx-base.inc | 34 +++++++++++++++++++++++++++----
 conf/machine/include/mxs-base.inc | 42 ---------------------------------------
 4 files changed, 34 insertions(+), 48 deletions(-)
 delete mode 100644 conf/machine/include/mxs-base.inc

diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
index 1d5eaef..ddd6028 100644
--- a/conf/machine/imx23evk.conf
+++ b/conf/machine/imx23evk.conf
@@ -4,7 +4,8 @@
 #@DESCRIPTION: Machine configuration for Freescale i.MX23 Evaluation Kit
 #@MAINTAINER: Otavio Salvador <otavio@ossystems.com.br>
 
-include conf/machine/include/mxs-base.inc
+include conf/machine/include/imx-base.inc
+include conf/machine/include/tune-arm926ejs.inc
 
 SOC_FAMILY = "mxs:mx23"
 
diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
index 5a55d72..c05ad8f 100644
--- a/conf/machine/imx28evk.conf
+++ b/conf/machine/imx28evk.conf
@@ -4,7 +4,8 @@
 #@DESCRIPTION: Machine configuration for Freescale i.MX28 Evaluation Kit
 #@MAINTAINER: Otavio Salvador <otavio@ossystems.com.br>
 
-include conf/machine/include/mxs-base.inc
+include conf/machine/include/imx-base.inc
+include conf/machine/include/tune-arm926ejs.inc
 
 SOC_FAMILY = "mxs:mx28"
 
diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
index 094c9c5..a36ca2b 100644
--- a/conf/machine/include/imx-base.inc
+++ b/conf/machine/include/imx-base.inc
@@ -8,9 +8,26 @@ include conf/machine/include/soc-family.inc
 # Set specific make target and binary suffix
 PREFERRED_PROVIDER_u-boot ??= "u-boot-fslc"
 PREFERRED_PROVIDER_virtual/bootloader ??= "u-boot-fslc"
-UBOOT_MAKE_TARGET = "u-boot.imx"
-UBOOT_SUFFIX ?= "imx"
 
+UBOOT_MAKE_TARGET_mxs = "u-boot.sb"
+UBOOT_MAKE_TARGET_mx51 = "u-boot.imx"
+UBOOT_MAKE_TARGET_mx53 = "u-boot.imx"
+UBOOT_MAKE_TARGET_mx6 = "u-boot.imx"
+UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx"
+UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx"
+UBOOT_MAKE_TARGET_mx7 = "u-boot.imx"
+UBOOT_MAKE_TARGET_vf = "u-boot.imx"
+
+UBOOT_SUFFIX_mxs = "sb"
+UBOOT_SUFFIX_mx51 = "imx"
+UBOOT_SUFFIX_mx53 = "imx"
+UBOOT_SUFFIX_mx6 = "imx"
+UBOOT_SUFFIX_mx6sl = "imx"
+UBOOT_SUFFIX_mx6sx = "imx"
+UBOOT_SUFFIX_mx7 = "imx"
+UBOOT_SUFFIX_vf = "imx"
+
+UBOOT_ENTRYPOINT_mxs = "0x40008000"
 UBOOT_ENTRYPOINT_mx51  = "0x90008000"
 UBOOT_ENTRYPOINT_mx53  = "0x70008000"
 UBOOT_ENTRYPOINT_mx6  = "0x10008000"
@@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = ""
 
 # Handle default kernel
 IMX_DEFAULT_KERNEL = "linux-imx"
+IMX_DEFAULT_KERNEL_mxs = "linux-fslc"
 IMX_DEFAULT_KERNEL_mx5 = "linux-fslc"
 IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6"
 IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
@@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
 
 SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
 IMAGE_FSTYPES ?= "ext4 sdcard.gz"
-
-SERIAL_CONSOLE = "115200 ttymxc0"
+IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
+
+SERIAL_CONSOLE_mxs = "115200 ttyAMA0"
+SERIAL_CONSOLE_mx51 = "115200 ttymxc0"
+SERIAL_CONSOLE_mx53 = "115200 ttymxc0"
+SERIAL_CONSOLE_mx6 = "115200 ttymxc0"
+SERIAL_CONSOLE_mx6sl = "115200 ttymxc0"
+SERIAL_CONSOLE_mx6sx = "115200 ttymxc0"
+SERIAL_CONSOLE_mx7 = "115200 ttymxc0"
+SERIAL_CONSOLE_vf = "115200 ttymxc0"
 
 KERNEL_IMAGETYPE = "zImage"
 
diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
deleted file mode 100644
index 6083fd5..0000000
--- a/conf/machine/include/mxs-base.inc
+++ /dev/null
@@ -1,42 +0,0 @@
-# Provides the i.MXS common settings
-
-include conf/machine/include/fsl-default-settings.inc
-include conf/machine/include/fsl-default-versions.inc
-
-include conf/machine/include/soc-family.inc
-include conf/machine/include/tune-arm926ejs.inc
-
-SOC_FAMILY = "mxs"
-
-PREFERRED_PROVIDER_virtual/kernel ??= "linux-fslc"
-
-PREFERRED_PROVIDER_u-boot ??= "u-boot-fslc"
-PREFERRED_PROVIDER_virtual/bootloader ??= "u-boot-fslc"
-UBOOT_ENTRYPOINT = "0x40008000"
-UBOOT_MAKE_TARGET = "u-boot.sb"
-UBOOT_SUFFIX = "sb"
-
-PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
-XSERVER = "xserver-xorg \
-           xf86-input-evdev \
-           xf86-video-fbdev"
-
-# Sub-architecture support
-MACHINE_SOCARCH_SUFFIX ?= ""
-
-MACHINE_ARCH_FILTER = "virtual/kernel"
-
-INHERIT += "fsl-dynamic-packagearch"
-
-# Ship kernel modules
-MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
-
-SERIAL_CONSOLE = "115200 ttyAMA0"
-
-KERNEL_IMAGETYPE = "zImage"
-
-SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
-IMAGE_FSTYPES ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
-
-# Add the ability to specify _imx machines
-MACHINEOVERRIDES =. "imx:"
-- 
2.5.3

Re: [meta-fsl-arm PATCH v2 2/5] imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by default

[Fabio Estevam]

On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The tar.bz2 is useful for people using NFS or generating the SD card
> image byhand, those can enable this in the board file or in the
> local.conf when needed. By the fault the SD card image should be the

s/ By the fault/By default

Re: [meta-fsl-arm PATCH v2 2/5] imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by default

[Otavio Salvador]

On Thu, Sep 24, 2015 at 9:51 AM, Fabio Estevam <festevam@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The tar.bz2 is useful for people using NFS or generating the SD card
>> image byhand, those can enable this in the board file or in the
>> local.conf when needed. By the fault the SD card image should be the
>
> s/ By the fault/By default

Ouch! Fixed locally.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm PATCH v2 1/5] mxs-base.inc: Consolidate IMAGE_FSTYPES definition

[Daiane Angolini]

On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The IMAGE_FSTYPES should have a default that uses the SD Card class
> for image generation, using this all evaluation boards work out of box
> using the provided .sdcard image.

The default value for IMAGE_FSTYPES including SDCard class enable all
machine to work out of the box using the .sdcard image

> The duplicated definition has been removed, affected machines are:

The removed duplication affected the following machines

>
>  - imx23evk
>  - imx28evk

Your commit log is not bad, see if you like my suggestions. If not I
think it's not a problem if you use the original text

Daiane


>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> Changes in v2: None
>
>  conf/machine/imx23evk.conf        | 3 ---
>  conf/machine/imx28evk.conf        | 3 ---
>  conf/machine/include/mxs-base.inc | 3 +++
>  3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
> index ecaef9a..1d5eaef 100644
> --- a/conf/machine/imx23evk.conf
> +++ b/conf/machine/imx23evk.conf
> @@ -13,7 +13,4 @@ UBOOT_MACHINE = "mx23evk_config"
>
>  KERNEL_DEVICETREE = "imx23-evk.dtb"
>
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> -
>  MACHINE_FEATURES = "apm usbgadget usbhost vfat touchscreen"
> diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
> index 86123c3..5a55d72 100644
> --- a/conf/machine/imx28evk.conf
> +++ b/conf/machine/imx28evk.conf
> @@ -17,9 +17,6 @@ UBOOT_CONFIG[sd-auart-console] = "mx28evk_auart_console_config,sdcard"
>
>  KERNEL_DEVICETREE = "imx28-evk.dtb"
>
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> -
>  SERIAL_CONSOLE = "115200 ttyAMA0"
>
>  MACHINE_FEATURES = "apm usbgadget usbhost vfat alsa touchscreen"
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index d576dd3..b32e926 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -35,5 +35,8 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
>
>  KERNEL_IMAGETYPE = "zImage"
>
> +SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> +IMAGE_FSTYPES ?= "tar.bz2 ext3 uboot.mxsboot-sdcard sdcard"
> +
>  # Add the ability to specify _imx machines
>  MACHINEOVERRIDES =. "imx:"
> --
> 2.5.3
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-arm PATCH v2 1/5] mxs-base.inc: Consolidate IMAGE_FSTYPES definition

[Otavio Salvador]

On Thu, Sep 24, 2015 at 10:17 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The IMAGE_FSTYPES should have a default that uses the SD Card class
>> for image generation, using this all evaluation boards work out of box
>> using the provided .sdcard image.
>
> The default value for IMAGE_FSTYPES including SDCard class enable all
> machine to work out of the box using the .sdcard image
>
>> The duplicated definition has been removed, affected machines are:
>
> The removed duplication affected the following machines
>
>>
>>  - imx23evk
>>  - imx28evk
>
> Your commit log is not bad, see if you like my suggestions. If not I
> think it's not a problem if you use the original text

It is nicer indeed; applied locally.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm PATCH v2 3/5] imx-base.inc, mxs-base.inc: Change default image to sdcard.gz

[Daiane Angolini]

On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The sdcard image can be compressed for easier download and transfer
> between machine when doing the development. For it, we can change it
> for sdcard.gz so the image generation backend handles the compression
> steps.

--
Replace .sdcard image to sdcard.gz image as a default image type for
all machines.

The SDCard class has the feature of compress the generated .sdcard image.
It can be used to ease the exchange of this image among developers or machines.
--

My suggestion follow the order WHAT -> WHY

>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> Changes in v2: None
>
>  conf/machine/include/imx-base.inc | 2 +-
>  conf/machine/include/mxs-base.inc | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index 799067d..b0dca6a 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -139,7 +139,7 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>  PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>
>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "ext3 sdcard"
> +IMAGE_FSTYPES ?= "ext3 sdcard.gz"

I understand it's the best for a server. But it's not good for my
local development.

It will add 2 useless steps in my normal development cycle: 1-
compress 2- uncompress

Are we assuming  majority of FSL Community BSP is client of a server,
or are we assuming they are individual developers?


Daiane


>
>  SERIAL_CONSOLE = "115200 ttymxc0"
>
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> index 38450be..230b776 100644
> --- a/conf/machine/include/mxs-base.inc
> +++ b/conf/machine/include/mxs-base.inc
> @@ -36,7 +36,7 @@ SERIAL_CONSOLE = "115200 ttyAMA0"
>  KERNEL_IMAGETYPE = "zImage"
>
>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
> -IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard"
> +IMAGE_FSTYPES ?= "ext3 uboot.mxsboot-sdcard sdcard.gz"
>
>  # Add the ability to specify _imx machines
>  MACHINEOVERRIDES =. "imx:"
> --
> 2.5.3
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-arm PATCH v2 3/5] imx-base.inc, mxs-base.inc: Change default image to sdcard.gz

[Otavio Salvador]

On Thu, Sep 24, 2015 at 10:26 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The sdcard image can be compressed for easier download and transfer
>> between machine when doing the development. For it, we can change it
>> for sdcard.gz so the image generation backend handles the compression
>> steps.
>
> --
> Replace .sdcard image to sdcard.gz image as a default image type for
> all machines.
>
> The SDCard class has the feature of compress the generated .sdcard image.
> It can be used to ease the exchange of this image among developers or machines.
> --
>
> My suggestion follow the order WHAT -> WHY

Great. I applied locally.

>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>> ---
>>
>> Changes in v2: None
>>
>>  conf/machine/include/imx-base.inc | 2 +-
>>  conf/machine/include/mxs-base.inc | 2 +-
>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
>> index 799067d..b0dca6a 100644
>> --- a/conf/machine/include/imx-base.inc
>> +++ b/conf/machine/include/imx-base.inc
>> @@ -139,7 +139,7 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>>  PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>>
>>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>> -IMAGE_FSTYPES ?= "ext3 sdcard"
>> +IMAGE_FSTYPES ?= "ext3 sdcard.gz"
>
> I understand it's the best for a server. But it's not good for my
> local development.
>
> It will add 2 useless steps in my normal development cycle: 1-
> compress 2- uncompress
>
> Are we assuming  majority of FSL Community BSP is client of a server,
> or are we assuming they are individual developers?

This is a valid point, indeed.

I usually do:

zcat image.sdcard.gz | dd of=/dev/xxx bs=4M

Do you think we ought to keep the normal .sdcard as default?

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Daiane Angolini]

On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
<otavio@ossystems.com.br> wrote:
> The consolidation of all i.MX related base settings allow for a more
> global view of the settings in place. Up to now, the i.MX 23 and i.MX
> 28 SoCs were using the mxs-base.inc file, causing fragmentation.
>
> The changes necessary to keep all i.MX 23 and i.MX 28 reference boards
> working properly has been done, some values need to be reworked to

The consolidation of all i.MX related base settings allows a more
global view of the settings in place.

One of the causes of this patch is the fragmentation caused by i.MX23
and i.MX28 SoCs using mxs-base.inc.

The changes needed to get i.MX23 and i.MX28  SoCs working have been
included in imx-base.inc file already, ...


> apply to SoC families instead of global setting but the price for
> clearness seems worth it.

This piece I don't understand. Are additional changes needed for
future (#FIXME)? Or you are still talking about the motivation of this
patch?


Daiane

>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
>
> Changes in v2: None
>
>  conf/machine/imx23evk.conf        |  3 ++-
>  conf/machine/imx28evk.conf        |  3 ++-
>  conf/machine/include/imx-base.inc | 34 +++++++++++++++++++++++++++----
>  conf/machine/include/mxs-base.inc | 42 ---------------------------------------
>  4 files changed, 34 insertions(+), 48 deletions(-)
>  delete mode 100644 conf/machine/include/mxs-base.inc
>
> diff --git a/conf/machine/imx23evk.conf b/conf/machine/imx23evk.conf
> index 1d5eaef..ddd6028 100644
> --- a/conf/machine/imx23evk.conf
> +++ b/conf/machine/imx23evk.conf
> @@ -4,7 +4,8 @@
>  #@DESCRIPTION: Machine configuration for Freescale i.MX23 Evaluation Kit
>  #@MAINTAINER: Otavio Salvador <otavio@ossystems.com.br>
>
> -include conf/machine/include/mxs-base.inc
> +include conf/machine/include/imx-base.inc
> +include conf/machine/include/tune-arm926ejs.inc
>
>  SOC_FAMILY = "mxs:mx23"
>
> diff --git a/conf/machine/imx28evk.conf b/conf/machine/imx28evk.conf
> index 5a55d72..c05ad8f 100644
> --- a/conf/machine/imx28evk.conf
> +++ b/conf/machine/imx28evk.conf
> @@ -4,7 +4,8 @@
>  #@DESCRIPTION: Machine configuration for Freescale i.MX28 Evaluation Kit
>  #@MAINTAINER: Otavio Salvador <otavio@ossystems.com.br>
>
> -include conf/machine/include/mxs-base.inc
> +include conf/machine/include/imx-base.inc
> +include conf/machine/include/tune-arm926ejs.inc
>
>  SOC_FAMILY = "mxs:mx28"
>
> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
> index 094c9c5..a36ca2b 100644
> --- a/conf/machine/include/imx-base.inc
> +++ b/conf/machine/include/imx-base.inc
> @@ -8,9 +8,26 @@ include conf/machine/include/soc-family.inc
>  # Set specific make target and binary suffix
>  PREFERRED_PROVIDER_u-boot ??= "u-boot-fslc"
>  PREFERRED_PROVIDER_virtual/bootloader ??= "u-boot-fslc"
> -UBOOT_MAKE_TARGET = "u-boot.imx"
> -UBOOT_SUFFIX ?= "imx"
>
> +UBOOT_MAKE_TARGET_mxs = "u-boot.sb"
> +UBOOT_MAKE_TARGET_mx51 = "u-boot.imx"
> +UBOOT_MAKE_TARGET_mx53 = "u-boot.imx"
> +UBOOT_MAKE_TARGET_mx6 = "u-boot.imx"
> +UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx"
> +UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx"

Why are you duplicating for sl and sx?

I don't see imx6ul


> +UBOOT_MAKE_TARGET_mx7 = "u-boot.imx"
> +UBOOT_MAKE_TARGET_vf = "u-boot.imx"
> +
> +UBOOT_SUFFIX_mxs = "sb"
> +UBOOT_SUFFIX_mx51 = "imx"
> +UBOOT_SUFFIX_mx53 = "imx"
> +UBOOT_SUFFIX_mx6 = "imx"
> +UBOOT_SUFFIX_mx6sl = "imx"
> +UBOOT_SUFFIX_mx6sx = "imx"

Why are you duplicating for sl and sx?

I don't see imx6ul


> +UBOOT_SUFFIX_mx7 = "imx"
> +UBOOT_SUFFIX_vf = "imx"
> +
> +UBOOT_ENTRYPOINT_mxs = "0x40008000"
>  UBOOT_ENTRYPOINT_mx51  = "0x90008000"
>  UBOOT_ENTRYPOINT_mx53  = "0x70008000"
>  UBOOT_ENTRYPOINT_mx6  = "0x10008000"
> @@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = ""
>
>  # Handle default kernel
>  IMX_DEFAULT_KERNEL = "linux-imx"
> +IMX_DEFAULT_KERNEL_mxs = "linux-fslc"
>  IMX_DEFAULT_KERNEL_mx5 = "linux-fslc"
>  IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6"
>  IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
> @@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>
>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
>  IMAGE_FSTYPES ?= "ext4 sdcard.gz"
> -
> -SERIAL_CONSOLE = "115200 ttymxc0"
> +IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
> +
> +SERIAL_CONSOLE_mxs = "115200 ttyAMA0"
> +SERIAL_CONSOLE_mx51 = "115200 ttymxc0"
> +SERIAL_CONSOLE_mx53 = "115200 ttymxc0"
> +SERIAL_CONSOLE_mx6 = "115200 ttymxc0"
> +SERIAL_CONSOLE_mx6sl = "115200 ttymxc0"
> +SERIAL_CONSOLE_mx6sx = "115200 ttymxc0"
> +SERIAL_CONSOLE_mx7 = "115200 ttymxc0"
> +SERIAL_CONSOLE_vf = "115200 ttymxc0"

Can you, please, explain why we cannot have SERIAL_CONSOLE any more
and only override for mxs?

And I cannot see imx6ul


Daiane

>
>  KERNEL_IMAGETYPE = "zImage"
>
> diff --git a/conf/machine/include/mxs-base.inc b/conf/machine/include/mxs-base.inc
> deleted file mode 100644
> index 6083fd5..0000000
> --- a/conf/machine/include/mxs-base.inc
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -# Provides the i.MXS common settings
> -
> -include conf/machine/include/fsl-default-settings.inc
> -include conf/machine/include/fsl-default-versions.inc
> -
> -include conf/machine/include/soc-family.inc
> -include conf/machine/include/tune-arm926ejs.inc
> -
> -SOC_FAMILY = "mxs"
> -
> -PREFERRED_PROVIDER_virtual/kernel ??= "linux-fslc"
> -
> -PREFERRED_PROVIDER_u-boot ??= "u-boot-fslc"
> -PREFERRED_PROVIDER_virtual/bootloader ??= "u-boot-fslc"
> -UBOOT_ENTRYPOINT = "0x40008000"
> -UBOOT_MAKE_TARGET = "u-boot.sb"
> -UBOOT_SUFFIX = "sb"
> -
> -PREFERRED_PROVIDER_virtual/xserver = "xserver-xorg"
> -XSERVER = "xserver-xorg \
> -           xf86-input-evdev \
> -           xf86-video-fbdev"
> -
> -# Sub-architecture support
> -MACHINE_SOCARCH_SUFFIX ?= ""
> -
> -MACHINE_ARCH_FILTER = "virtual/kernel"
> -
> -INHERIT += "fsl-dynamic-packagearch"
> -
> -# Ship kernel modules
> -MACHINE_EXTRA_RRECOMMENDS = "kernel-modules"
> -
> -SERIAL_CONSOLE = "115200 ttyAMA0"
> -
> -KERNEL_IMAGETYPE = "zImage"
> -
> -SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
> -IMAGE_FSTYPES ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
> -
> -# Add the ability to specify _imx machines
> -MACHINEOVERRIDES =. "imx:"
> --
> 2.5.3
>
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-arm PATCH v2 2/5] imx-base.inc, mxs-base.inc: Stop generating tar.bz2 image tarball by default

[Daiane Angolini]

On Thu, Sep 24, 2015 at 9:55 AM, Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
> On Thu, Sep 24, 2015 at 9:51 AM, Fabio Estevam <festevam@gmail.com> wrote:
>> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> The tar.bz2 is useful for people using NFS or generating the SD card
>>> image byhand, those can enable this in the board file or in the
>>> local.conf when needed. By the fault the SD card image should be the
>>
>> s/ By the fault/By default
>
> Ouch! Fixed locally.

LOL


>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750
> --
> _______________________________________________
> meta-freescale mailing list
> meta-freescale@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale

Re: [meta-fsl-arm PATCH v2 3/5] imx-base.inc, mxs-base.inc: Change default image to sdcard.gz

[Daiane Angolini]

On Thu, Sep 24, 2015 at 10:31 AM, Otavio Salvador
<otavio.salvador@ossystems.com.br> wrote:
> On Thu, Sep 24, 2015 at 10:26 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> The sdcard image can be compressed for easier download and transfer
>>> between machine when doing the development. For it, we can change it
>>> for sdcard.gz so the image generation backend handles the compression
>>> steps.
>>
>> --
>> Replace .sdcard image to sdcard.gz image as a default image type for
>> all machines.
>>
>> The SDCard class has the feature of compress the generated .sdcard image.
>> It can be used to ease the exchange of this image among developers or machines.
>> --
>>
>> My suggestion follow the order WHAT -> WHY
>
> Great. I applied locally.
>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> ---
>>>
>>> Changes in v2: None
>>>
>>>  conf/machine/include/imx-base.inc | 2 +-
>>>  conf/machine/include/mxs-base.inc | 2 +-
>>>  2 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/conf/machine/include/imx-base.inc b/conf/machine/include/imx-base.inc
>>> index 799067d..b0dca6a 100644
>>> --- a/conf/machine/include/imx-base.inc
>>> +++ b/conf/machine/include/imx-base.inc
>>> @@ -139,7 +139,7 @@ IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>>>  PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>>>
>>>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext3"
>>> -IMAGE_FSTYPES ?= "ext3 sdcard"
>>> +IMAGE_FSTYPES ?= "ext3 sdcard.gz"
>>
>> I understand it's the best for a server. But it's not good for my
>> local development.
>>
>> It will add 2 useless steps in my normal development cycle: 1-
>> compress 2- uncompress
>>
>> Are we assuming  majority of FSL Community BSP is client of a server,
>> or are we assuming they are individual developers?
>
> This is a valid point, indeed.
>
> I usually do:
>
> zcat image.sdcard.gz | dd of=/dev/xxx bs=4M
>
> Do you think we ought to keep the normal .sdcard as default?

If I were the only person in the world I would never change to .gz

and I would say "servers, you change it on local.conf"

I can accept it though......


Daiane

>
> --
> Otavio Salvador                             O.S. Systems
> http://www.ossystems.com.br        http://code.ossystems.com.br
> Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Otavio Salvador]

On Thu, Sep 24, 2015 at 10:47 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
> <otavio@ossystems.com.br> wrote:
>> The consolidation of all i.MX related base settings allow for a more
>> global view of the settings in place. Up to now, the i.MX 23 and i.MX
>> 28 SoCs were using the mxs-base.inc file, causing fragmentation.
>>
>> The changes necessary to keep all i.MX 23 and i.MX 28 reference boards
>> working properly has been done, some values need to be reworked to
>
> The consolidation of all i.MX related base settings allows a more
> global view of the settings in place.
>
> One of the causes of this patch is the fragmentation caused by i.MX23
> and i.MX28 SoCs using mxs-base.inc.
>
> The changes needed to get i.MX23 and i.MX28  SoCs working have been
> included in imx-base.inc file already, ...

I reworked this as:

---
The consolidation of all i.MX related base settings allows a more
global view of the settings in place.

One of the causes of this patch is the fragmentation caused by i.MX23
and i.MX28 SoCs using mxs-base.inc.

The changes needed to get i.MX23 and i.MX28 SoCs working have been
included in imx-base.inc file already and some values required rework
to apply to specific SoC families to avoid regressions.
---

Better?

>> apply to SoC families instead of global setting but the price for
>> clearness seems worth it.
>
> This piece I don't understand. Are additional changes needed for
> future (#FIXME)? Or you are still talking about the motivation of this
> patch?

No; just explaining there are changes to avoid regressions. I reworked
the commit log.

...
>> +UBOOT_MAKE_TARGET_mxs = "u-boot.sb"
>> +UBOOT_MAKE_TARGET_mx51 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx53 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx"
>
> Why are you duplicating for sl and sx?
>
> I don't see imx6ul

My fault; I will expand it.

>> +UBOOT_MAKE_TARGET_mx7 = "u-boot.imx"
>> +UBOOT_MAKE_TARGET_vf = "u-boot.imx"
>> +
>> +UBOOT_SUFFIX_mxs = "sb"
>> +UBOOT_SUFFIX_mx51 = "imx"
>> +UBOOT_SUFFIX_mx53 = "imx"
>> +UBOOT_SUFFIX_mx6 = "imx"
>> +UBOOT_SUFFIX_mx6sl = "imx"
>> +UBOOT_SUFFIX_mx6sx = "imx"
>
> Why are you duplicating for sl and sx?
>
> I don't see imx6ul

Ditto.

>> +UBOOT_SUFFIX_mx7 = "imx"
>> +UBOOT_SUFFIX_vf = "imx"
>> +
>> +UBOOT_ENTRYPOINT_mxs = "0x40008000"
>>  UBOOT_ENTRYPOINT_mx51  = "0x90008000"
>>  UBOOT_ENTRYPOINT_mx53  = "0x70008000"
>>  UBOOT_ENTRYPOINT_mx6  = "0x10008000"
>> @@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = ""
>>
>>  # Handle default kernel
>>  IMX_DEFAULT_KERNEL = "linux-imx"
>> +IMX_DEFAULT_KERNEL_mxs = "linux-fslc"
>>  IMX_DEFAULT_KERNEL_mx5 = "linux-fslc"
>>  IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6"
>>  IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>> @@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>>
>>  SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
>>  IMAGE_FSTYPES ?= "ext4 sdcard.gz"
>> -
>> -SERIAL_CONSOLE = "115200 ttymxc0"
>> +IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
>> +
>> +SERIAL_CONSOLE_mxs = "115200 ttyAMA0"
>> +SERIAL_CONSOLE_mx51 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx53 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6sl = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx6sx = "115200 ttymxc0"
>> +SERIAL_CONSOLE_mx7 = "115200 ttymxc0"
>> +SERIAL_CONSOLE_vf = "115200 ttymxc0"
>
> Can you, please, explain why we cannot have SERIAL_CONSOLE any more
> and only override for mxs?

I will rework this.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750

Re: [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Gary Thomas]

On 2015-09-24 07:59, Otavio Salvador wrote:
> On Thu, Sep 24, 2015 at 10:47 AM, Daiane Angolini <daiane.list@gmail.com> wrote:
>> On Thu, Sep 24, 2015 at 9:32 AM, Otavio Salvador
>> <otavio@ossystems.com.br> wrote:
>>> The consolidation of all i.MX related base settings allow for a more
>>> global view of the settings in place. Up to now, the i.MX 23 and i.MX
>>> 28 SoCs were using the mxs-base.inc file, causing fragmentation.
>>>
>>> The changes necessary to keep all i.MX 23 and i.MX 28 reference boards
>>> working properly has been done, some values need to be reworked to
>>
>> The consolidation of all i.MX related base settings allows a more
>> global view of the settings in place.
>>
>> One of the causes of this patch is the fragmentation caused by i.MX23
>> and i.MX28 SoCs using mxs-base.inc.
>>
>> The changes needed to get i.MX23 and i.MX28  SoCs working have been
>> included in imx-base.inc file already, ...
>
> I reworked this as:
>
> ---
> The consolidation of all i.MX related base settings allows a more
> global view of the settings in place.
>
> One of the causes of this patch is the fragmentation caused by i.MX23

One of the reasons for this patch ...

> and i.MX28 SoCs using mxs-base.inc.
>
> The changes needed to get i.MX23 and i.MX28 SoCs working have been
> included in imx-base.inc file already and some values required rework
> to apply to specific SoC families to avoid regressions.
> ---
>
> Better?
>
>>> apply to SoC families instead of global setting but the price for
>>> clearness seems worth it.
>>
>> This piece I don't understand. Are additional changes needed for
>> future (#FIXME)? Or you are still talking about the motivation of this
>> patch?
>
> No; just explaining there are changes to avoid regressions. I reworked
> the commit log.
>
> ...
>>> +UBOOT_MAKE_TARGET_mxs = "u-boot.sb"
>>> +UBOOT_MAKE_TARGET_mx51 = "u-boot.imx"
>>> +UBOOT_MAKE_TARGET_mx53 = "u-boot.imx"
>>> +UBOOT_MAKE_TARGET_mx6 = "u-boot.imx"
>>> +UBOOT_MAKE_TARGET_mx6sl = "u-boot.imx"
>>> +UBOOT_MAKE_TARGET_mx6sx = "u-boot.imx"
>>
>> Why are you duplicating for sl and sx?
>>
>> I don't see imx6ul
>
> My fault; I will expand it.
>
>>> +UBOOT_MAKE_TARGET_mx7 = "u-boot.imx"
>>> +UBOOT_MAKE_TARGET_vf = "u-boot.imx"
>>> +
>>> +UBOOT_SUFFIX_mxs = "sb"
>>> +UBOOT_SUFFIX_mx51 = "imx"
>>> +UBOOT_SUFFIX_mx53 = "imx"
>>> +UBOOT_SUFFIX_mx6 = "imx"
>>> +UBOOT_SUFFIX_mx6sl = "imx"
>>> +UBOOT_SUFFIX_mx6sx = "imx"
>>
>> Why are you duplicating for sl and sx?
>>
>> I don't see imx6ul
>
> Ditto.
>
>>> +UBOOT_SUFFIX_mx7 = "imx"
>>> +UBOOT_SUFFIX_vf = "imx"
>>> +
>>> +UBOOT_ENTRYPOINT_mxs = "0x40008000"
>>>   UBOOT_ENTRYPOINT_mx51  = "0x90008000"
>>>   UBOOT_ENTRYPOINT_mx53  = "0x70008000"
>>>   UBOOT_ENTRYPOINT_mx6  = "0x10008000"
>>> @@ -132,6 +149,7 @@ PREFERRED_PROVIDER_virtual/libg2d_mx6ul = ""
>>>
>>>   # Handle default kernel
>>>   IMX_DEFAULT_KERNEL = "linux-imx"
>>> +IMX_DEFAULT_KERNEL_mxs = "linux-fslc"
>>>   IMX_DEFAULT_KERNEL_mx5 = "linux-fslc"
>>>   IMX_DEFAULT_KERNEL_mx6 = "linux-fslc-mx6"
>>>   IMX_DEFAULT_KERNEL_mx6ul = "linux-imx"
>>> @@ -140,8 +158,16 @@ PREFERRED_PROVIDER_virtual/kernel ??= "${IMX_DEFAULT_KERNEL}"
>>>
>>>   SDCARD_ROOTFS ?= "${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.ext4"
>>>   IMAGE_FSTYPES ?= "ext4 sdcard.gz"
>>> -
>>> -SERIAL_CONSOLE = "115200 ttymxc0"
>>> +IMAGE_FSTYPES_mxs ?= "ext4 uboot.mxsboot-sdcard sdcard.gz"
>>> +
>>> +SERIAL_CONSOLE_mxs = "115200 ttyAMA0"
>>> +SERIAL_CONSOLE_mx51 = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_mx53 = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_mx6 = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_mx6sl = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_mx6sx = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_mx7 = "115200 ttymxc0"
>>> +SERIAL_CONSOLE_vf = "115200 ttymxc0"
>>
>> Can you, please, explain why we cannot have SERIAL_CONSOLE any more
>> and only override for mxs?
>
> I will rework this.
>

-- 
------------------------------------------------------------
Gary Thomas                 |  Consulting for the
MLB Associates              |    Embedded world
------------------------------------------------------------

Re: [meta-fsl-arm PATCH v2 5/5] Move mxs-base.inc contents to imx-base.inc

[Otavio Salvador]

On Thu, Sep 24, 2015 at 11:02 AM, Gary Thomas <gary@mlbassoc.com> wrote:
>> One of the causes of this patch is the fragmentation caused by i.MX23
>
>
> One of the reasons for this patch ...

I applied this locally as I sent v3. If I end doing a v4 this is
included otherwise I apply it when merging.

-- 
Otavio Salvador                             O.S. Systems
http://www.ossystems.com.br        http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854            Mobile: +1 (347) 903-9750