From: Tero Kristo <t-kristo@ti.com>
To: Lokesh Vutla <a0131933@ti.com>,
linux-omap@vger.kernel.org, tony@atomide.com, s-anna@ti.com,
paul@pwsan.com
Cc: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 07/17] ARM: dts: am4372: add reset data
Date: Mon, 28 Sep 2015 11:11:08 +0300 [thread overview]
Message-ID: <5608F61C.30508@ti.com> (raw)
In-Reply-To: <560544B3.3090805@ti.com>
On 09/25/2015 03:57 PM, Lokesh Vutla wrote:
> Hi Tero,
>
> On Thursday 24 September 2015 07:56 PM, Tero Kristo wrote:
>> Add reset data for pruss, gfx, wkup-m3 and system reset.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index 0447c04a..fcc8d31 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -116,12 +116,15 @@
>> reg-names = "umem", "dmem";
>> ti,hwmods = "wkup_m3";
>> ti,pm-firmware = "am335x-pm-firmware.elf";
>> + reset-names = "wkup_m3";
>> + resets = <&prcm 0x2000 0x10 3 0x14 5>;
>> };
>>
>> prcm: prcm@1f0000 {
>> compatible = "ti,am4-prcm";
>> reg = <0x1f0000 0x11000>;
>> interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>> + #reset-cells = <5>;
>>
>> prcm_clocks: clocks {
>> #address-cells = <1>;
>> @@ -130,6 +133,12 @@
>>
>> prcm_clockdomains: clockdomains {
>> };
>> +
>> + system_reset: system_reset {
>> + compatible = "ti,system-reset";
>> + reset-names = "system";
>> + reset-cells = <&prcm 0x4000 0 0 4 0>;
> This should be resets instead of reset-cells.
> With this change, reboot is functional on AM437x GP evm.
Oops, nasty typo there. Thanks for catching.
-Tero
>
> Thanks and regards,
> Lokesh
>
WARNING: multiple messages have this Message-ID (diff)
From: t-kristo@ti.com (Tero Kristo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 07/17] ARM: dts: am4372: add reset data
Date: Mon, 28 Sep 2015 11:11:08 +0300 [thread overview]
Message-ID: <5608F61C.30508@ti.com> (raw)
In-Reply-To: <560544B3.3090805@ti.com>
On 09/25/2015 03:57 PM, Lokesh Vutla wrote:
> Hi Tero,
>
> On Thursday 24 September 2015 07:56 PM, Tero Kristo wrote:
>> Add reset data for pruss, gfx, wkup-m3 and system reset.
>>
>> Signed-off-by: Tero Kristo <t-kristo@ti.com>
>> ---
>> arch/arm/boot/dts/am4372.dtsi | 24 ++++++++++++++++++++++++
>> 1 file changed, 24 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index 0447c04a..fcc8d31 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -116,12 +116,15 @@
>> reg-names = "umem", "dmem";
>> ti,hwmods = "wkup_m3";
>> ti,pm-firmware = "am335x-pm-firmware.elf";
>> + reset-names = "wkup_m3";
>> + resets = <&prcm 0x2000 0x10 3 0x14 5>;
>> };
>>
>> prcm: prcm at 1f0000 {
>> compatible = "ti,am4-prcm";
>> reg = <0x1f0000 0x11000>;
>> interrupts = <GIC_SPI 11 IRQ_TYPE_LEVEL_HIGH>;
>> + #reset-cells = <5>;
>>
>> prcm_clocks: clocks {
>> #address-cells = <1>;
>> @@ -130,6 +133,12 @@
>>
>> prcm_clockdomains: clockdomains {
>> };
>> +
>> + system_reset: system_reset {
>> + compatible = "ti,system-reset";
>> + reset-names = "system";
>> + reset-cells = <&prcm 0x4000 0 0 4 0>;
> This should be resets instead of reset-cells.
> With this change, reboot is functional on AM437x GP evm.
Oops, nasty typo there. Thanks for catching.
-Tero
>
> Thanks and regards,
> Lokesh
>
next prev parent reply other threads:[~2015-09-28 8:11 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-24 14:26 [PATCH 00/17] ARM: OMAP2+: reset controller support Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 01/17] ARM: OMAP2+: PRM: add support for reset controller Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-10-06 12:06 ` Tony Lindgren
2015-10-06 12:06 ` Tony Lindgren
2015-11-30 17:09 ` Tony Lindgren
2015-11-30 17:09 ` Tony Lindgren
2015-09-24 14:26 ` [PATCH 02/17] ARM: OMAP2+: hwmod: parse also soc hierarchy for hwmod compatible nodes Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 03/17] ARM: dts: omap3: add reset data Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 04/17] ARM: dts: omap4: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 05/17] ARM: dts: omap5: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 06/17] ARM: dts: dra7: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 07/17] ARM: dts: am4372: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-25 12:57 ` Lokesh Vutla
2015-09-25 12:57 ` Lokesh Vutla
2015-09-28 8:11 ` Tero Kristo [this message]
2015-09-28 8:11 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 08/17] ARM: dts: am33xx: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 09/17] ARM: dts: OMAP24xx: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 10/17] ARM: OMAP2+: hwmod: parse reset information from DT Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 11/17] ARM: OMAP2+: use system reset info from device tree data Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 12/17] ARM: OMAP4: hwmod_data: remove reset data Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 13/17] ARM: OMAP5: " Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 14/17] ARM: OMAP2: hwmod: AMx3xx: remove redundant reset info Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 15/17] ARM: OMAP24xx: hwmod: remove reset data from hwmod database Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 16/17] ARM: OMAP2+: hwmod: remove obsolete support for some hardreset logic Tero Kristo
2015-09-24 14:26 ` Tero Kristo
2015-09-24 14:26 ` [PATCH 17/17] ARM: OMAP2+: PRM: remove redundant system reset code Tero Kristo
2015-09-24 14:26 ` Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5608F61C.30508@ti.com \
--to=t-kristo@ti.com \
--cc=a0131933@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=s-anna@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.