All of lore.kernel.org
 help / color / mirror / Atom feed
From: thunder.leizhen@huawei.com (Leizhen (ThunderTown))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date: Mon, 28 Sep 2015 16:41:19 +0800	[thread overview]
Message-ID: <5608FD2F.1000105@huawei.com> (raw)
In-Reply-To: <CAKv+Gu_uFi03XVf5mX9Qy7eH=m1Q1ufpBNN2ucvSREBD+H-Q4g@mail.gmail.com>



On 2015/9/28 15:40, Ard Biesheuvel wrote:
> On 28 September 2015 at 06:34, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> Now, ARM64 is also support EFI startup. We hope use EFI runtime services
>> to get/set current time and date.
>>
>> RTC_LIB only controls some configs in drivers/char/Kconfig(included
>> EFI_RTC), and will be automatically selected when RTC_CLASS opened. So
>> this patch have no functional change but give an opportunity to select
>> EFI_RTC when RTC_CLASS closed.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm64/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 07d1811..25cec57 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -85,7 +85,7 @@ config ARM64
>>         select PERF_USE_VMALLOC
>>         select POWER_RESET
>>         select POWER_SUPPLY
>> -       select RTC_LIB
>> +       select RTC_LIB if !EFI
>>         select SPARSE_IRQ
>>         select SYSCTL_EXCEPTION_TRACE
>>         select HAVE_CONTEXT_TRACKING
> 
> You can currently enable EFI_RTC just fine on arm64 when EFI is enabled.
> Why exactly do you need this patch on top?

Because when we run "make ARCH=arm64 menuconfig", RTC_LIB is always selected. And we have no opportunity
to deselect it. And EFI_RTC can be displayed only when RTC_LIB=n.

--------drivers/rtc/Kconfig-------
config RTC_LIB
        bool

menuconfig RTC_CLASS
        bool "Real Time Clock"
        default n
        depends on !S390 && !UML
        select RTC_LIB

--------------drivers/char/Kconfig--------------
if RTC_LIB=n

......

config EFI_RTC
        bool "EFI Real Time Clock Services"
        depends on IA64 || ARM64

.......

endif # RTC_LIB

> 
> .
> 

WARNING: multiple messages have this Message-ID (diff)
From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will.deacon@arm.com>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Arnd Bergmann <arnd@arndb.de>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Kefeng Wang <wangkefeng.wang@huawei.com>,
	Xinwei Hu <huxinwei@huawei.com>, Zefan Li <lizefan@huawei.com>,
	Tianhong Ding <dingtianhong@huawei.com>,
	Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date: Mon, 28 Sep 2015 16:41:19 +0800	[thread overview]
Message-ID: <5608FD2F.1000105@huawei.com> (raw)
In-Reply-To: <CAKv+Gu_uFi03XVf5mX9Qy7eH=m1Q1ufpBNN2ucvSREBD+H-Q4g@mail.gmail.com>



On 2015/9/28 15:40, Ard Biesheuvel wrote:
> On 28 September 2015 at 06:34, Zhen Lei <thunder.leizhen@huawei.com> wrote:
>> Now, ARM64 is also support EFI startup. We hope use EFI runtime services
>> to get/set current time and date.
>>
>> RTC_LIB only controls some configs in drivers/char/Kconfig(included
>> EFI_RTC), and will be automatically selected when RTC_CLASS opened. So
>> this patch have no functional change but give an opportunity to select
>> EFI_RTC when RTC_CLASS closed.
>>
>> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
>> ---
>>  arch/arm64/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 07d1811..25cec57 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -85,7 +85,7 @@ config ARM64
>>         select PERF_USE_VMALLOC
>>         select POWER_RESET
>>         select POWER_SUPPLY
>> -       select RTC_LIB
>> +       select RTC_LIB if !EFI
>>         select SPARSE_IRQ
>>         select SYSCTL_EXCEPTION_TRACE
>>         select HAVE_CONTEXT_TRACKING
> 
> You can currently enable EFI_RTC just fine on arm64 when EFI is enabled.
> Why exactly do you need this patch on top?

Because when we run "make ARCH=arm64 menuconfig", RTC_LIB is always selected. And we have no opportunity
to deselect it. And EFI_RTC can be displayed only when RTC_LIB=n.

--------drivers/rtc/Kconfig-------
config RTC_LIB
        bool

menuconfig RTC_CLASS
        bool "Real Time Clock"
        default n
        depends on !S390 && !UML
        select RTC_LIB

--------------drivers/char/Kconfig--------------
if RTC_LIB=n

......

config EFI_RTC
        bool "EFI Real Time Clock Services"
        depends on IA64 || ARM64

.......

endif # RTC_LIB

> 
> .
> 


  reply	other threads:[~2015-09-28  8:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28  5:34 [PATCH 0/2] to allow EFI_RTC can be selected on ARM64 Zhen Lei
2015-09-28  5:34 ` Zhen Lei
2015-09-28  5:34 ` [PATCH 1/2] char/rtc: " Zhen Lei
2015-09-28  5:34   ` Zhen Lei
2015-09-28  5:34 ` [PATCH 2/2] arm64: " Zhen Lei
2015-09-28  5:34   ` Zhen Lei
2015-09-28  7:35   ` Arnd Bergmann
2015-09-28  7:35     ` Arnd Bergmann
2015-09-28  8:29     ` Leizhen (ThunderTown)
2015-09-28  8:29       ` Leizhen (ThunderTown)
2015-09-28  8:42       ` Arnd Bergmann
2015-09-28  8:42         ` Arnd Bergmann
2015-09-28  9:44         ` Leizhen (ThunderTown)
2015-09-28  9:44           ` Leizhen (ThunderTown)
2015-09-28  9:56           ` Arnd Bergmann
2015-09-28  9:56             ` Arnd Bergmann
2015-10-08  9:07           ` Leizhen (ThunderTown)
2015-10-08  9:07             ` Leizhen (ThunderTown)
2015-09-28  7:40   ` Ard Biesheuvel
2015-09-28  7:40     ` Ard Biesheuvel
2015-09-28  8:41     ` Leizhen (ThunderTown) [this message]
2015-09-28  8:41       ` Leizhen (ThunderTown)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5608FD2F.1000105@huawei.com \
    --to=thunder.leizhen@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.