All of lore.kernel.org
 help / color / mirror / Atom feed
From: julien.grall@citrix.com (Julien Grall)
To: linux-arm-kernel@lists.infradead.org
Subject: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
Date: Mon, 28 Sep 2015 14:59:18 +0100	[thread overview]
Message-ID: <560947B6.1030101@citrix.com> (raw)
In-Reply-To: <56094600.7050508@citrix.com>

Hi David,

On 28/09/15 14:52, David Vrabel wrote:
> On 28/09/15 14:30, Julien Grall wrote:
>> The PCI support for Xen doesn't compile on ARM/ARM64 when
>> CONFIG_PCI_MMCONFIG=y:
>>
>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or
>> directory
>>  #include <asm/pci_x86.h>
>>
>> Although, Xen is not currently involved in PCI management for ARM/ARM64.
>> There is plan to support it, but it would require some changes in Linux
>> side.
>>
>> For now, introduce a new config options XEN_PCI which will be turned off
>> for ARM platform.
> 
> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c
> is, can you fix this by changing to #ifdef CONFIG_X86?

Well, it may be possible that we need this code for ARM/ARM64.

>From the origin thread [1], it wasn't clear what is the correct
solution. So I think that disabling the Xen PCI code for now is the
right solution.

Note, that it's still possible to use PCI in DOM0 on ARM64 platform
without this code.

Regards,

[1] https://lkml.org/lkml/2015/8/6/510

-- 
Julien Grall

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@citrix.com>
To: David Vrabel <david.vrabel@citrix.com>, <xen-devel@lists.xenproject.org>
Cc: <ian.campbell@citrix.com>, <stefano.stabellini@eu.citrix.com>,
	<linux-kernel@vger.kernel.org>,
	Robert Richter <robert.richter@caviumnetworks.com>,
	Boris Ostrovsky <boris.ostrovsky@oracle.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Xen-devel] [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64
Date: Mon, 28 Sep 2015 14:59:18 +0100	[thread overview]
Message-ID: <560947B6.1030101@citrix.com> (raw)
In-Reply-To: <56094600.7050508@citrix.com>

Hi David,

On 28/09/15 14:52, David Vrabel wrote:
> On 28/09/15 14:30, Julien Grall wrote:
>> The PCI support for Xen doesn't compile on ARM/ARM64 when
>> CONFIG_PCI_MMCONFIG=y:
>>
>> drivers/xen/pci.c:31:25: fatal error: asm/pci_x86.h: No such file or
>> directory
>>  #include <asm/pci_x86.h>
>>
>> Although, Xen is not currently involved in PCI management for ARM/ARM64.
>> There is plan to support it, but it would require some changes in Linux
>> side.
>>
>> For now, introduce a new config options XEN_PCI which will be turned off
>> for ARM platform.
> 
> Since PCI_MMCONFIG isn't x86 specific and its use in drivers/xen/pci.c
> is, can you fix this by changing to #ifdef CONFIG_X86?

Well, it may be possible that we need this code for ARM/ARM64.

>From the origin thread [1], it wasn't clear what is the correct
solution. So I think that disabling the Xen PCI code for now is the
right solution.

Note, that it's still possible to use PCI in DOM0 on ARM64 platform
without this code.

Regards,

[1] https://lkml.org/lkml/2015/8/6/510

-- 
Julien Grall

  reply	other threads:[~2015-09-28 13:59 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 13:30 [PATCH] xen/pci: Don't build Xen pci code for ARM and ARM64 Julien Grall
2015-09-28 13:30 ` Julien Grall
2015-09-28 13:48 ` Stefano Stabellini
2015-09-28 13:48 ` Stefano Stabellini
2015-09-28 13:48   ` Stefano Stabellini
2015-09-28 14:01   ` Julien Grall
2015-09-28 14:01     ` Julien Grall
2015-09-28 14:01   ` Julien Grall
2015-09-28 13:52 ` David Vrabel
2015-09-28 13:52 ` [Xen-devel] " David Vrabel
2015-09-28 13:52   ` David Vrabel
2015-09-28 13:59   ` Julien Grall [this message]
2015-09-28 13:59     ` Julien Grall
2015-09-28 14:02     ` Boris Ostrovsky
2015-09-28 14:02       ` Boris Ostrovsky
2015-09-28 14:22       ` David Vrabel
2015-09-28 14:22       ` [Xen-devel] " David Vrabel
2015-09-28 14:22         ` David Vrabel
2015-09-28 14:23       ` Julien Grall
2015-09-28 14:23       ` [Xen-devel] " Julien Grall
2015-09-28 14:23         ` Julien Grall
2015-09-28 14:02     ` Boris Ostrovsky
2015-09-28 13:59   ` Julien Grall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560947B6.1030101@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.