All of lore.kernel.org
 help / color / mirror / Atom feed
From: vladimir.murzin@arm.com (Vladimir Murzin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 16/22] arm64/debug: Make use of the system wide safe value
Date: Tue, 29 Sep 2015 13:17:29 +0100	[thread overview]
Message-ID: <560A8159.8000300@arm.com> (raw)
In-Reply-To: <1442413280-31885-17-git-send-email-suzuki.poulose@arm.com>

On 16/09/15 15:21, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
> 
> Use the system wide value of ID_AA64DFR0 to make safer decisions
> 
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/include/asm/hw_breakpoint.h |   14 ++------------
>  arch/arm64/kernel/debug-monitors.c     |    6 ++++--
>  arch/arm64/kernel/hw_breakpoint.c      |   19 ++++++++++++++++++-
>  3 files changed, 24 insertions(+), 15 deletions(-)
> 

Looks like this patch introduces build-time regression if
CONFIG_PERF_EVENTS is not set:

> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension':
> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps'
> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps'
> make: *** [vmlinux] Error 1

Vladimir

WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Murzin <vladimir.murzin@arm.com>
To: "Suzuki K. Poulose" <suzuki.poulose@arm.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>
Cc: Mark Rutland <Mark.Rutland@arm.com>,
	"ard.biesheuvel@linaro.org" <ard.biesheuvel@linaro.org>,
	"aph@redhat.com" <aph@redhat.com>,
	Catalin Marinas <Catalin.Marinas@arm.com>,
	Will Deacon <Will.Deacon@arm.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"edward.nevill@linaro.org" <edward.nevill@linaro.org>,
	Andre Przywara <Andre.Przywara@arm.com>,
	Marc Zyngier <Marc.Zyngier@arm.com>,
	Dave P Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH 16/22] arm64/debug: Make use of the system wide safe value
Date: Tue, 29 Sep 2015 13:17:29 +0100	[thread overview]
Message-ID: <560A8159.8000300@arm.com> (raw)
In-Reply-To: <1442413280-31885-17-git-send-email-suzuki.poulose@arm.com>

On 16/09/15 15:21, Suzuki K. Poulose wrote:
> From: "Suzuki K. Poulose" <suzuki.poulose@arm.com>
> 
> Use the system wide value of ID_AA64DFR0 to make safer decisions
> 
> Signed-off-by: Suzuki K. Poulose <suzuki.poulose@arm.com>
> ---
>  arch/arm64/include/asm/hw_breakpoint.h |   14 ++------------
>  arch/arm64/kernel/debug-monitors.c     |    6 ++++--
>  arch/arm64/kernel/hw_breakpoint.c      |   19 ++++++++++++++++++-
>  3 files changed, 24 insertions(+), 15 deletions(-)
> 

Looks like this patch introduces build-time regression if
CONFIG_PERF_EVENTS is not set:

> arch/arm64/kvm/built-in.o: In function `kvm_arm_setup_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:173: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:177: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arm_clear_debug':
> /work/tools/linux/arch/arm64/kvm/debug.c:208: undefined reference to `get_num_brps'
> /work/tools/linux/arch/arm64/kvm/debug.c:212: undefined reference to `get_num_wrps'
> arch/arm64/kvm/built-in.o: In function `kvm_arch_dev_ioctl_check_extension':
> /work/tools/linux/arch/arm64/kvm/reset.c:78: undefined reference to `get_num_wrps'
> /work/tools/linux/arch/arm64/kvm/reset.c:75: undefined reference to `get_num_brps'
> make: *** [vmlinux] Error 1

Vladimir


  reply	other threads:[~2015-09-29 12:17 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-16 14:20 [PATCH 00/22] arm64: Consolidate CPU feature handling Suzuki K. Poulose
2015-09-16 14:20 ` Suzuki K. Poulose
2015-09-16 14:20 ` [PATCH 01/22] arm64: Make the CPU information more clear Suzuki K. Poulose
2015-09-16 14:20   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 02/22] arm64: Delay ELF HWCAP initialisation until all CPUs are up Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 03/22] arm64: Move cpu feature detection code Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 04/22] arm64: Move mixed endian support detection Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 05/22] arm64: Move /proc/cpuinfo handling code Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 06/22] arm64: sys_reg: Define System register encoding Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 07/22] arm64: Keep track of CPU feature registers Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-25 11:38   ` Dave Martin
2015-09-25 11:38     ` Dave Martin
2015-09-25 13:05     ` Suzuki K. Poulose
2015-09-25 13:05       ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 08/22] arm64: Consolidate CPU Sanity check to CPU Feature infrastructure Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 09/22] arm64: Read system wide CPUID value Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 10/22] arm64: Cleanup mixed endian support detection Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 11/22] arm64: Populate cpuinfo after notify_cpu_starting Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 12/22] arm64: Delay cpu feature checks Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 13/22] arm64: Make use of system wide capability checks Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 14/22] arm64: Cleanup HWCAP handling Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 15/22] arm64: Move FP/ASIMD hwcap handling to common code Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 16/22] arm64/debug: Make use of the system wide safe value Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-29 12:17   ` Vladimir Murzin [this message]
2015-09-29 12:17     ` Vladimir Murzin
2015-09-29 12:46     ` Suzuki K. Poulose
2015-09-29 12:46       ` Suzuki K. Poulose
2015-09-30 16:13     ` Suzuki K. Poulose
2015-09-30 16:13       ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 17/22] arm64/kvm: Make use of the system wide safe values Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 18/22] arm64: Add helper to decode register from instruction Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 19/22] arm64: cpufeature: Track the user visible fields Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 20/22] arm64: Expose feature registers by emulating MRS Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 21/22] arm64: cpuinfo: Expose MIDR_EL1 and REVIDR_EL1 to sysfs Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-16 14:21 ` [PATCH 22/22] arm64: feature registers: Documentation Suzuki K. Poulose
2015-09-16 14:21   ` Suzuki K. Poulose
2015-09-18  9:23 ` [PATCH 00/22] arm64: Consolidate CPU feature handling Suzuki K. Poulose
2015-09-18  9:23   ` Suzuki K. Poulose
2015-09-22 15:19   ` James Morse
2015-09-22 15:19     ` James Morse
2015-09-22 15:21     ` Suzuki K. Poulose
2015-09-22 15:21       ` Suzuki K. Poulose
2015-09-23 15:56 ` Dave Martin
2015-09-23 15:56   ` Dave Martin
2015-09-23 15:58   ` Suzuki K. Poulose
2015-09-23 15:58     ` Suzuki K. Poulose
2015-09-23 16:37     ` Suzuki K. Poulose
2015-09-23 16:37       ` Suzuki K. Poulose
2015-09-23 17:08       ` Dave P Martin
2015-09-23 17:08         ` Dave P Martin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560A8159.8000300@arm.com \
    --to=vladimir.murzin@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.