All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Sagi Grimberg <sagig@dev.mellanox.co.il>,
	Sagi Grimberg <sagig@mellanox.com>,
	"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	"Nicholas A. Bellinger" <nab@linux-iscsi.org>
Subject: Re: [PATCH v1 00/24] New fast registration API
Date: Wed, 30 Sep 2015 13:15:10 -0700	[thread overview]
Message-ID: <560C42CE.6090000@sandisk.com> (raw)
In-Reply-To: <560C30F4.50900@sandisk.com>

On 09/30/2015 11:59 AM, Bart Van Assche wrote:
> On 09/29/2015 01:58 PM, Sagi Grimberg wrote:
>> On 9/29/2015 10:03 PM, Bart Van Assche wrote:
>>> On 09/17/2015 02:42 AM, Sagi Grimberg wrote:
>>>> - Converted SRP initiator and RDS iwarp ULPs to the new API
>>> How has the converted SRP initiator driver been tested ? With the kernel
>>> tree that is available on branch reg_api.4
>>
>> That's odd. Although I haven't formally submitted reg_api.4 yet, I did
>> test ib_srp initiator against upstream srpt over CX3 (mlx4) and CX4
>> (mlx5). I ran connect, disconnect, stress IO of all block sizes and
>> some unaligned block-IO and SG_IO test utilities. It all seems to pass
>> for me.
>>
>> Just this morning (my morning) I tested the v2 set on iser, srp, nfs. I
>> placed that in branch reg_api.5. Would you mind running reg_api.5 and
>> see if this issue persist (I would be surprised because I haven't seen
>> any sign of it)?
>
> Sorry but I still see these messages with the reg_api.5 branch.
> [root@ib-ini linux-kernel]# git show HEAD | grep ^commit
> commit 3b5b34777d3cd606433f0aca51e3885323648e07
> [root@ib-ini linux-kernel]# uname -a
> Linux ib-ini 4.2.0-rc6-debug+ #1 SMP Wed Sep 30 11:38:36 PDT 2015 x86_64
> x86_64 x86_64 GNU/Linux
>
> I will try to run a bisect.

(replying to my own e-mail)

Apparently this behavior got introduced through the patch "IB/srp: 
Convert to new registration API" (commit 
ad66cbace5ca8c60673bedf35e5027868b0dd2d7). Without that patch SRP I/O 
works fine. With that patch I see receive failures being reported. The 
SRP initiator was loaded on my setup with the following kernel driver 
options:

# cat /etc/modprobe.d/ib_srp.conf
options ib_srp cmd_sg_entries=255 prefer_fr=1 register_always=1

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: Sagi Grimberg
	<sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>,
	Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: "linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Nicholas A. Bellinger"
	<nab-IzHhD5pYlfBP7FQvKIMDCQ@public.gmane.org>
Subject: Re: [PATCH v1 00/24] New fast registration API
Date: Wed, 30 Sep 2015 13:15:10 -0700	[thread overview]
Message-ID: <560C42CE.6090000@sandisk.com> (raw)
In-Reply-To: <560C30F4.50900-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>

On 09/30/2015 11:59 AM, Bart Van Assche wrote:
> On 09/29/2015 01:58 PM, Sagi Grimberg wrote:
>> On 9/29/2015 10:03 PM, Bart Van Assche wrote:
>>> On 09/17/2015 02:42 AM, Sagi Grimberg wrote:
>>>> - Converted SRP initiator and RDS iwarp ULPs to the new API
>>> How has the converted SRP initiator driver been tested ? With the kernel
>>> tree that is available on branch reg_api.4
>>
>> That's odd. Although I haven't formally submitted reg_api.4 yet, I did
>> test ib_srp initiator against upstream srpt over CX3 (mlx4) and CX4
>> (mlx5). I ran connect, disconnect, stress IO of all block sizes and
>> some unaligned block-IO and SG_IO test utilities. It all seems to pass
>> for me.
>>
>> Just this morning (my morning) I tested the v2 set on iser, srp, nfs. I
>> placed that in branch reg_api.5. Would you mind running reg_api.5 and
>> see if this issue persist (I would be surprised because I haven't seen
>> any sign of it)?
>
> Sorry but I still see these messages with the reg_api.5 branch.
> [root@ib-ini linux-kernel]# git show HEAD | grep ^commit
> commit 3b5b34777d3cd606433f0aca51e3885323648e07
> [root@ib-ini linux-kernel]# uname -a
> Linux ib-ini 4.2.0-rc6-debug+ #1 SMP Wed Sep 30 11:38:36 PDT 2015 x86_64
> x86_64 x86_64 GNU/Linux
>
> I will try to run a bisect.

(replying to my own e-mail)

Apparently this behavior got introduced through the patch "IB/srp: 
Convert to new registration API" (commit 
ad66cbace5ca8c60673bedf35e5027868b0dd2d7). Without that patch SRP I/O 
works fine. With that patch I see receive failures being reported. The 
SRP initiator was loaded on my setup with the following kernel driver 
options:

# cat /etc/modprobe.d/ib_srp.conf
options ib_srp cmd_sg_entries=255 prefer_fr=1 register_always=1

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-09-30 20:29 UTC|newest]

Thread overview: 134+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-17  9:42 [PATCH v1 00/24] New fast registration API Sagi Grimberg
2015-09-17  9:42 ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 01/24] IB/core: Introduce new " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-22 21:21   ` Bart Van Assche
2015-09-22 21:21     ` Bart Van Assche
2015-09-24  7:37     ` Sagi Grimberg
2015-09-24  7:37       ` Sagi Grimberg
2015-09-28 20:57       ` Bart Van Assche
2015-09-28 20:57         ` Bart Van Assche
2015-09-29  5:59         ` Christoph Hellwig
2015-09-29  5:59           ` Christoph Hellwig
2015-09-29  6:47           ` Sagi Grimberg
2015-09-29  6:47             ` Sagi Grimberg
2015-09-29  6:49             ` Sagi Grimberg
2015-09-29  6:49               ` Sagi Grimberg
2015-09-29  6:42         ` Sagi Grimberg
2015-09-29  6:42           ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 02/24] IB/mlx5: Remove dead fmr code Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-22 21:24   ` Bart Van Assche
2015-09-22 21:24     ` Bart Van Assche
2015-09-17  9:42 ` [PATCH v1 03/24] IB/mlx5: Support the new memory registration API Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-22 21:27   ` Bart Van Assche
2015-09-22 21:27     ` Bart Van Assche
2015-09-24  7:39     ` Sagi Grimberg
2015-09-24  7:39       ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 04/24] IB/mlx4: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 05/24] RDMA/ocrdma: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 06/24] RDMA/cxgb3: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 07/24] iw_cxgb4: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 08/24] IB/qib: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 09/24] RDMA/nes: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 10/24] IB/iser: Port to new fast " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 11/24] iser-target: Port to new memory " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 12/24] xprtrdma: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 13/24] svcrdma: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 14/24] RDS/IW: Convert " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 15/24] IB/srp: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-22 21:58   ` Bart Van Assche
2015-09-22 21:58     ` Bart Van Assche
2015-09-24  9:06     ` Sagi Grimberg
2015-09-24  9:06       ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 16/24] IB/mlx5: Remove old FRWR API support Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 17/24] IB/mlx4: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 18/24] RDMA/ocrdma: Remove old FRWR API Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 19/24] RDMA/cxgb3: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 20/24] iw_cxgb4: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 21/24] IB/qib: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 22/24] RDMA/nes: " Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 23/24] IB/hfi1: Remove Old fast registraion API support Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-17  9:42 ` [PATCH v1 24/24] IB/core: Remove old fast registration API Sagi Grimberg
2015-09-17  9:42   ` Sagi Grimberg
2015-09-19 22:45 ` [PATCH v1 00/24] New " Christoph Hellwig
2015-09-19 22:45   ` Christoph Hellwig
2015-09-24  6:53   ` Sagi Grimberg
2015-09-24  6:53     ` Sagi Grimberg
2015-09-24 13:39     ` Christoph Hellwig
2015-09-24 13:39       ` Christoph Hellwig
2015-09-19 23:20 ` santosh.shilimkar
2015-09-19 23:20   ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-20  9:36   ` Sagi Grimberg
2015-09-20  9:36     ` Sagi Grimberg
2015-09-21 23:28     ` santosh.shilimkar
2015-09-21 23:28       ` santosh.shilimkar-QHcLZuEGTsvQT0dZR+AlfA
2015-09-22  7:19       ` Sagi Grimberg
2015-09-22  7:19         ` Sagi Grimberg
2015-09-22  7:56         ` Sagi Grimberg
2015-09-22  7:56           ` Sagi Grimberg
2015-09-22 18:23           ` santosh shilimkar
2015-09-22 18:23             ` santosh shilimkar
2015-09-22 21:22 ` Bart Van Assche
2015-09-22 21:22   ` Bart Van Assche
2015-09-24  7:40   ` Sagi Grimberg
2015-09-24  7:40     ` Sagi Grimberg
2015-09-29 19:03 ` Bart Van Assche
2015-09-29 19:03   ` Bart Van Assche
2015-09-29 20:58   ` Sagi Grimberg
2015-09-29 20:58     ` Sagi Grimberg
2015-09-30  6:47     ` Sagi Grimberg
2015-09-30  6:47       ` Sagi Grimberg
2015-09-30 18:59     ` Bart Van Assche
2015-09-30 18:59       ` Bart Van Assche
2015-09-30 20:15       ` Bart Van Assche [this message]
2015-09-30 20:15         ` Bart Van Assche
2015-10-01  7:16         ` Sagi Grimberg
2015-10-01  7:16           ` Sagi Grimberg
2015-10-01 17:53           ` Bart Van Assche
2015-10-01 17:53             ` Bart Van Assche
2015-10-01 20:58             ` Bart Van Assche
2015-10-01 20:58               ` Bart Van Assche
     [not found]               ` <35618B90-4D6E-4036-A69B-4405F020D440@dev.mellanox.co.il>
2015-10-02 15:37                 ` Bart Van Assche
2015-10-02 15:37                   ` Bart Van Assche
2015-10-06  8:37                   ` Sagi Grimberg
2015-10-06  8:37                     ` Sagi Grimberg
2015-10-06 18:49                     ` Bart Van Assche
2015-10-06 18:49                       ` Bart Van Assche
2015-10-07  6:42                       ` Sagi Grimberg
2015-10-07  6:42                         ` Sagi Grimberg
2015-10-07 15:46                         ` Bart Van Assche
2015-10-07 15:46                           ` Bart Van Assche
2015-10-07 15:48                           ` Sagi Grimberg
2015-10-07 15:48                             ` Sagi Grimberg
2015-10-07  9:20                     ` Christoph Hellwig
2015-10-07  9:20                       ` Christoph Hellwig
2015-10-07  9:25                       ` Sagi Grimberg
2015-10-07  9:25                         ` Sagi Grimberg
2015-10-07  9:36                         ` Christoph Hellwig
2015-10-07  9:36                           ` Christoph Hellwig
2015-10-07 10:00                           ` Sagi Grimberg
2015-10-07 10:00                             ` Sagi Grimberg
2015-10-07 16:30                       ` Bart Van Assche
2015-10-07 16:30                         ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560C42CE.6090000@sandisk.com \
    --to=bart.vanassche@sandisk.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=sagig@dev.mellanox.co.il \
    --cc=sagig@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.