From: Or Gerlitz <ogerlitz@mellanox.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org,
Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Martin Kletzander <mkletzan@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>
Subject: Re: [PATCH] staging: rdma: Fix braces around if/else
Date: Sun, 4 Oct 2015 09:47:52 +0300 [thread overview]
Message-ID: <5610CB98.1090907@mellanox.com> (raw)
In-Reply-To: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com>
On 10/3/2015 11:55 PM, Martin Kletzander wrote:
> Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.
Hi Greg,
Is there a way to signal people/tools that a certain driver parks in
staging on their way **out** of the kernel
and not the other way around? I guess you (nor Doug) don't want to spend
time on fixing such drivers, right?
Or.
>
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
> There is one warning reported in this patch though. That's because of
> the multiline string and it's pre-existing. Feel free to let me know
> if that should be fixed too, I'd also remove the pointless '#' then.
> On the other hand, it'll create more-than-80-columns long line.
>
> drivers/staging/rdma/ipath/ipath_driver.c | 19 ++++++++-----------
> drivers/staging/rdma/ipath/ipath_file_ops.c | 12 ++++++------
> drivers/staging/rdma/ipath/ipath_iba6110.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++-----
> drivers/staging/rdma/ipath/ipath_intr.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_sysfs.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_verbs.c | 4 ++--
> 7 files changed, 30 insertions(+), 36 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Or Gerlitz <ogerlitz@mellanox.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Martin Kletzander <mkletzan@redhat.com>,
<devel@driverdev.osuosl.org>,
Mike Marciniszyn <infinipath@intel.com>,
Doug Ledford <dledford@redhat.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rdma: Fix braces around if/else
Date: Sun, 4 Oct 2015 09:47:52 +0300 [thread overview]
Message-ID: <5610CB98.1090907@mellanox.com> (raw)
In-Reply-To: <1b3a2e933e163bf11a2163c76bedd074551c1b9a.1443901389.git.mkletzan@redhat.com>
On 10/3/2015 11:55 PM, Martin Kletzander wrote:
> Get rid of all ELSE_AFTER_BRACE type errors reported by checkpatch.pl.
Hi Greg,
Is there a way to signal people/tools that a certain driver parks in
staging on their way **out** of the kernel
and not the other way around? I guess you (nor Doug) don't want to spend
time on fixing such drivers, right?
Or.
>
> Signed-off-by: Martin Kletzander <mkletzan@redhat.com>
> ---
> There is one warning reported in this patch though. That's because of
> the multiline string and it's pre-existing. Feel free to let me know
> if that should be fixed too, I'd also remove the pointless '#' then.
> On the other hand, it'll create more-than-80-columns long line.
>
> drivers/staging/rdma/ipath/ipath_driver.c | 19 ++++++++-----------
> drivers/staging/rdma/ipath/ipath_file_ops.c | 12 ++++++------
> drivers/staging/rdma/ipath/ipath_iba6110.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_init_chip.c | 10 +++++-----
> drivers/staging/rdma/ipath/ipath_intr.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_sysfs.c | 7 +++----
> drivers/staging/rdma/ipath/ipath_verbs.c | 4 ++--
> 7 files changed, 30 insertions(+), 36 deletions(-)
next prev parent reply other threads:[~2015-10-04 6:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 20:55 [PATCH] staging: rdma: Fix braces around if/else Martin Kletzander
2015-10-03 20:55 ` Martin Kletzander
2015-10-04 6:47 ` Or Gerlitz [this message]
2015-10-04 6:47 ` Or Gerlitz
[not found] ` <5610CB98.1090907-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-10-04 7:20 ` Greg Kroah-Hartman
2015-10-04 7:20 ` Greg Kroah-Hartman
2015-10-04 9:05 ` Martin Kletzander
2015-10-04 9:05 ` Martin Kletzander
2015-10-04 10:11 ` Greg Kroah-Hartman
2015-10-04 10:11 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5610CB98.1090907@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=devel@driverdev.osuosl.org \
--cc=dledford@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hal.rosenstock@gmail.com \
--cc=infinipath@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mkletzan@redhat.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.