* [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
@ 2015-10-04 2:15 Jonathan Liu
2015-10-04 10:50 ` Andreas Müller
2015-10-13 17:46 ` Andrei Gherzan
0 siblings, 2 replies; 4+ messages in thread
From: Jonathan Liu @ 2015-10-04 2:15 UTC (permalink / raw)
To: yocto
SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
Signed-off-by: Jonathan Liu <net147@gmail.com>
---
recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
index d60a3e9..70e8bfe 100644
--- a/recipes-kernel/linux/linux-raspberrypi.inc
+++ b/recipes-kernel/linux/linux-raspberrypi.inc
@@ -12,7 +12,8 @@ SRC_URI += " \
COMPATIBLE_MACHINE = "raspberrypi"
-PV = "${LINUX_VERSION}+git${SRCREV}"
+PE = "1"
+PV = "${LINUX_VERSION}+git${SRCPV}"
# NOTE: For now we pull in the default config from the RPi kernel GIT tree.
KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
--
2.6.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
2015-10-04 2:15 [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV Jonathan Liu
@ 2015-10-04 10:50 ` Andreas Müller
2015-10-04 11:14 ` Jonathan Liu
2015-10-13 17:46 ` Andrei Gherzan
1 sibling, 1 reply; 4+ messages in thread
From: Andreas Müller @ 2015-10-04 10:50 UTC (permalink / raw)
To: Jonathan Liu; +Cc: Yocto Project
On Sun, Oct 4, 2015 at 4:15 AM, Jonathan Liu <net147@gmail.com> wrote:
> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index d60a3e9..70e8bfe 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -12,7 +12,8 @@ SRC_URI += " \
>
> COMPATIBLE_MACHINE = "raspberrypi"
>
> -PV = "${LINUX_VERSION}+git${SRCREV}"
> +PE = "1"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
Doesn't PRServer takes care for things like these?
Andreas
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
2015-10-04 10:50 ` Andreas Müller
@ 2015-10-04 11:14 ` Jonathan Liu
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Liu @ 2015-10-04 11:14 UTC (permalink / raw)
To: Andreas Müller; +Cc: Yocto Project
On 4/10/2015 9:50 PM, Andreas Müller wrote:
> On Sun, Oct 4, 2015 at 4:15 AM, Jonathan Liu <net147@gmail.com> wrote:
>> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>>
>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>> ---
>> recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
>> index d60a3e9..70e8bfe 100644
>> --- a/recipes-kernel/linux/linux-raspberrypi.inc
>> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
>> @@ -12,7 +12,8 @@ SRC_URI += " \
>>
>> COMPATIBLE_MACHINE = "raspberrypi"
>>
>> -PV = "${LINUX_VERSION}+git${SRCREV}"
>> +PE = "1"
>> +PV = "${LINUX_VERSION}+git${SRCPV}"
>>
> Doesn't PRServer takes care for things like these?
>
> Andreas
The version goes backwards because the the revision is shortened. It
does rebuild the package though when the version changes because of
PRServer but it breaks package feeds when the version goes backwards.
Upgrading using package manager on the target device would not detect a
newer version.
Regards,
Jonathan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV
2015-10-04 2:15 [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV Jonathan Liu
2015-10-04 10:50 ` Andreas Müller
@ 2015-10-13 17:46 ` Andrei Gherzan
1 sibling, 0 replies; 4+ messages in thread
From: Andrei Gherzan @ 2015-10-13 17:46 UTC (permalink / raw)
To: Jonathan Liu; +Cc: yocto
On Sun, Oct 04, 2015 at 01:15:33PM +1100, Jonathan Liu wrote:
> SRCPV is intended to be used by PV. Using SRCREV for PV is incorrect.
>
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
> recipes-kernel/linux/linux-raspberrypi.inc | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/recipes-kernel/linux/linux-raspberrypi.inc b/recipes-kernel/linux/linux-raspberrypi.inc
> index d60a3e9..70e8bfe 100644
> --- a/recipes-kernel/linux/linux-raspberrypi.inc
> +++ b/recipes-kernel/linux/linux-raspberrypi.inc
> @@ -12,7 +12,8 @@ SRC_URI += " \
>
> COMPATIBLE_MACHINE = "raspberrypi"
>
> -PV = "${LINUX_VERSION}+git${SRCREV}"
> +PE = "1"
> +PV = "${LINUX_VERSION}+git${SRCPV}"
>
> # NOTE: For now we pull in the default config from the RPi kernel GIT tree.
> KERNEL_DEFCONFIG_raspberrypi ?= "bcmrpi_defconfig"
> --
> 2.6.0
>
I tested build locally and based on your comments on PE I merged this patch.
Thanks,
--
Andrei Gherzan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-10-13 17:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-04 2:15 [meta-raspberrypi][PATCH v3] linux-raspberrypi.inc: use SRCPV instead of SRCREV for PV Jonathan Liu
2015-10-04 10:50 ` Andreas Müller
2015-10-04 11:14 ` Jonathan Liu
2015-10-13 17:46 ` Andrei Gherzan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.