From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
Date: Mon, 5 Oct 2015 07:11:51 -0700 [thread overview]
Message-ID: <56128527.1000703@sandisk.com> (raw)
In-Reply-To: <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk>
On 10/05/15 02:26, Rasmus Villemoes wrote:
> struct error_info {
> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */
> - const char * text;
> + unsigned short size;
> };
Had you considered to use the type uint16_t instead of unsigned short ?
Bart.
WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Christoph Hellwig <hch@infradead.org>,
Hannes Reinecke <hare@suse.de>,
"James E.J. Bottomley" <JBottomley@odin.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k
Date: Mon, 5 Oct 2015 07:11:51 -0700 [thread overview]
Message-ID: <56128527.1000703@sandisk.com> (raw)
In-Reply-To: <1444037200-14684-3-git-send-email-linux@rasmusvillemoes.dk>
On 10/05/15 02:26, Rasmus Villemoes wrote:
> struct error_info {
> unsigned short code12; /* 0x0302 looks better than 0x03,0x02 */
> - const char * text;
> + unsigned short size;
> };
Had you considered to use the type uint16_t instead of unsigned short ?
Bart.
next prev parent reply other threads:[~2015-10-05 14:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 17:30 RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Rasmus Villemoes
2015-10-03 17:14 ` Christoph Hellwig
2015-10-03 22:09 ` Rasmus Villemoes
2015-10-04 8:02 ` Christoph Hellwig
2015-10-05 9:26 ` [PATCH 0/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-10-05 9:26 ` [PATCH 1/2] scsi: move Additional Sense Codes to separate file Rasmus Villemoes
2015-10-05 14:05 ` Bart Van Assche
2015-10-05 14:05 ` Bart Van Assche
2015-10-06 15:27 ` Rasmus Villemoes
2015-10-06 15:27 ` Rasmus Villemoes
2015-10-17 22:12 ` Rasmus Villemoes
2015-10-17 22:12 ` Rasmus Villemoes
2015-10-05 9:26 ` [PATCH 2/2] scsi: reduce CONFIG_SCSI_CONSTANTS=y impact by 8k Rasmus Villemoes
2015-10-05 14:11 ` Bart Van Assche [this message]
2015-10-05 14:11 ` Bart Van Assche
2015-10-06 15:31 ` Rasmus Villemoes
2015-10-06 15:31 ` Rasmus Villemoes
2015-10-06 1:32 ` RFC: reduce CONFIG_SCSI_CONSTANTS impact by 4k Julian Calaby
2015-10-06 15:39 ` Rasmus Villemoes
2015-10-06 15:39 ` Rasmus Villemoes
2015-10-06 23:01 ` Julian Calaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56128527.1000703@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=JBottomley@odin.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.