From: Roger Quadros <rogerq@ti.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Tony Lindgren" <tony@atomide.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification
Date: Wed, 7 Oct 2015 10:37:18 +0300 [thread overview]
Message-ID: <5614CBAE.8030603@ti.com> (raw)
In-Reply-To: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 06/10/15 23:07, Uwe Kleine-König wrote:
> When gpmc_cs_show_timings is called in gpmc_cs_set_timings()
> gpmc_cs_program_settings() was already run which modifies the CONFIG1
> register. So to be more useful do the "before" dump earlier.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/memory/omap-gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 32ac049f2bc4..6515dfc2b805 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -696,7 +696,6 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
> int div;
> u32 l;
>
> - gpmc_cs_show_timings(cs, "before gpmc_cs_set_timings");
> div = gpmc_calc_divider(t->sync_clk);
> if (div < 0)
> return div;
> @@ -1988,6 +1987,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
> if (ret < 0)
> goto err;
>
> + gpmc_cs_show_timings(cs, "before gpmc_cs_program_settings");
> ret = gpmc_cs_program_settings(cs, &gpmc_s);
> if (ret < 0)
> goto err;
>
cheers,
-roger
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification
Date: Wed, 7 Oct 2015 10:37:18 +0300 [thread overview]
Message-ID: <5614CBAE.8030603@ti.com> (raw)
In-Reply-To: <1444162070-22034-1-git-send-email-u.kleine-koenig@pengutronix.de>
On 06/10/15 23:07, Uwe Kleine-K?nig wrote:
> When gpmc_cs_show_timings is called in gpmc_cs_set_timings()
> gpmc_cs_program_settings() was already run which modifies the CONFIG1
> register. So to be more useful do the "before" dump earlier.
>
> Signed-off-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
Acked-by: Roger Quadros <rogerq@ti.com>
> ---
> drivers/memory/omap-gpmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
> index 32ac049f2bc4..6515dfc2b805 100644
> --- a/drivers/memory/omap-gpmc.c
> +++ b/drivers/memory/omap-gpmc.c
> @@ -696,7 +696,6 @@ int gpmc_cs_set_timings(int cs, const struct gpmc_timings *t,
> int div;
> u32 l;
>
> - gpmc_cs_show_timings(cs, "before gpmc_cs_set_timings");
> div = gpmc_calc_divider(t->sync_clk);
> if (div < 0)
> return div;
> @@ -1988,6 +1987,7 @@ static int gpmc_probe_generic_child(struct platform_device *pdev,
> if (ret < 0)
> goto err;
>
> + gpmc_cs_show_timings(cs, "before gpmc_cs_program_settings");
> ret = gpmc_cs_program_settings(cs, &gpmc_s);
> if (ret < 0)
> goto err;
>
cheers,
-roger
next prev parent reply other threads:[~2015-10-07 7:37 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 20:07 [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification Uwe Kleine-König
2015-10-06 20:07 ` Uwe Kleine-König
2015-10-06 20:07 ` [PATCH 2/2] memory: omap-gpmc: expand the description of the debug facility Uwe Kleine-König
2015-10-06 20:07 ` Uwe Kleine-König
2015-10-07 7:45 ` Roger Quadros
2015-10-07 7:45 ` Roger Quadros
2015-10-07 7:53 ` Uwe Kleine-König
2015-10-07 7:53 ` Uwe Kleine-König
2015-10-07 10:41 ` Tony Lindgren
2015-10-07 10:41 ` Tony Lindgren
2015-10-07 11:02 ` Uwe Kleine-König
2015-10-07 11:02 ` Uwe Kleine-König
2015-10-07 11:07 ` Roger Quadros
2015-10-07 11:07 ` Roger Quadros
2015-10-07 13:40 ` Tony Lindgren
2015-10-07 13:40 ` Tony Lindgren
2015-10-07 13:55 ` Roger Quadros
2015-10-07 13:55 ` Roger Quadros
2015-10-08 7:17 ` please strip MIME-Version and Content-T{ype,ransfer-Encoding} in git am --scissors Uwe Kleine-König
2015-10-08 19:28 ` Junio C Hamano
2015-10-08 19:37 ` Uwe Kleine-König
2015-10-08 20:04 ` Junio C Hamano
2015-10-08 20:23 ` Uwe Kleine-König
2015-10-09 1:43 ` [PATCH] mailinfo: ignore in-body header that we do not care about Junio C Hamano
2015-10-07 7:37 ` Roger Quadros [this message]
2015-10-07 7:37 ` [PATCH 1/2] memory: omap-gpmc: dump "before" state before first modification Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614CBAE.8030603@ti.com \
--to=rogerq@ti.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.